Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXi Yan2018-06-28 15:29:09 +0000
committerXi Yan2018-07-03 13:14:35 +0000
commit5b059c753c4145ff08c434a27ea7776a245547bc (patch)
treeee37728acd75bcdb6e81535b0ecf4bdbc5578984
parentd502cb4c54e2f70232c12c94487c9c59164fc133 (diff)
downloadeclipse.platform.swt-5b059c753c4145ff08c434a27ea7776a245547bc.tar.gz
eclipse.platform.swt-5b059c753c4145ff08c434a27ea7776a245547bc.tar.xz
eclipse.platform.swt-5b059c753c4145ff08c434a27ea7776a245547bc.zip
Bug 533425 - [Dark Theme] Install from local installation shows white
artifacts on Install Details page Replaced super.setBackgroundGdkRGBA call on fixedHandle (SwtFixed container) with call on handle (GtkFrame) in Group#setBackgroundGdkRGBA for GTK3.18 and above, as the background color for GtkFrame overrides the background color of SwtFixed parent. Tested with ControlExample and Install Details page on GTK3.22 and 3.16. Change-Id: I753b5959ff04914e2f6437e2847f55d30095a5fc Signed-off-by: Xi Yan <xixiyan@redhat.com>
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java
index bfdac3fd6b..88fd409498 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java
@@ -336,7 +336,11 @@ void releaseWidget () {
@Override
void setBackgroundGdkRGBA(long /*int*/ handle, GdkRGBA rgba) {
assert GTK.GTK3 : "GTK3 code was run by GTK2";
- super.setBackgroundGdkRGBA(fixedHandle, rgba);
+ if (GTK.GTK_VERSION >= OS.VERSION(3, 18, 0)) {
+ super.setBackgroundGdkRGBA(handle, rgba);
+ } else {
+ super.setBackgroundGdkRGBA(fixedHandle, rgba);
+ }
}
@Override

Back to the top