diff options
| author | Simeon Andreev | 2021-05-12 11:56:22 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2021-05-13 21:39:22 +0000 |
| commit | 05a40dc974db437e964645be77b5380e9fd3ed2e (patch) | |
| tree | 635edbebb941eeddd03628267a8bc34ceb7c6bce | |
| parent | c677ee7c1e621b2f7a94f4c304614ac4f3f4b413 (diff) | |
| download | eclipse.platform.swt-05a40dc974db437e964645be77b5380e9fd3ed2e.tar.gz eclipse.platform.swt-05a40dc974db437e964645be77b5380e9fd3ed2e.tar.xz eclipse.platform.swt-05a40dc974db437e964645be77b5380e9fd3ed2e.zip | |
Bug 573473 - [GTK3] ImageLoader.getImageFormat(long) leaks native memory
This change adds the missing OS.g_free() call to
ImageLoader.getImageFormat(), in order to free memory allocated with
GDK.gdk_pixbuf_format_get_name(). This prevents a native memory leak.
Change-Id: I3ff6ae1a6bfe63ea4ac6d3f092ed134d669d3201
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180519
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
| -rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/ImageLoader.java | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/ImageLoader.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/ImageLoader.java index 2731c70b04..ec5d50b551 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/ImageLoader.java +++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/ImageLoader.java @@ -338,6 +338,7 @@ int getImageFormat(long loader) { long format = GDK.gdk_pixbuf_loader_get_format(loader); long name = GDK.gdk_pixbuf_format_get_name(format); String nameStr = Converter.cCharPtrToJavaString(name, false); + OS.g_free(name); switch (nameStr) { case "bmp": return SWT.IMAGE_BMP; case "gif": return SWT.IMAGE_GIF; |