diff options
| author | Lars Vogel | 2021-04-01 10:04:13 +0000 |
|---|---|---|
| committer | Lars Vogel | 2021-04-01 15:14:53 +0000 |
| commit | a0deba5589512e1f23ce6b1cbc3f4f0de5cbc702 (patch) | |
| tree | b7670fa915df466e78d7ebc698d02c04f7c2824b | |
| parent | e38406a86a8ef93ed3b8e10edfb5ff2ec21db8eb (diff) | |
| download | eclipse.platform.swt-a0deba5589512e1f23ce6b1cbc3f4f0de5cbc702.tar.gz eclipse.platform.swt-a0deba5589512e1f23ce6b1cbc3f4f0de5cbc702.tar.xz eclipse.platform.swt-a0deba5589512e1f23ce6b1cbc3f4f0de5cbc702.zip | |
[dogfooding][cleanup] Use static inner class clean up
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I327a15070d72ff10f050b07ac2f67fb87193272f
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
3 files changed, 3 insertions, 3 deletions
diff --git a/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/addressbook/AddressBook.java b/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/addressbook/AddressBook.java index cd5bc3689c..e9806dc0bb 100644 --- a/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/addressbook/AddressBook.java +++ b/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/addressbook/AddressBook.java @@ -769,7 +769,7 @@ private void createHelpMenu(Menu menuBar) { /** * To compare entries (rows) by the given column */ -private class RowComparator implements Comparator<String[]> { +private static class RowComparator implements Comparator<String[]> { private int column; /** diff --git a/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/javaviewer/JavaLineStyler.java b/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/javaviewer/JavaLineStyler.java index 49adf36e57..7db7bce8c4 100644 --- a/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/javaviewer/JavaLineStyler.java +++ b/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/javaviewer/JavaLineStyler.java @@ -209,7 +209,7 @@ public void parseBlockComments(String text) { /** * A simple fuzzy scanner for Java */ -public class JavaScanner { +public static class JavaScanner { protected Map<String, Integer> fgKeys= null; protected StringBuilder fBuffer= new StringBuilder(); diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledTextContent.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledTextContent.java index 7d9bc26f87..6a7b19551c 100644 --- a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledTextContent.java +++ b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledTextContent.java @@ -34,7 +34,7 @@ import org.junit.Test; public class Test_org_eclipse_swt_custom_StyledTextContent { int XINSET = 0; - class ContentImplementation implements StyledTextContent { + static class ContentImplementation implements StyledTextContent { String textContent = ""; @Override |