diff options
| author | Lars Vogel | 2021-04-09 05:52:34 +0000 |
|---|---|---|
| committer | Lars Vogel | 2021-04-09 09:54:48 +0000 |
| commit | fa96c9c4fc62c2ed4a5c8e726a6630ff62268bed (patch) | |
| tree | d3e8c2ac3199630d33634f926fe43430c387373c | |
| parent | 40820589ba3d81572f9a0589a4fe2e5876c55acc (diff) | |
| download | eclipse.platform.runtime-fa96c9c4fc62c2ed4a5c8e726a6630ff62268bed.tar.gz eclipse.platform.runtime-fa96c9c4fc62c2ed4a5c8e726a6630ff62268bed.tar.xz eclipse.platform.runtime-fa96c9c4fc62c2ed4a5c8e726a6630ff62268bed.zip | |
[dogfooding][cleanup] Use static inner class clean up for
core.tools
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I64addfd5de09074b5999cbb15a70209be053d266
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
3 files changed, 4 insertions, 4 deletions
diff --git a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java index 0ad0ae62f..f48f665a6 100644 --- a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java +++ b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java @@ -94,7 +94,7 @@ public class EclipsePreferencesView extends ViewPart { } } - class ViewLabelProvider extends LabelProvider { + static class ViewLabelProvider extends LabelProvider { @Override public String getText(Object obj) { diff --git a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java index 3fa664b2d..e03d6f89e 100644 --- a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java +++ b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java @@ -48,7 +48,7 @@ import org.eclipse.ui.IActionBars; */ public class EventsView extends TableWithTotalView { - class EventsViewContentProvider implements ITreeContentProvider { + static class EventsViewContentProvider implements ITreeContentProvider { @Override public void dispose() { // do nothing @@ -83,7 +83,7 @@ public class EventsView extends TableWithTotalView { /** * Class to display the labels for the stats view table. */ - class EventsViewLabelProvider extends LabelProvider implements ITableLabelProvider, IColorProvider { + static class EventsViewLabelProvider extends LabelProvider implements ITableLabelProvider, IColorProvider { @Override public Image getColumnImage(Object arg0, int arg1) { diff --git a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java index 1e9628538..92e6b85c2 100644 --- a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java +++ b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java @@ -36,7 +36,7 @@ public class PluginListView extends SpyView implements IStructuredContentProvide /** * Class which provides the text labels for the view. */ - class PluginListLabelProvider extends LabelProvider implements ITableLabelProvider { + static class PluginListLabelProvider extends LabelProvider implements ITableLabelProvider { @Override public Image getColumnImage(Object arg0, int arg1) { return null; |