diff options
| author | jkubitz | 2021-02-12 21:13:23 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2021-02-15 09:34:51 +0000 |
| commit | 434556bcae52a8bc1d9476d2574cc65821f22841 (patch) | |
| tree | 75f4debfc67251b52da9860d8974b88e05cbd509 | |
| parent | 48efb84b8e776b4b8c52433d2f53c6e5b765142a (diff) | |
| download | eclipse.platform.resources-R4_19_maintenance.tar.gz eclipse.platform.resources-R4_19_maintenance.tar.xz eclipse.platform.resources-R4_19_maintenance.zip | |
Bug 571174 - [performance] improve getLineSeperator()Y20210316-1310Y20210316-0510Y20210315-1000Y20210314-1000Y20210313-1000Y20210312-2250Y20210312-1250Y20210312-1000Y20210311-1000Y20210310-1000Y20210309-1000Y20210307-1000Y20210306-1000Y20210305-1000Y20210304-1000Y20210303-1000Y20210301-1000Y20210228-1000Y20210227-1000Y20210226-1000Y20210225-1000Y20210224-1000Y20210223-1050Y20210222-1000Y20210221-1000Y20210220-1000Y20210219-1000Y20210218-1000Y20210217-1000Y20210216-1000Y20210215-1020S4_19_0_RC2S4_19_0_RC1S4_19_0_M3R4_19I20210303-1800I20210303-0600I20210302-1800I20210302-0930I20210302-0720I20210302-0600I20210301-1800I20210301-0600I20210228-1800I20210228-0600I20210227-1800I20210227-0600I20210226-2140I20210226-1800I20210226-0220I20210224-1800I20210224-0840I20210224-0600I20210223-1800I20210223-0650I20210223-0600I20210222-1800I20210222-0600I20210221-1800I20210221-0600I20210220-1800I20210220-0600I20210219-1800I20210219-0300I20210217-1800I20210217-0600I20210216-2020I20210216-1800I20210216-1340I20210216-1140I20210216-1030I20210216-0600I20210215-1800I20210215-0700I20210215-0600R4_19_maintenance
Old implementation did read files byte by byte.
This is a hot spot in junit test of JDT.
Bug: 571174
Change-Id: Ib08f643c38c51e01c5838743190ca54f591545b1
Signed-off-by: jkubitz <jkubitz-eclipse@gmx.de>
| -rw-r--r-- | bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/utils/FileUtil.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/utils/FileUtil.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/utils/FileUtil.java index bf506e448..9b3d44b0e 100644 --- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/utils/FileUtil.java +++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/utils/FileUtil.java @@ -287,7 +287,9 @@ public class FileUtil { public static String getLineSeparator(IFile file) { if (file.exists()) { try ( - InputStream input = file.getContents() + // for performance reasons the buffer size should + // reflect the average length of the first Line: + InputStream input = new BufferedInputStream(file.getContents(), 128); ) { int c = input.read(); while (c != -1 && c != '\r' && c != '\n') |