From f910c3ed244a50e60cae4d8e3df92a3359a52544 Mon Sep 17 00:00:00 2001
From: jszursze
Date: Fri, 2 Nov 2001 20:41:08 +0000
Subject: code review

---
 .../eclipse/debug/core/model/ILauncherDelegate.java  | 20 ++++++++++----------
 .../core/org/eclipse/debug/core/model/IProcess.java  | 16 ++++++++--------
 .../org/eclipse/debug/core/model/ISourceLocator.java |  2 +-
 .../core/org/eclipse/debug/core/model/package.html   |  4 ++--
 4 files changed, 21 insertions(+), 21 deletions(-)

(limited to 'org.eclipse.debug.core')

diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ILauncherDelegate.java b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ILauncherDelegate.java
index e3314efdb..9a0017cac 100644
--- a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ILauncherDelegate.java
+++ b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ILauncherDelegate.java
@@ -23,7 +23,7 @@ import org.eclipse.debug.core.ILauncher;
  * <extension point="org.eclipse.debug.core.launchers">
  *   <launcher 
  *      id="com.example.ExampleIdentifier"
- *      class="com.example.ExmapleLauncher"
+ *      class="com.example.ExampleLauncher"
  *      modes="run, debug"
  *      label="Example Launcher"
  *      wizard="com.example.ExampleLaunchWizard"
@@ -64,17 +64,17 @@ import org.eclipse.debug.core.ILauncher;
  */
 public interface ILauncherDelegate {
 	/**
-	 * Notifies this launcher delegate to launch in the given mode,
-	 * register the resulting launch with  the launch manager.
+	 * Notifies this launcher delegate to launch in the given mode, and
+	 * registers the resulting launch with  the launch manager.
 	 * Returns <code>true</code> if successful, otherwise <code>false</code>.
 	 * This typically results in the creation of one or more processes and/or
-	 * a debug target. The collection of elements provides context for 
+	 * a debug target. The collection of elements provides context for the 
 	 * launch. The determination of which or how many objects to launch
 	 * is launcher dependent. This method blocks until the launch is
 	 * complete. The given launcher is the owner of this delegate.
 	 * <p>
 	 * For example, when the debug UI invokes a launcher, the
-	 * collection of elements passed in represent the selected elements
+	 * collection of elements passed in could represent the selected elements
 	 * in the UI, and the mode specified will be run or debug (depending on
 	 * which launch button was pressed). A launcher will generally examine the 
 	 * element collection to determine what to launch. For example, if the
@@ -103,7 +103,7 @@ public interface ILauncherDelegate {
 	 * @see IProcess
 	 * @see org.eclipse.debug.core.ILaunchManager#registerLaunch
 	 */
-	boolean launch(Object[] elements, String mode, ILauncher launcher);
+	public boolean launch(Object[] elements, String mode, ILauncher launcher);
 	
 	/**
 	 * Returns a memento for an object that this delegate has launched, such
@@ -115,9 +115,9 @@ public interface ILauncherDelegate {
 	 *		or <code>null</code> if unable to create a memento for
 	 * 		the element
 	 * 
-	 * @see #getObject
+	 * @see #getLaunchObject
 	 */
-	String getLaunchMemento(Object element);
+	public String getLaunchMemento(Object element);
 	
 	/**
 	 * Returns the object represented by the given memento, or <code>null</code>
@@ -127,9 +127,9 @@ public interface ILauncherDelegate {
 	 * @param memento a memento created by this delegate
 	 * @return the object represented by the memento, or <code>null</code>
 	 * 
-	 * @see #getMemento
+	 * @see #getLaunchMemento
 	 */
-	Object getLaunchObject(String memento);
+	public Object getLaunchObject(String memento);
 }
 
 
diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/IProcess.java b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/IProcess.java
index ca185d5ef..f0a7bcb7a 100644
--- a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/IProcess.java
+++ b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/IProcess.java
@@ -32,25 +32,25 @@ public interface IProcess extends IAdaptable, ITerminate {
 	/**
 	 * Returns a human-readable label for this process.
 	 *
-	 * @return a label
+	 * @return a label for this process
 	 */
-	String getLabel();
+	public String getLabel();
 	/**
-	 * Returns the <code>ILaunch</code> this element originated from, or
+	 * Returns the launch this element originated from, or
 	 * <code>null</code> if this element has not yet been registered with
-	 * an <code>ILaunch</code>. This is a convenience method for
+	 * an launch. This is a convenience method for
 	 * <code>ILaunchManager.findLaunch(IProcess)</code>.
 	 *
 	 * @return the launch this process is contained in
 	 */
-	ILaunch getLaunch();
+	public ILaunch getLaunch();
 	/**
 	 * Returns a proxy to the standard input, output, and error streams 
 	 * for this process, or <code>null</code> if not supported.
 	 *
 	 * @return a streams proxy, or <code>null</code> if not supported
 	 */
-	IStreamsProxy getStreamsProxy();
+	public IStreamsProxy getStreamsProxy();
 	
 	/**
 	 * Sets the value of a client defined attribute.
@@ -58,7 +58,7 @@ public interface IProcess extends IAdaptable, ITerminate {
 	 * @param key the attribute key
 	 * @param value the attribute value
 	 */
-	void setAttribute(String key, String value);
+	public void setAttribute(String key, String value);
 	
 	/**
 	 * Returns the value of a client defined attribute.
@@ -66,7 +66,7 @@ public interface IProcess extends IAdaptable, ITerminate {
 	 * @param key the attribute key
 	 * @return value the attribute value, or <code>null</code> if undefined
 	 */
-	String getAttribute(String key);
+	public String getAttribute(String key);
 
 }
 
diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ISourceLocator.java b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ISourceLocator.java
index 0d63e4397..7a69c7ff8 100644
--- a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ISourceLocator.java
+++ b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/ISourceLocator.java
@@ -60,7 +60,7 @@ public interface ISourceLocator {
 	 * @param stackFrame the stack frame for which to locate source
 	 * @return an object representing a source element. 
 	 */
-	 Object getSourceElement(IStackFrame stackFrame);
+	 public Object getSourceElement(IStackFrame stackFrame);
 
 }
 
diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/package.html b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/package.html
index 4b091a06d..acc92a873 100644
--- a/org.eclipse.debug.core/core/org/eclipse/debug/core/model/package.html
+++ b/org.eclipse.debug.core/core/org/eclipse/debug/core/model/package.html
@@ -3,7 +3,7 @@
 
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
-<title>Eclipse Debug Tools</title>
+<title>Eclipse Debug Tools [org.eclipse.debug.core.model]</title>
 </head>
 
 <body bgcolor="#FFFFFF">
@@ -51,7 +51,7 @@ provides:
 <ul>
   <li>an image for a debug element or breakpoint</li>
   <li>a label for a debug element or breakpoint</li>
-  <li>an editor input that should be used to display the debug element or breakpoint</li>
+  <li>an editor input that should be used to display a debug element or breakpoint</li>
 </ul>
 </body>
 </html>
-- 
cgit v1.2.3