From c6c26556ce089a928449f9e1b0e62255d6994afb Mon Sep 17 00:00:00 2001
From: Jared Burns
Date: Thu, 1 May 2003 20:06:41 +0000
Subject: Bug 36930 - Support variables in launch configurations

---
 org.eclipse.debug.ui/plugin.xml                               |  2 +-
 .../debug/ui/variables/ExternalToolVariableRegistry.java      | 11 ++++++++---
 .../ui/org/eclipse/debug/ui/variables/IVariableConstants.java |  2 +-
 .../internal/variables/RefreshScopeVariableRegistry.java      |  2 +-
 4 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/org.eclipse.debug.ui/plugin.xml b/org.eclipse.debug.ui/plugin.xml
index 0e85a9427..dd5eb3f02 100644
--- a/org.eclipse.debug.ui/plugin.xml
+++ b/org.eclipse.debug.ui/plugin.xml
@@ -32,7 +32,7 @@
    <extension-point id="launchConfigurationTypeImages" name="%LaunchConfigurationTypeImageExtensionName" schema="schema/launchConfigurationTypeImages.exsd"/>
    <extension-point id="launchGroups" name="%LaunchGroupsExtensionName" schema="schema/launchGroups.exsd"/>
    <extension-point id="launchShortcuts" name="%LaunchShortcutsName" schema="schema/launchShortcuts.exsd"/>
-	<extension-point id="launchConfigurationVariables" name="%LaunchConfigurationVariablesName"/>
+   <extension-point id="launchConfigurationVariables" name="%LaunchConfigurationVariablesName"/>
 	
 <!-- Extensions -->
    <extension
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/ExternalToolVariableRegistry.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/ExternalToolVariableRegistry.java
index a3de699ca..c36b82867 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/ExternalToolVariableRegistry.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/ExternalToolVariableRegistry.java
@@ -58,15 +58,20 @@ public class ExternalToolVariableRegistry {
 	 * The extension point id to read the variables from
 	 */
 	protected String extensionPointId;
+	/**
+	 * The plugin id to read the extension point from
+	 */
+	protected String pluginId;
 	
 	public ExternalToolVariableRegistry() {
-		this(IVariableConstants.EXTENSION_POINT_TOOL_VARIABLES);
+		this(DebugUIPlugin.getUniqueIdentifier(), IVariableConstants.EXTENSION_POINT_TOOL_VARIABLES);
 	}
 	
 	/**
 	 * Creates a new registry and loads the variables.
 	 */
-	protected ExternalToolVariableRegistry(String extensionPointId) {
+	protected ExternalToolVariableRegistry(String pluginId, String extensionPointId) {
+		this.pluginId= pluginId;
 		this.extensionPointId = extensionPointId;
 		loadVariables();
 	}
@@ -109,7 +114,7 @@ public class ExternalToolVariableRegistry {
 	private void loadVariables() {
 		variables = new TreeMap();
 		IPluginRegistry registry = Platform.getPluginRegistry();
-		IExtensionPoint point = registry.getExtensionPoint(DebugUIPlugin.getUniqueIdentifier(), extensionPointId);
+		IExtensionPoint point = registry.getExtensionPoint(pluginId, extensionPointId);
 		if (point != null) {
 			IExtension[] extensions = point.getExtensions();
 			for (int i = 0; i < extensions.length; i++) {
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/IVariableConstants.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/IVariableConstants.java
index b332b0bc4..311422585 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/IVariableConstants.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/variables/IVariableConstants.java
@@ -100,6 +100,6 @@ public interface IVariableConstants {
 	 * Extension point to declare external tool variables. 
 	 * (value<code>toolVariables</code>).
 	 */
-	public static final String EXTENSION_POINT_TOOL_VARIABLES = "toolVariables"; //$NON-NLS-1$
+	public static final String EXTENSION_POINT_TOOL_VARIABLES = "launchConfigurationVariables"; //$NON-NLS-1$
 	
 }
\ No newline at end of file
diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/RefreshScopeVariableRegistry.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/RefreshScopeVariableRegistry.java
index 5d297c8a9..bdd6e44c3 100644
--- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/RefreshScopeVariableRegistry.java	
+++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/RefreshScopeVariableRegistry.java	
@@ -22,7 +22,7 @@ public class RefreshScopeVariableRegistry extends ExternalToolVariableRegistry {
 	 * Creates the registry and loads the variables.
 	 */
 	public RefreshScopeVariableRegistry() {
-		super(IExternalToolConstants.EXTENSION_POINT_REFRESH_VARIABLES);
+		super(IExternalToolConstants.PLUGIN_ID, IExternalToolConstants.EXTENSION_POINT_REFRESH_VARIABLES);
 	}
 	
 }
-- 
cgit v1.2.3