Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-06-30Bug 306131 - [console] Null byte to stdout results in truncation of lineY20200703-0300Y20200701-1200Y20200701-0020I20200702-2150I20200702-1800I20200701-2350I20200701-2210I20200701-1800I20200701-0330I20200630-1800Paul Pazderski1-2/+10
If interpretation of ASCII control characters is enabled handle null bytes (\0) by simply filtering them out. This is useful because null bytes can truncate console lines on some platforms and brings unexpected results on copy text on most platforms. Change-Id: Ic6a46c3eba4582c8f54fcd6735b8763738d47623 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-27Bug 558463 - [console] Console redirection changes contentY20200629-1000Y20200629-0740I20200629-1800I20200628-1800Paul Pazderski4-91/+12
Unfortunately all the existing streams monitoring/proxying/redirection or basically most of the console IO stack is based upon strings. If a program produce 'random' binary output and user configures console to redirect the output to a file it might still be changed due to the (until now) unavoidable string decoding. Keeping existing API and not breaking clients made this change in some parts more complex than it could be. Change-Id: Id8e8fa1f777f06220af86dd4f026873c6b0b2d7b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-12[Bug 550832] Remove gif which we left during the move to png filesLars Vogel2-0/+0
Change-Id: I8db69f1c50f69934e1946e7900c6d6d34b8d2375 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-11Use lambdas and method references in ui.consoleLars Vogel1-1/+1
JDT cleanup batch cleanup Change-Id: I6a6af8501d362dd5e425c782bce2c378601c3350
2020-06-114.17 update of org.eclipse.ui.consoleI20200611-1800Lars Vogel2-2/+2
For https://git.eclipse.org/r/164734 Change-Id: Ic0af7c457ebf3b9d90ca0decc07fcd8dd2d318e8
2020-06-04Bug 563840 - POM and product version change for 4.17 releaseI20200606-1800I20200606-0940I20200606-0910I20200606-0700I20200606-0400I20200606-0050I20200605-2140I20200605-1500I20200605-1230I20200605-1200I20200605-1150I20200605-0950I20200605-0910I20200605-0720Sravan Kumar Lakkimsetti1-1/+1
Change-Id: I1bfac7ee8f58d204e62028bbac0cd7e25051520d Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2020-05-11Bug 563041 - NPE in IOConsolePartitioner output appendingI20200511-1800Paul Pazderski1-3/+7
Unlikely but possible that after output appending job is started but before entering the synchronized block a partitioner disconnect happens and 'nulls' the document. Change-Id: I8be692b7f7374dfe8234e22571c1561f63e07c80 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-04-10Bug 561919 - Remove com.ibm.icu.text from org.eclipse.ui.consoleLars Vogel3-3/+3
Change-Id: I0e5237a881efd90c67947ba56853a07c421de081 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-04-10Bump version for 4.16Alexander Kurtakov2-2/+2
Needed for https://git.eclipse.org/r/#/c/160657/ Change-Id: Ic0cf7bd36e359aea4bf0fd071ff5b85801e5bf2a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-03-06Bug 560872 - POM and product version change for 4.16 releaseY20200309-1300Y20200308-0700Y20200308-0520X20200313-0410X20200312-1900X20200312-1530X20200312-1210X20200312-0700X20200311-2150X20200311-1900X20200311-0820X20200306-1900I20200313-1800I20200313-0810I20200312-1835I20200312-1800I20200311-1800I20200310-1800I20200310-0810I20200309-1800I20200309-0810I20200308-1800I20200307-1800I20200307-1145Mat Booth1-1/+1
Change-Id: Ifcb7805f8c4c779f434dc85604d0b8c24ad08890 Signed-off-by: Mat Booth <mat.booth@redhat.com>
2020-02-15Bug 345435 - [console] EOF Ctrl+Z keybinding doesn't work with twoPaul Pazderski1-10/+17
consoles up Change-Id: I1e45eb5450887c9107e1cb46b3f3894e5443d85c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-11Clean-up use lambdas and method references in ui.consoleI20200212-1420Lars Vogel3-49/+24
Using the JDT cleanup action -> - Use lambda where possible - Simplify lambda expression and method reference syntax Change-Id: Icdce7db08c100cf4eda0e9ebabf20afbe64ba36f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-22Bug 553282 - [console] Handle \f and \v in console outputY20200130-0045Y20200127-1055Y20200126-2245I20200201-1800I20200131-1800I20200130-1800I20200129-1800I20200129-0935I20200129-0100I20200128-1805I20200127-1800I20200126-1800I20200126-0250I20200125-1805I20200124-1800I20200123-1800I20200123-0525I20200123-0430I20200122-1805Paul Pazderski1-5/+27
Change-Id: I8c86ad1116aa12c59ec4cbfbf2662e484c55c1c4 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-22Bug 553282 - Extract code to partition newly appended outputPaul Pazderski1-276/+309
This change is pure refactoring to simplify the diff of the actual enhancement from bug 553282. Change-Id: I36d531e9c2872b68608b8b54343220a558e4f5e7 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-17Bug 365770 - Race condition in IOConsolePartitioner causes consoleY20200120-0020I20200120-0530I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800Paul Pazderski1-46/+67
output to be lost or not cleared Due to the race condition when calling outStream.print("First"); console.clearConsole(); outStream.print("Second"); from a single thread the actual console content could be "FirstSecond" or "" where only "Second" is correct. Change-Id: Ifeaed46e11652c53297c1aac3ff4fa1dd07e401b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-17Bug 229202 - [console] Open link in console context menu gets disabledPaul Pazderski2-11/+9
when activating Consequence was that context menu showed an active menu entry to open link but nothing was opened/executed. Change-Id: Ia2db5fe2caf3f7de9735e99732c691ba9c163e85
2020-01-14Bug 421303 - Potential deadlock in IOConsolePartitioner.streamAppendedPaul Pazderski1-3/+7
The deadlock requires that a separate thread is write large amounts of content rapidly to console and while doing this holds lock(s) with UI thread may require. An example is that both (UI and non-UI thread) write to console using the same IOConsoleOutputStream and therefore sharing the streams write lock. Change-Id: I5c72b60e765ec550928ba872f089494593475856 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-11Bug 559070 - Fix resource related compiler warnings in platform.debugPaul Pazderski2-3/+24
Change-Id: If9102e5fcd24e7888596fd33a14ed5529419acc2 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-06Remove trailing whitespace in debug repoY20200108-0435I20200108-2240I20200108-0600I20200108-0025I20200107-1800I20200107-0600I20200106-1805Lars Vogel8-11/+11
Change-Id: I845c923a09e0458fff1d960469da08404547de7f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-03Bug 558772 - [console] Remove obsolete code in IOConsolePartitionerI20200106-0600Paul Pazderski1-30/+1
The method applyStreamOutput can do the same as the removed code block. Change-Id: I090b45de41bae48376f87e0e5e67a2ff058df592 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-11Bug 553753 - [console] Provide stacktrace if partitioner stream closedI20191216-1805I20191215-1800I20191214-1800I20191213-1805Paul Pazderski1-1/+6
is called twice Change-Id: I7ce2f14e1dc14328d9bfdf7e7c126f47c5674ded Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-11Bug 553770 - Error when closing output stream of disposed MessageConsoleI20191213-0155I20191212-1800I20191211-1805Simeon Andreev2-4/+15
The fix for bug 551745 adds logging, in case an IOConsole stream is closed after all streams of the console are considered closed (e.g. on dispose()). For a MessageConsole, its possible to create a new MessageConsoleStream and close it after the MessageConsole is disposed. This will produce the new error log entry. This change adds any MessageConsoleStream created by MessageConsole.newMessageStream() to IOConsole.openStream, so that the streams created by MessageConsole are also correctly handled by IOConsole. Change-Id: I09156248fac6b6f63daab88b8881a197e7fe83fb Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2019-12-114.15 version update for org.eclipse.ui.consoleKarsten Thoms2-2/+2
Required for https://git.eclipse.org/r/#/c/153801/ Change-Id: I81a174b9401d1d1d1b8e9208522fda5824c3055a Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-06Bug 553742 - POM and product version change for 4.15 releaseY20191208-2315I20191210-0230I20191209-2205I20191209-1600I20191209-1310I20191209-1130I20191209-1110Niraj Modi1-1/+1
Change-Id: Idaef2793bf1fa8aece6a02b2136b1fd09d344d73 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-11-26Bug 553461 - NPE in TextConsoleViewer.lineGetStyleY20191127-0140S4_14_0_RC2aS4_14_0_RC2S4_14_0_RC1R4_14I20191210-0610I20191204-1800I20191204-0600I20191203-1800I20191203-0600I20191202-1800I20191202-0600I20191201-1800I20191201-0600I20191130-1800I20191130-0600I20191129-1800I20191127-1800I20191127-0600I20191126-2315I20191126-1800Paul Pazderski3-4/+13
Change-Id: If5bc348ffc127ac097b34e25a6a835e9891c11ee Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-16Bug 76936 - [console] Handle \b and \r in console outputY20191126-0500I20191126-0600I20191125-1800I20191125-0600I20191124-1800I20191124-0600I20191123-1800I20191123-1115I20191123-0600I20191123-0100I20191122-1800I20191120-2335I20191120-1800I20191120-0840I20191120-0600I20191119-2200I20191119-1800I20191119-1250I20191119-1235I20191119-1215I20191119-1155I20191119-0850I20191119-0725I20191119-0510I20191119-0315I20191119-0020I20191118-2230I20191118-1800Paul Pazderski2-14/+474
Change-Id: Ia5e5b2760a0a9a097c003c41e3229e149003f22b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-16Bug 551745 - [console] Revise IOConsolePartitioner output appending andI20191118-0600Paul Pazderski3-242/+313
initialization Remove, rename or rework some fields and simplify how stream output is appended to document. (without losing existing functionality) Second try. This time with deadlock protection. Change-Id: I8d80ade8bb521895c97d6e08d2f520dd9b182a3b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-14Use jdk 5 for-each loopI20191114-1800chammer1-3/+1
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I87544aca0942d3b3a9ea40f9994f1a12c75a4f9e Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-11-12Bug 552014 - [console] Input problem with fixed width console and IMEI20191112-1800Paul Pazderski1-39/+69
When IME is started at end of fixed width line the first stroke is immediately inserted as character and the IME continued after. Change-Id: I9a197f49b9b9aae8c279fe5638fa5278d66294c8 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-12Bug 551935 - Replace usage of deprecated TextUtilities.indexOf with newPaul Pazderski2-21/+27
MultiStringMatcher Change-Id: I6ca1bae81e71f12c16e006887c4932c084eb970c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-10-14Use jdk 5 for-each loop (Part 1)Carsten Hammer8-38/+23
Replace simple uses of Iterator with a corresponding for-each loop. Also add missing braces on loops as necessary. Change-Id: I6c75e02ff88e29f6007356616dc098f6a1164a64 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-10-08Revert "Bug 551745 - [console] Revise IOConsolePartitioner outputS4_14_0_M1I20191009-1800I20191009-0600I20191009-0300I20191008-1800I20191008-0600Paul Pazderski1-197/+157
appending" This reverts commit 3c90473857dcadda2fd762c8ee9b735b37f46874. Change introduced or revealed some nasty synchronization problem in console closing. Change-Id: I3b637aa88b8a8d6c7093a1d88d02a2248bce9354 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-10-03Bug 551745 - [console] Revise IOConsolePartitioner output appendingI20191007-0430I20191006-1800I20191006-0600Paul Pazderski1-157/+197
Remove, rename or rework some fields and simplify how stream output is appended to document. (without losing existing functionality) Change-Id: Idcc1a705f92e46ba623a3187b0e4b3a323a93fa8 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-10-01Bug 550621 - [console] Improve input handling in IOConsoleI20191003-1800I20191002-1800I20191002-0100I20191001-1800Alexander Kurtakov1-1/+1
Fix javadoc error. UL tag can not be nested in P. Change-Id: I913cdb4f085f2fb07b649876c92058474aeda50b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-09-26Bug 550621 - [console] Improved user input handling in IOConsole.I20190930-1800I20190929-1800I20190928-1800I20190928-0515I20190928-0205I20190928-0000I20190927-1800I20190927-1530I20190927-0255I20190927-0225I20190927-0145I20190926-1800I20190926-0625Paul Pazderski2-70/+109
Improvements: - if user tries to override/delete writable and read-only parts only the writable parts are removed - if user types in read-only part it is appended at the next possible writable part - if user types at border of writable part this writable part is better reused - if user paste content with multiple lines this his handled more consistent with behavior when user is typing multiple lines Change-Id: I47e4ee7493170d3537734325f0362fd6a8d7a16c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-24Bug 550586 - Fix files that have ended up with CRLF in the gitI20190924-1800Ed Merks3-325/+325
repository Update version for 4.14 stream for - org.eclipse.core.variables - org.eclipse.core.externaltools Change-Id: I2c5ec65909a0078024fa8579408c2caf04a6671c Signed-off-by: Ed Merks <ed.merks@gmail.com> Also-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-09-19Bug 550621 - [console] Add IConsoleDocumentPartitionerExtensionPaul Pazderski3-4/+234
Used to better test for read-only parts of console document. Change-Id: I1d8e3b2655080a8b435e8aaf296c40823239cc93 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-18Bug 551109 - [4.14] API error in org.eclipse.ui.consoleI20190923-0615I20190922-1800I20190921-1800I20190920-1800I20190919-1800I20190919-0850I20190918-1800Andrey Loskutov2-2/+2
Incremented minor version segment due API changes via bug 547683: TextConsoleViewer extends SourceViewer which extends TextViewer which got new org.eclipse.jface.text.ITextViewerExtension9 interface added. Change-Id: Iafbe1ff32f7ed061ee4283926d9d995988e454c9 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-09-16Remove unnecessary type specificationsCarsten Hammer1-1/+1
Since Java 7 the diamond operator can be used instead of explicit type parameters. Version bumps for 4.14 Change-Id: I15a2ec4f20428b1fdecc6a7e11dae5e1966b21e6 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-09-15Bug 550618 - [console] IOConsolePartitioner produces overlapping styleI20190915-1800Paul Pazderski1-3/+16
ranges Old implementation adjusted range start but did not touch the ranges length resulting in invalid overlapping ranges. Change-Id: Ie6cf1289a62a4d63f46b682b67bc72cd2d223bd2 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-12Bug 550620, 197958 - Fix style range override in TextConsoleViewerPaul Pazderski4-48/+87
Current implementation of override works most of the time since the usual combinations of existing style ranges and link range are quite limited. New implementation yields correct results for any combination. This also supersedes fix of Bug 111256. Change-Id: Idcc94f4be0d7ca815e854a2d2a271a32494a2412 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-06Bug 550767 - POM and product version change for 4.14 releaseI20190910-0815I20190910-0145I20190909-1520I20190909-1425I20190909-0925Niraj Modi1-1/+1
Change-Id: I29e9b6d5e32511c3ebca7d7042871fd20c0bc3f0 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-08-15Bug 548250 - [javadoc] Fix 'Missing tag for parameter' warningsY20190822-0900Y20190819-0900S4_13_0_M3I20190823-0840I20190823-0530I20190821-1800I20190821-0600I20190820-1800I20190820-0855I20190820-0600I20190819-2355I20190819-0600I20190818-1800I20190817-1800I20190816-1800Paul Pazderski9-30/+75
Change-Id: I6dc01c6b296d3d93648012cbbca0175100d75fcb Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-07-25Bug 549140 - org.eclipse.ui.console.consoleFactories extension pointY20190808-0900Y20190805-0900Y20190801-0900Y20190730-0135Y20190730-0055Y20190729-0900Y20190725-0900I20190811-1800I20190810-1800I20190809-1800I20190808-1800I20190807-1800I20190806-1800I20190805-1800I20190804-1800I20190803-1800I20190802-1800I20190801-1800I20190801-0600I20190731-1800I20190730-1800I20190729-1800I20190728-1800I20190727-1800I20190726-1800I20190725-1800Lakshminarayana Nekkanti1-11/+3
should handle platform icons Change-Id: I3c51bceb0ba1ecc045b978b5f49f4cccd8cc96b5 Signed-off-by: Lakshminarayana Nekkanti <narayana.nekkanti@gmail.com>
2019-07-05Use StringBuilder in IOConsolePartitionerLars Vogel1-3/+3
Change-Id: Ie42efbe82534acbeffc5725c223df339a217642b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-02Bug 548356 - [console] Fix wrong input handling with multiline pastePaul Pazderski1-31/+44
The last input handling fix changed (unintentional) the behavior on pasting multiline input. Change-Id: Ib302ec08043b2f5aedafaec9e2d796ef82645f2f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-06-29Bug 548356 - [console] Fix input handling in IOConsoleI20190702-0930I20190702-0610I20190701-1805Paul Pazderski2-161/+340
Existing IOConsole and especially IOConsolePartitioner have various problems with user input handling e.g. if existing input surrounded by output is modified or a character composition is started inside an output partition. Change-Id: I3ea4f19553d6363e0d3cdc5280b577be57b45bd9 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-06-21Lamba optimizationLars Vogel1-1/+1
Use method references if possible Remove unnecessary brackets Change-Id: I82c219171f7b3e459d4e2f70ae916d44d25fdc11 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-18Use addAll, deleteAll instead of looping through a collectionI20190620-0130I20190619-1820I20190619-1800I20190618-1805Lars Vogel1-3/+2
Change-Id: I9c95900ed1b6e8823bb30c4ded37f214a92deffc Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17Bug 547064 - [console] Unnecessary linear search in IOConsolePartitionerI20190617-1800Paul Pazderski1-66/+102
getPartition can use binary search like computePartitioning already does. Also computePartitioning fails if no partitions available or requested range is behind known partitions. Change-Id: I54b120e91a696412bf9466f5a2f10d7bac154b0c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>

Back to the top