Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-03-20Remove useless non-javadoc see comments. (take 4)I20190329-0120I20190328-1800I20190327-1800I20190326-2305I20190326-1800I20190325-1800I20190325-0105I20190324-1800I20190323-1800I20190322-1800I20190321-1800I20190321-0435I20190321-0245Alexander Kurtakov142-1742/+57
Handled by Override annotation. Change-Id: Ic81aef130640547b3d07fd874f9da197bdbc1644 Signed-off-by: Alexander Kurtakov <>
2019-03-20Remove useless non-javadoc see comments. (take 3)I20190320-1800Alexander Kurtakov126-1577/+41
Handled by Override annotation. Change-Id: Ife58fe4576a16053087be89b91c1042efb0ab0a3 Signed-off-by: Alexander Kurtakov <>
2019-03-20Remove useless non-javadoc see comments. (take 2)Alexander Kurtakov154-2704/+381
Handled by Override annotation. Change-Id: Ia58f7defc807ae5ff37f1ef8a6617d4d8cac2a0a Signed-off-by: Alexander Kurtakov <>
2019-03-20Remove useless non-javadoc see comments.Alexander Kurtakov10-164/+8
Handled by Override annotation. Change-Id: Icd0334c0b57bb3021693117877a9af5fcda571d7 Signed-off-by: Alexander Kurtakov <>
2019-03-19Bug 545330: Problems in javadoc for platformAlexander Kurtakov3-4/+5
Fix platform.debug issues. Change-Id: I90e3cd73e3d4fa187cd2ba567a76e4749bfad8e1 Signed-off-by: Alexander Kurtakov <>
2019-03-08Bug 545094 - POM and product version change for 4.12 releaseI20190314-1800I20190312-1800I20190312-0340I20190311-1800I20190311-0410I20190309-1830I20190308-1830I20190308-1525I20190308-1055I20190308-0740Niraj Modi1-1/+1
Change-Id: Ic2a42e91bdc21b9d41a4d1036b67a71bdd433eb6 Signed-off-by: Niraj Modi <>
2019-03-01Bug 544926 - NPE inY20190320-2200Y20190319-2305Y20190316-1220Y20190313-2200Y20190313-0215Y20190308-0715Y20190307-1015Y20190306-2200S4_11_0_RC2R4_11I20190307-0500I20190306-2135I20190306-1800I20190306-0600I20190305-1800I20190305-0600I20190304-1800I20190304-0600R4_11_maintenanceSarika Sinha1-0/+3
DefaultDetailPane$DetailJob$1.runInUIThread( Change-Id: Ic67c7a9431b08fd2bb8cf7c238c3fb5a273d4117
2019-02-18Bug 543933 - Build javadocs with Java 11Y20190227-2200Y20190225-0415Y20190222-0110Y20190220-2200S4_11_0_RC1S4_11_0_M3I20190303-1800I20190303-0600I20190302-1800I20190302-0600I20190301-1800I20190301-0040I20190228-0300I20190227-1800I20190227-0600I20190226-1800I20190226-1020I20190226-0715I20190226-0600I20190225-1800I20190225-0600I20190225-0200I20190224-1800I20190224-0930I20190224-0600I20190223-1800I20190223-0600I20190222-1800I20190222-0645I20190222-0440I20190220-1800I20190220-0600I20190219-1800I20190219-0600I20190218-1800Alexander Kurtakov3-8/+13
After fixing majority of Xdoclint:html issues there are warnings even with Xdoclint:none. Change-Id: I8d4ec9e2b5bfa137526e8bee0d00a3c9fef0eddb Signed-off-by: Alexander Kurtakov <>
2019-02-18Bug 544528 - avoid deadlock after failed evaluationJulian Honnen1-6/+1
Moved fPendingValues.notifyAll() into finally block to ensure waiting threads are woken up after uncaught exceptions. Change-Id: Ia8a6c0126a6bf368c389118640edf51a7af7c6b0 Signed-off-by: Julian Honnen <>
2019-02-16Bug 543933 - Build javadocs with Java 11I20190218-0600I20190217-1800I20190217-0600I20190216-1800Alexander Kurtakov2-4/+4
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: Ia9710302e4ac410d5724ae0430ee32389132f76b Signed-off-by: Alexander Kurtakov <>
2019-02-15Bug 543933 - Build javadocs with Java 11I20190216-0600I20190215-1800Alexander Kurtakov4-34/+54
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I22598ce741b2ced850e6642575460534d7ba6309 Signed-off-by: Alexander Kurtakov <>
2019-02-14Bug 543933 - Build javadocs with Java 11I20190215-0630I20190215-0055I20190214-1800Alexander Kurtakov22-292/+353
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I99061cad4e8a9e3eb18bfc97143fa893715a58f8 Signed-off-by: Alexander Kurtakov <>
2019-02-14Remove unused api filters.Alexander Kurtakov1-8/+0
Change-Id: I2e6e9d9373faba9bd394ef4ed55fd0407064beed Signed-off-by: Alexander Kurtakov <>
2019-02-12Bug 544400 - Replace usage of StructuredViewer#getSorter()Y20190213-2200Y20190213-0305I20190213-1800Karsten Thoms2-9/+9
Replace by StructuredViewer#getComparator Change-Id: I926b8c2329519b1add153906b772f60535dd79a3 Signed-off-by: Karsten Thoms <>
2019-02-10Bug 544313 - NPE on workbench close if debug view in foregroundI20190212-1800I20190211-1800I20190210-2135I20190210-1800Andrey Loskutov1-0/+4
Change-Id: I057c371f8280482636a5ffa9f618d2afbaf4b46f Signed-off-by: Andrey Loskutov <>
2019-01-25Bug 459906 - Add the ability to copy and paste environment variablesY20190208-0505Y20190206-2200Y20190205-0115Y20190201-0030Y20190130-2200Y20190130-0010I20190209-1800I20190208-1800I20190207-1800I20190206-1800I20190205-1800I20190204-1800I20190203-1800I20190202-1800I20190201-1800I20190201-0600I20190131-1800I20190131-0130I20190130-1800I20190129-1800I20190128-1800I20190127-1800I20190126-1800I20190125-1800Jens Reimann5-8/+201
This change adds the functionality of copy & pasting environment variables out of the env-var table view to the clipboard. Change-Id: I312f6966ebbf6b261dd858b4a55b660f86ed3727 Signed-off-by: Jens Reimann <>
2019-01-25Bug 543832 - NPE in ProcessConsole.getStream()Andrey Loskutov1-6/+6
Reordered stream disposal and disconnecting of listeners, so that listener should not run on disposed streams. Change-Id: I895f580c7eaca746994bd78f31ea82c62bfddffd Signed-off-by: Andrey Loskutov <>
2019-01-22Bug 543672 - SWT Widget Disposed in variables viewY20190123-2200I20190124-1800I20190124-1235I20190124-0930I20190123-1800I20190122-1800Sarika Sinha1-2/+2
Change-Id: I90091e6fe43cebd03ef772ebff2e77007ab57f32
2019-01-22Bug 334991 - Variables view: Add history with recent expressions to theSarika Sinha3-4/+11
details pane Change-Id: I4535a2c2917cb07db5cb98a6e6bd2a4db83257b9
2018-12-20Bug 542943: Improve performance of DebuggerY20190102-2200Y20181226-2200I20190105-0810I20190104-1800I20190103-1800I20190102-1800I20190101-1800I20181231-1800I20181230-1800I20181229-1800I20181228-1800I20181227-1800I20181226-1800I20181225-1800I20181224-1800I20181223-1800I20181222-1800I20181221-1800I20181220-1800Denis Ungemach1-1/+0
The call to getViewSite().getActionsBars().updateActionBars() is not necessary because setGlobalActions() also executes this call. Change-Id: I90889af76f1997662d10fc8b90f303e05c534c5c Signed-off-by: Denis Ungemach <>
2018-12-12Bug 540243 - Bad selection when opening Debug View on breakpointY20181212-2200I20181212-1800Simeon Andreev3-9/+47
When the Debug View is not open and a breakpoint is hit, a preference dictates whether the Debug View is opened. If this preference is used, it is possible to observe a bad selection in the Debug View. E.g. a thread is selected and not a stack frame, or a stack frame and a thread are selected. The problem is seen for Java debug targets, when owned monitors are displayed in the Debug View. When the Debug View debug target element is created, DebugTargetProxy.doInstalled() is called. This will retrieve the first suspended thread and expand it, if such a thread is available. The expand delta contains also the top stack frame at which the thread is suspended. This stack frame is added to the delta with index 0. Unfortunately, owned monitors are displayed before stack frames in the list of thread children. So as soon as the children of the thread are updated for the tree view, a thread owned monitor will replace the selected stack frame. This results in an invalid selection handling, which in turn breaks the selection. This change allows classes which extend DebugTargetProxy to override computation of indices for the launch, debug target and suspended stack frame. A follow-up change in JDT debug will ensure the correct index is computed for the suspended stack frame, one which takes the thread owned monitors into account. Change-Id: Ic8ca2f06a7ea9e47c0322e5d3a62775a0c816652 Signed-off-by: Simeon Andreev <>
2018-12-07Bug 541822 - POM and product version change for 4.11 releaseI20181212-0230I20181211-1800I20181211-0230I20181210-1800I20181210-0755I20181210-0535Niraj Modi1-1/+1
Change-Id: Ic13c9d1d503e49d1e1ac30968c733b8c650b2495 Signed-off-by: Niraj Modi <>
2018-10-26Bug 540253 - Debug inactive after switching perspectivesI20181027-1800I20181026-1800Simeon Andreev2-8/+46
The fix for bug 538548 introduces a regression as follows. Switch from Java to Debug perspective, then back to Java perspective. Debug a snippet until a breakpoint is hit. Choose yes when asked whether to switch to the Debug perspective. Observe that debug controls are inactive. This is the case since LaunchView context provider no longer reacts to debug events, after switching to the Java perspective. It misses the breakpoint hit (which also triggers the Debug perspective switch-to confirmation dialog). This change removes the fix for bug 538548 and adds a local fix to SourceLookupService. The added fix prevents an editor popping up in the current perspective under the following conditions: 1. If the Debug View was not open in the current perspective. 2. Preferences to switch to a debug perspective on a breakpoint hit or on launch are set to "never". 3. Preference to activate the Debug View on a breakpoint hit is set to "disabled". Change-Id: Iab575ee2f9a292c23c47c95d23afadc49b8b2dff Signed-off-by: Simeon Andreev <> Signed-off-by: Andrey Loskutov <>
2018-10-18Bug 540259 - NPE in ProcessConsole$InputReadJob.runI20181019-0450I20181019-0330I20181018-1800Andrey Loskutov1-3/+7
Change-Id: Ib4c5510e95e2d707e9b649c010cc6d16ffe01609 Signed-off-by: Andrey Loskutov <>
2018-10-18Bug 540242 - SWTException in InternalTreeModelViewer.getDisplayAndrey Loskutov2-13/+11
ElementMementoRequest should not try to call done() on already disposed viewer Change-Id: I09276f7f001a4c1725519183ee1a05d8485c6fb2 Signed-off-by: Andrey Loskutov <>
2018-10-18Bug 491273 - remove copy/pasted getClosestMonitor() implementationAndrey Loskutov2-40/+3
Change-Id: I66ec9cdcde9ea31977ae5b5f77282edcdd22a684 Signed-off-by: Andrey Loskutov <>
2018-09-14Bug 355011 - Deadlock on creating console in the build threadI20180914-0620Andrey Loskutov1-16/+61
Do not create console directly in the launchChanged() callback, because the current thread may hold already some lock, and if the ProcessConsole() init requires another one lock, we will have a classic deadlock. In case of bug 355011 current thread owns workspace lock and ProcessConsole() init requires UI lock. Change-Id: Ia01df4cb3f714b16fce84620538e66aa3de10b76 Signed-off-by: Andrey Loskutov <>
2018-09-14Bug 537903 - Wrong Debug View due to evaluation on debug context changeSimeon Andreev1-2/+12
Whenever an evaluation runs during thread suspend handling, its possible to create a delta which selects the suspended thread but not its first stack frame. This results due to very specific interleaving of thread running state and code in ThreadEventHandler.fireDeltaUpdatingSelectedFrame(). An evaluation can e.g. be triggered by a job in client code, either with IJavaThread.runEvaluation() or with IJavaObject.sendMessage() methods. No synchronization is possible between those methods and the suspend handling, since such synchronization can block debug event processing and so potentially lead to deadlocks. This change attempts to salvage the situation, after the bad case is encountered. If no top stack frame could be retrieved by ThreadEventHandler.fireDeltaUpdatingSelectedFrame(), but the thread is in suspended state, we query the top stack frame again. In case one evaluation ran in parallel with the suspend handling, at this point we know for sure that the evaluation is done and so the top stack frame is accessible. This change does not help in case client code bombards the thread with evaluations. It also does not help in case an evaluation ran throughout the entire thread suspend handling. Change-Id: I34252c0dac3d031bbbefc3a1328175cab0793ae5 Signed-off-by: Simeon Andreev <>
2018-09-12Bug 538548 - Debug View in another perspective causes editor to pop-upY20180912-2200I20180913-1800I20180913-0415I20180912-2240Simeon Andreev1-1/+3
If a window has the Debug View open in an inactive perspective, breakpoint hits will cause an editor to open in that window. This hinders the use of multiple windows, each with a different type of perspective. Only windows which have the Debug View in their active perspective should show source on breakpoint hit. The editor is activated due to the Debug View reacting to selection events, which occur due to breakpoint hits. This change ensures that the Debug View will react to selection events only if its active. I.e. only if the active perspective of the window contains the Debug View. Change-Id: Ida92f5322e1a83b95af4bc43f25a9fac9d4519b6 Signed-off-by: Simeon Andreev <>
2018-09-11Bug 538303 - Debug View wrong selection if activated by breakpointI20180912-0225I20180912-0210I20180911-1400Simeon Andreev3-3/+3
If a breakpoint is hit when the Debug View is not active, the Debug View is activated. In some cases, this leads to a bad selection and expanded state. When the Debug View is activated, either by a breakpoint or by a user, a state is saved in ViewerStateTracker. This state is cancelled by TreeModelContentProvider on breakpoint hit, however without removing COLLAPSED delta states. As such, applying the state later on will lead to a collapsed thread, if the state had a collapsed flag for that thread. This "overwrites" a thread selected by suspend handling. This change should ensure that COLLAPSED thread state in ViewerStateTracker is cleared when an expand is handled, regardless if the tree had to be expanded or was expanded already by another operation. Change-Id: I7c43b8317081747c6d8e85020e7040e928c4f39b Signed-off-by: Simeon Andreev <>
2018-09-04Bug 538531 - POM version change for 4.10 releaseY20180905-2200I20180907-0855I20180907-0715I20180907-0650I20180907-0400I20180906-1400I20180906-0005I20180905-1305I20180905-0410Sravan Kumar Lakkimsetti1-1/+1
Change-Id: I05159d79d261e80ffc94a2bf3abccc6ec3b46243 Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-08-27Bug 537877: Drawing problems in debug breadcrumb toolbarY20180829-2200S4_9_0_RC2S4_9_0_RC1R4_9I20180906-0745I20180905-2000I20180905-0800I20180904-2000I20180904-0800I20180903-2000I20180903-1305I20180903-1125I20180903-0945I20180903-0800I20180902-2000I20180902-0800I20180901-1500I20180901-0800I20180831-2000I20180831-0815I20180830-1030I20180829-2000I20180829-0800I20180828-2000I20180828-0800I20180827-2000I20180827-0800R4_9_maintenanceMatthias Becker2-2/+4
Change-Id: Ic0e03e48c221ef85d91c4c1bae895e3a488c3042 Signed-off-by: Matthias Becker <>
2018-08-21Bug 535802 - EPL-2.0 for platform.debug plug-insY20180823-0800Y20180822-2200S4_9_0_M3I20180823-0450I20180823-0430I20180823-0100I20180822-2000I20180822-0800I20180821-2000Lars Vogel870-2620/+5220
Commands used for this conversion: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/\/legal\/epl-v10.html/\1\2https:\/\/\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I3c49f3d254233c87acef9c83b3eb9ba831b9d6ff Signed-off-by: Lars Vogel <>
2018-08-20Bug 530393 - EPL 2.0 for exsd in platform.debugI20180821-0800I20180820-2000Lars Vogel17-51/+102
Based on the following regex. find . -type f -name "*.exsd" -exec sed -i -E 's/http:\/\/\/legal\/epl-v10.html\&quot;\&gt;http:\/\/\/legal\/epl-v10.html\&lt;\/a\&gt;/https:\/\/\/legal\/epl-2.0\&quot;\&gt;https:\/\/\/legal\/epl-v20.html\&lt;\/a\&gt;\/\n\nSPDX-License-Identifier: EPL-2.0/' {} + find . -type f -name "*.exsd" | xargs sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' find . -type f -name "*.exsd" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I560e99597565ce4ddf645ff1632b84603cb30086 Signed-off-by: Lars Vogel <>
2018-08-20Bug 538072 - Show Command Line button is shown when there are no launchI20180820-0800Sarika Sinha1-0/+1
configurations Change-Id: Icd83fcd3fd3b61bbedec07c3873f4ee39376f11f
2018-08-14Bug 537525 - Follow up of Bug 312397 - Run Configuration Command Line toI20180819-2000I20180819-0800I20180818-1500I20180818-0800I20180817-2000I20180816-2000Sarika Sinha4-4/+57
Clipboard Change-Id: Idfb989cb7ff3d47c4162becea5227a7c04e975cc
2018-08-14Bug 537525 - Follow up of Bug 312397 - Run Configuration Command Line toY20180815-2200I20180815-2000I20180815-1250I20180814-2000I20180814-0910I20180814-0900Sarika Sinha2-1/+8
Clipboard Change-Id: If197112aa3f36344e0efc5d77be169ae743d9e27
2018-08-09Bug 537818 - missing "a" in date pattern string variableI20180813-2000I20180812-2000I20180811-1500I20180810-2000I20180810-0320I20180809-2000Michael Keppler1-1/+1
Also remove the plenking by replacing double blanks with single blanks. Change-Id: I0ae81e406d770b6776e1b4ebd57c42d3e120e610 Signed-off-by: Michael Keppler <>
2018-08-01Bug 312397 - Run Configuration Command Line to ClipboardY20180808-2200Y20180801-2200S4_9_0_M2I20180808-2000I20180807-2000I20180807-1425I20180807-0350I20180806-2000I20180806-0300I20180805-2000I20180804-1500I20180803-2000I20180801-2000I20180801-0820I20180801-0800Sarika Sinha1-0/+1
Change-Id: I23b39a6165a1a50723fd41aaeb5e91e945d7485c
2018-07-31Bug 312397 - Run Configuration Command Line to ClipboardI20180801-0550I20180731-2000I20180731-1305I20180731-1250I20180731-1025I20180731-0800Sarika Sinha2-9/+11
Change-Id: I6d6b01ad2bda796a43c77399a6a62b2f59edd9fc
2018-07-29Bug 312397 - Run Configuration Command Line to ClipboardI20180731-0340I20180730-2240I20180730-2000I20180730-0800I20180729-2000Sarika Sinha4-20/+50
Change-Id: I19d054bed10f834c52bc00f0397255f870b4d6c8
2018-07-27Bug 312397 - Run Configuration Command Line to ClipboardI20180729-0800I20180728-1500I20180728-0805Sarika Sinha4-2/+186
Change-Id: I766655f94324002a8e67310e7882c1a63a706c5b
2018-07-24Bug 537330 - Breakpoints View NPE on perspective switch during debugI20180727-2000Simeon Andreev1-0/+4
The error log indicates that at the time of BreakpointsView.contextActivated, the Breakpoints View had no tree model viewer. This caused a NPE to be logged in the Error Log. This change adds a guard to the method, similar to the guard found in VariablesView.contextActivated. This avoids the logged NPE and does not alter behavior otherwise; the rest of BreakpointsView.contextActivated does nothing if there is no tree model. Change-Id: I070a2714c40636fb8796a963b7a3d4c147c04bf9
2018-07-24Bug 537322 - Improved logging in exception case of flushMarkerCacheY20180725-2200I20180726-2000I20180725-2000I20180724-2000Simeon Andreev1-1/+5
Whenever an exception occurs during marker attribute setting in BreakpointWorkingSetCache.flushMarkerCache, the logged error does not include information for the attributes which are to be set on the marker. When logged e.g. from tests, its difficult to understand where the logged error is coming from. This change adds some extra information to the logged error. Change-Id: I0b9a1aadb9310b26778f200df4004cdbb8756eef Signed-off-by: Simeon Andreev <>
2018-07-20Bug 465666: Fix bread crumb background in dark themeY20180723-0635Y20180723-0615I20180723-2000I20180722-2000I20180721-1500I20180720-2000Matthias Becker7-127/+66
Change-Id: Ifb6349ffd0af011933760e6ee8eef3f984209b8e Signed-off-by: Matthias Becker <>
2018-07-19Bug 521038 - [refactoring] Replace anonymous Runnable classes by lambdaAlexander Kurtakov62-2013/+1545
expression Changed some formatters to Eclipse so there is some formatting happening as the debug one is not clear where to get from and it's unrealistic to expect random contributors to do it. Change-Id: I731410854f9a4ac0c9fc18bcf3ad3dcf7d941c9a Signed-off-by: Alexander Kurtakov <>
2018-07-15Bug 535151 - Show only launch types with children in export dialogY20180718-2200I20180718-2000I20180718-0130I20180717-2000I20180717-0320I20180716-2000I20180716-0715I20180715-2000Michael Keppler1-5/+26
Since a typical Eclipse user will have a lot of empty launch config types (i.e. with no defined launch configs or prototypes), which we can hide from the export launch config dialog. Had to move some private members from the nested class to the top level class to use them in both. Signed-off-by: Michael Keppler <> Also-by: Karsten Thoms <> Change-Id: I04a0e52b5c9d4427e5221591b33ea0aaf67488e7 Bug:535151
2018-07-14Bug 535466 - Menus in export launch dialog should have ellipsisMichael Keppler1-2/+2
Change-Id: Id1fffba4c3976e7f3efbc0dba8468a6fd0382f51 Signed-off-by: Michael Keppler <> Bug:535466
2018-07-13Bug 536648 - Thread evaluation runs in parallel with thread label updateI20180714-1500I20180713-2000Simeon Andreev1-1/+1
When running an evaluation on a thread suspension, its possible that a label update of the Debug View runs in parallel. The label update can then retrieve the intermediate state of the evaluation. If no further label update is issued, the thread will be shown as running until the Debug View is refreshed. With this change, suspending a thread after an evaluation will also update the thread state in the Debug View. This avoids the wrong running icon of the thread. Change-Id: Id6ec6a9d48c041d0b2617adb8b7da91ba5140b15 Signed-off-by: Simeon Andreev <>
2018-07-05Bug 536677 - AbstractDebugView should release MessagePage instancesI20180710-2000I20180709-2000I20180708-2000I20180707-1500I20180706-2000I20180705-2000Andrey Loskutov1-16/+15
Not disposed MessagePage holds site -> serviceLocator -> services -> window reference of closed window. Change-Id: I0e5045d752e35b83f6463bb61114dda09f8bf994 Signed-off-by: Andrey Loskutov <>

Back to the top