Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-03-20Remove unnecessary whitespace in LaunchFavoriteTestsI20200322-1800I20200322-1150I20200322-0300I20200321-1800I20200321-0440Lars Vogel1-1/+1
Change-Id: Ie6f8f66a92b6c8afbf3c1fd0a4667a0c4549f71a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-204.16 version bump for org.eclipse.debug.testsKarsten Thoms2-2/+2
Required for https://git.eclipse.org/r/#/c/159780/ Change-Id: Ifbe341df5329658ccadeadf4b73b31ea7d69e673 Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>
2020-03-06Bug 560872 - POM and product version change for 4.16 releaseY20200309-1300Y20200308-0700Y20200308-0520X20200313-0410X20200312-1900X20200312-1530X20200312-1210X20200312-0700X20200311-2150X20200311-1900X20200311-0820X20200306-1900I20200313-1800I20200313-0810I20200312-1835I20200312-1800I20200311-1800I20200310-1800I20200310-0810I20200309-1800I20200309-0810I20200308-1800I20200307-1800I20200307-1145Mat Booth1-1/+1
Change-Id: Ifcb7805f8c4c779f434dc85604d0b8c24ad08890 Signed-off-by: Mat Booth <mat.booth@redhat.com>
2020-02-20Bug 560352 - Migrate debug.tests to JUnit 4X20200222-0700X20200221-1130X20200221-0700I20200222-0600I20200221-1800Alexander Kurtakov68-866/+976
Change-Id: I63e3acd4d926282e5b2c92e63d01004376c108fc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-17Bug 251642 - [Tests] Fix race condition in testTerminateTimeStampY20200219-1055Y20200219-0850Y20200218-1420Y20200218-1210Y20200218-0315Y20200218-0120X20200221-0440X20200221-0310X20200221-0050X20200220-1900X20200220-0700X20200219-1900X20200219-0700X20200219-0500X20200218-0510X20200217-1120S4_15_0_M3I20200219-1800I20200219-0600I20200218-1800I20200218-0600I20200217-1800Paul Pazderski1-0/+29
Process termination is recognized in a separate thread. Looking for termination timestamp without waiting for termination is a bad idea. Change-Id: I2fe934b898b689a7cfba9e2eaec4676bd97103cd Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-16Bug 251642 - Store termination timestamp as launch and process attributeI20200217-0600I20200216-1800Paul Pazderski1-4/+30
Also show termination time in process property dialog and process console label and set launch time as process attribute for external tool launches. Change-Id: I052d280d16d8ad42d70992b0a57324a9ce2e4963 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-12Bug 550195 - Reduce wait time in runtime process terminationI20200216-1145I20200215-1800I20200215-0600I20200214-1800I20200214-0620I20200213-1800I20200213-1520I20200213-1210I20200213-1100I20200213-0640I20200212-1810I20200212-1800Paul Pazderski3-4/+141
Java 8 added a waitFor method with timeout for the Process class. Using this instead of the plain Thread.sleep can reduce waiting time in some situations from 500 ms down to 10 ms. For the case that Process is not a native process and has no optimized waitFor implementation the situation still improves since the terminated check is performed every 100 ms instead every 500 ms. Change-Id: I0fc54981b53615fbae14d46a6c82a9b85d64b035 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-22Bug 553282 - [console] Handle \f and \v in console outputY20200130-0045Y20200127-1055Y20200126-2245I20200201-1800I20200131-1800I20200130-1800I20200129-1800I20200129-0935I20200129-0100I20200128-1805I20200127-1800I20200126-1800I20200126-0250I20200125-1805I20200124-1800I20200123-1800I20200123-0525I20200123-0430I20200122-1805Paul Pazderski2-9/+69
Change-Id: I8c86ad1116aa12c59ec4cbfbf2662e484c55c1c4 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-17Bug 365770 - Race condition in IOConsolePartitioner causes consoleY20200120-0020I20200120-0530I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800Paul Pazderski2-0/+28
output to be lost or not cleared Due to the race condition when calling outStream.print("First"); console.clearConsole(); outStream.print("Second"); from a single thread the actual console content could be "FirstSecond" or "" where only "Second" is correct. Change-Id: Ifeaed46e11652c53297c1aac3ff4fa1dd07e401b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-15Use System.lineSeparator()I20200116-1800I20200116-0930I20200116-0330I20200116-0310I20200115-1800Lars Vogel1-1/+1
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: Ib14dc56626a541a2bace31952281cfbb6e0a9a00 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-14Bug 421303 - Potential deadlock in IOConsolePartitioner.streamAppendedPaul Pazderski1-0/+64
The deadlock requires that a separate thread is write large amounts of content rapidly to console and while doing this holds lock(s) with UI thread may require. An example is that both (UI and non-UI thread) write to console using the same IOConsoleOutputStream and therefore sharing the streams write lock. Change-Id: I5c72b60e765ec550928ba872f089494593475856 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-11Bug 559070 - Fix resource related compiler warnings in platform.debugPaul Pazderski4-24/+39
Change-Id: If9102e5fcd24e7888596fd33a14ed5529419acc2 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-03Bug 558732 - Fix compile error 'closable should be managed byY20200103-2350I20200105-1800I20200105-0955I20200105-0600I20200104-1800I20200104-0625I20200104-0600I20200103-1800Paul Pazderski1-17/+18
try-with-resource' Change-Id: I82ad6831d4282e6626fd38f001ea12bd15335226 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-21Bug 558489 - [console] Remove unnecessary recoding in ProcessConsoleI20200102-1800I20200101-1800I20191231-1800I20191230-1800I20191229-2200I20191229-1800I20191228-1800I20191227-1800I20191226-1800I20191225-1800I20191224-1800I20191223-1800I20191222-1800I20191221-2205I20191221-1800Paul Pazderski3-3/+3
output handling Apart from removing an unnecessary string -> bytes -> string round trip it fix a potential content corruption since the source (TextConsole) encoding and target (IOConsoleOutputStream) encoding can differ. Also the stream listener implementation in ProcessConsole is simplified a lot and lost some dead code. Last but not least it replaced some usages of encoding names as strings with using the Charset class to reduce overall number of charset lookups. Change-Id: Ie94aa433e571a2f9898c950d2997f598618aca18 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-06Bug 553742 - POM and product version change for 4.15 releaseY20191208-2315I20191210-0230I20191209-2205I20191209-1600I20191209-1310I20191209-1130I20191209-1110Niraj Modi1-1/+1
Change-Id: Idaef2793bf1fa8aece6a02b2136b1fd09d344d73 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-11-16Bug 76936 - [console] Handle \b and \r in console outputY20191126-0500I20191126-0600I20191125-1800I20191125-0600I20191124-1800I20191124-0600I20191123-1800I20191123-1115I20191123-0600I20191123-0100I20191122-1800I20191120-2335I20191120-1800I20191120-0840I20191120-0600I20191119-2200I20191119-1800I20191119-1250I20191119-1235I20191119-1215I20191119-1155I20191119-0850I20191119-0725I20191119-0510I20191119-0315I20191119-0020I20191118-2230I20191118-1800Paul Pazderski1-0/+154
Change-Id: Ia5e5b2760a0a9a097c003c41e3229e149003f22b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-12Bug 552014 - [console] Input problem with fixed width console and IMEI20191112-1800Paul Pazderski5-36/+187
When IME is started at end of fixed width line the first stroke is immediately inserted as character and the IME continued after. Change-Id: I9a197f49b9b9aae8c279fe5638fa5278d66294c8 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-06Improve tear down in IOConsoleTests and ProcessConsoleTestsY20191107-0440Y20191107-0420I20191109-0650I20191109-0330I20191108-1800I20191107-1800I20191106-1805Paul Pazderski2-2/+4
Before 'asserting' in tearDown do the cleanup stuff which would not be executed if the assertion fails. Change-Id: I9f72d0a073957aea4d216be4cff58729494bbe82 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-10-16Bug 550220 Sometimes incomplete stack is shown for threads that wereUmair Sair1-0/+187
expanded before resume CheckState model delta visitor removes delta if parent flags are NO_CHANGE and there are no pending updates reported for it from content provider. In case of this bug, the updates for elements (threads in view) are a bit late and CheckState visitor removes that delta. The removal of delta causes improper view like expanded thread with only one frame. Change-Id: Ia1d33d6e59db285dbd6c1acf4503b7406809ecdb Signed-off-by: Umair Sair <umair_sair@hotmail.com>
2019-10-13Bug 552015 - [console] Streams closed notification send to late if inputI20191013-1800Paul Pazderski2-0/+99
is connected to file If process input is connected to file the 'all streams are closed' notification was not send on process termination but later on console removal. Change-Id: I83a732e1c876d9c15b7274159c18dc7723ef5143 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-26Bug 550621 - [console] Improved user input handling in IOConsole.I20190930-1800I20190929-1800I20190928-1800I20190928-0515I20190928-0205I20190928-0000I20190927-1800I20190927-1530I20190927-0255I20190927-0225I20190927-0145I20190926-1800I20190926-0625Paul Pazderski1-5/+36
Improvements: - if user tries to override/delete writable and read-only parts only the writable parts are removed - if user types in read-only part it is appended at the next possible writable part - if user types at border of writable part this writable part is better reused - if user paste content with multiple lines this his handled more consistent with behavior when user is typing multiple lines Change-Id: I47e4ee7493170d3537734325f0362fd6a8d7a16c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-24Bug 550586 - Fix files that have ended up with CRLF in the gitI20190924-1800Ed Merks1-36/+36
repository Update version for 4.14 stream for - org.eclipse.core.variables - org.eclipse.core.externaltools Change-Id: I2c5ec65909a0078024fa8579408c2caf04a6671c Signed-off-by: Ed Merks <ed.merks@gmail.com> Also-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-09-23Bug 550617 - [tests] Add helper method for preference changesI20190923-1800Paul Pazderski3-8/+35
If a unit test need to change a preference a common pattern is to get the current value, set the value for test and then ensure to reset the old value after the test finished to not influence other tests. The helper simplify this task. Change-Id: Ifeb1731b9f44bfcb85cb61cae17da22116803dfb Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-19Bug 550621 - [console] Add IConsoleDocumentPartitionerExtensionPaul Pazderski1-0/+51
Used to better test for read-only parts of console document. Change-Id: I1d8e3b2655080a8b435e8aaf296c40823239cc93 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-16Use jdk 5 for-each loop (Part 3)Carsten Hammer8-37/+34
Replace simple uses of Iterator with a corresponding for-each loop. Also add missing braces on loops as necessary. Change-Id: I143bc5e03ef6f52a8b80897d61d20b3619c9dad8 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-09-15Bug 550618 - [console] IOConsolePartitioner produces overlapping styleI20190915-1800Paul Pazderski1-0/+91
ranges Old implementation adjusted range start but did not touch the ranges length resulting in invalid overlapping ranges. Change-Id: Ie6cf1289a62a4d63f46b682b67bc72cd2d223bd2 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-12Bug 550620, 197958 - Fix style range override in TextConsoleViewerPaul Pazderski4-2/+330
Current implementation of override works most of the time since the usual combinations of existing style ranges and link range are quite limited. New implementation yields correct results for any combination. This also supersedes fix of Bug 111256. Change-Id: Idcc94f4be0d7ca815e854a2d2a271a32494a2412 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-09-06Bug 550767 - POM and product version change for 4.14 releaseI20190910-0815I20190910-0145I20190909-1520I20190909-1425I20190909-0925Niraj Modi1-1/+1
Change-Id: I29e9b6d5e32511c3ebca7d7042871fd20c0bc3f0 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-07-05Bug 529651 - Add unit test for 'no build before group launch'Paul Pazderski2-4/+91
Change-Id: Ifeb288c9088b9d7ea0b37a78ef86465e0ee75424 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-06-29Bug 548356 - [console] Fix input handling in IOConsoleI20190702-0930I20190702-0610I20190701-1805Paul Pazderski2-1/+97
Existing IOConsole and especially IOConsolePartitioner have various problems with user input handling e.g. if existing input surrounded by output is modified or a character composition is started inside an output partition. Change-Id: I3ea4f19553d6363e0d3cdc5280b577be57b45bd9 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-06-21Lamba optimizationLars Vogel1-1/+1
Use method references if possible Remove unnecessary brackets Change-Id: I82c219171f7b3e459d4e2f70ae916d44d25fdc11 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-20Small String optimizationI20190620-1800Lars Vogel4-9/+9
Useless toString call in String concatenation Using String.valueOf instead of ""+ Use faster indexof('') version Change-Id: Iec383bd1b6af03a40af735f9ec878689caf4fb23 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-18Use addAll, deleteAll instead of looping through a collectionI20190620-0130I20190619-1820I20190619-1800I20190618-1805Lars Vogel2-18/+8
Change-Id: I9c95900ed1b6e8823bb30c4ded37f214a92deffc Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17Bug 547064 - [console] Unnecessary linear search in IOConsolePartitionerI20190617-1800Paul Pazderski1-0/+1
getPartition can use binary search like computePartitioning already does. Also computePartitioning fails if no partitions available or requested range is behind known partitions. Change-Id: I54b120e91a696412bf9466f5a2f10d7bac154b0c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-06-17Remove redundant blockLars Vogel1-27/+25
Change-Id: Ic7b908b1e823d854b13c7fd4d882a98aef730c8d Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-14Bug 547304 - [cleanup] Fix wrong space/tab indentationI20190616-1800I20190615-1800I20190614-1800Paul Pazderski45-4471/+4471
This change fixes space or mixed tab/space indentations in all Java files. This also includes two or three space indentations and even fix most stray single spaces in indentations. The change includes only whitespace formatting and no code changes. Change-Id: I95f385f1587b72776aee5d955b66e82539dedc3c
2019-06-13Use StringBuilder instead of StringBuffer where possible.Carsten Hammer4-7/+7
Change-Id: I990721405fb7e486fc93ef2b22e56e81ed4a78c8 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-12Use isEmpty() instead of size()==0 where possibleCarsten Hammer1-1/+1
Change-Id: Iba492570def0a381d0c4a06a5ad3b7c8c8a3419e Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-124.13 version updateKarsten Thoms2-2/+2
Updates for bundles - org.eclipse.debug.core - org.eclipse.debug.examples.memory - org.eclipse.debug.tests Required for https://git.eclipse.org/r/#/c/142755/ Change-Id: I688962782924fe02be0252096a7263678aae32c7 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-06-07Bug 547907 - POM and product version change for 4.13 releaseI20190610-1800I20190610-0135I20190608-0140I20190607-1345I20190607-1000I20190607-0725Niraj Modi1-1/+1
Change-Id: I2d875884ed291c9180439959c4d2940a75fd0803 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-05-18Explicit set encoding for charset sensitive testI20190518-1800Paul Pazderski1-2/+5
Change-Id: I76bd8f54134fb15e3bf88d61f99bb4400aae2d15 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-05-14Bug 545769 - [console] UTF-8 content read or send to process can beI20190517-1800I20190516-1800Paul Pazderski3-1/+148
corrupted With some bad luck the ProcessConsole may disrupt multibyte UTF-8 characters read from input source (usually user input or file) due to incorrect stream reading / buffer handling. The same problem exist for reading the processes output streams. Change-Id: I8d52d1973f3739e2c510a8a4c48b44f345c33dfe Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-05-14Bug 546641 - [console] IOConsoleInputStream throws unwanted IOExceptionsI20190516-1405I20190516-1335I20190516-1250I20190516-1200I20190516-1055I20190515-1800I20190515-0205Paul Pazderski1-5/+25
If IOConsoleInputStream methods are called in some particular sequences they throw unwanted exceptions. Change-Id: I0a3dcd2f8dd6c77b31cf3f693122bf06f5ae123a Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-05-07Bug 547063 - [console] Tests for IOConsoleI20190508-0450I20190508-0150Paul Pazderski3-0/+999
Especially tests for IOConsolePartitioner and IOConsoleViewer. Change-Id: I7d2f9a76cea6529b344a51e22aa3f623659fb900 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-05-02Bug 544970 - [console] Tests for ConsoleDocumentAdapterI20190507-1800I20190507-0155I20190506-1800I20190505-1800I20190504-1800I20190503-1800I20190502-1800Paul Pazderski1-0/+963
Many test cases for fixed calculation of TextChangingEvents. Change-Id: Ifc23e7b3371b6d96cefa6303447ab90ac219d500 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-04-28Bug 546710 - [console] Race condition on process console creationI20190501-1800I20190501-0525I20190430-1800I20190429-1800I20190429-0240I20190428-1800Paul Pazderski4-4/+166
Change-Id: I473f4fa1296cbbc823f6d2b6ad6827957816d64c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-04-24Bug 546641 - [console] ProcessConsole InputReadJob is not cancelableI20190425-0030I20190424-1800Paul Pazderski3-0/+300
Change-Id: I453380da668bc5d04e2f90469a16d2ce37d1e90d Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-04-22Revert "Bug 307309 - [console] IOConsoleInputStream throws unwantedAndrey Loskutov1-25/+5
IOExceptions" This reverts commit e5b4f42c768864837d6f15b5b2db8861d35f7829, which caused regression, see bug 307309 comment 19. Change-Id: Id399ccdc46235b7529415ba7473b777309a7f12d Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-04-16Bug 307309 - [console] IOConsoleInputStream throws unwanted IOExceptionsI20190422-1800I20190421-1800I20190420-1800I20190419-1800I20190418-1800I20190417-1800I20190416-1800Paul Pazderski1-5/+25
If IOConsoleInputStream methods are called in some particular sequences they throw unwanted exceptions. Change-Id: I42f8237ceda47634ce94e98fe4c5d8894cf8d86a Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-03-20Remove useless non-javadoc see comments.Alexander Kurtakov3-14/+0
Handled by Override annotation. Change-Id: Icd0334c0b57bb3021693117877a9af5fcda571d7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>

Back to the top