Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/org.eclipse.debug.core/core/org/eclipse
AgeCommit message (Collapse)AuthorFilesLines
2019-01-05Bug 536943 - add method to check if OutputStreamMonitor is doneY20190109-2200Y20190108-0410Y20190108-0135Y20190107-0850Y20190107-0505S4_11_0_M1I20190109-1800I20190109-0655I20190108-1800I20190108-0600I20190107-2050I20190107-1800I20190107-0600I20190106-1800I20190106-0600I20190106-0150I20190105-1800Simeon Andreev1-1/+21
This change adds further functionality to org.eclipse.debug.internal.core.OutputStreamMonitor, which allows checking whether stream reading is done. Change-Id: Icd973a76fee9d1beeedcda988cf7a9c119f9a2b4 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-12-20Revert "Bug 536943 - give the reader thread a chance to start reading"Simeon Andreev1-87/+2
This reverts commit f01aa33b2a7155e98055c57f78608525b7e33d15.
2018-12-13Bug 536943 - give the reader thread a chance to start readingY20181219-2200I20181219-1800I20181218-1800I20181218-0120I20181217-1800I20181216-1800I20181215-1800I20181215-0340I20181214-1800I20181214-0720I20181214-0105I20181213-1800Andrey Loskutov1-2/+87
Added a wait in OutputStreamMonitor.getContents(), until stream reading is done or until a timeout of default 10 seconds occurs. If the timeout is reached before stream reading is done, a warning is logged. The timeout can be configured by specifying VM property: -Dorg.eclipse.debug.core.msMaxWaitTimeForStreamMonitorReading=5000 The VM property time unit is milliseconds. The wait ensures that callers of OutputStreamMonitor.getContents() actually see correct stream contents in cases such as accessing contents before the reading has even started, which could cause bug 536943. Change-Id: I7e4af3d06ef528030df5b263b3d664b853f12456 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-12-13Bug 527365 - use IWorkspace.AVOID_UPDATE in all breakpoint operationsAndrey Loskutov1-4/+4
Change-Id: I664a6c564d484b99176b4f513c20e210966a485a Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-11-08Bug 540850 - Permanent freeze relating to breakpoint updateI20181114-0925I20181114-0355I20181114-0200I20181112-1800I20181112-0435I20181112-0320I20181109-0350I20181108-1800Andrey Loskutov1-5/+10
Do not lock BreakpointManager in the call to enableTriggerPoints() - it will try to acquire workspace lock while modifying markers, and this can deadlock with other threads trying to access BreakpointManager while holding the workspace lock. Instead, lock on fTriggerPointDisabledList instance. Change-Id: I03c9fba2d8ec84dad0f7f1a598cbe8a908c9d94a Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-11-08Bug 540850 - code cleanupAndrey Loskutov1-24/+22
As a preparation for the bigger change, cleaning up some code issues. - made all effectively final fields final - removed printStackTrace() - simplified code inside enableTriggerPoints() Should not affect any existing functionality. Change-Id: Ie1b1df3370833cd8995a1488a3d2e730f32ff0f2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-09-10Bug 520346 - Disabled trigger point gets enabled automaticallyI20180910-0310Sarika Sinha1-2/+21
Change-Id: I3966b4ef2e52b4c4cf1083a0e623d9539e9717cc
2018-08-21Bug 535802 - EPL-2.0 for platform.debug plug-insY20180823-0800Y20180822-2200S4_9_0_M3I20180823-0450I20180823-0430I20180823-0100I20180822-2000I20180822-0800I20180821-2000Lars Vogel202-606/+1212
Commands used for this conversion: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I3c49f3d254233c87acef9c83b3eb9ba831b9d6ff Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-07-28Bug 312397 - Run Configuration Command Line to ClipboardI20180729-0800I20180728-1500I20180728-0805Sarika Sinha4-3/+64
Change-Id: I766655f94324002a8e67310e7882c1a63a706c5b
2018-07-19Bug 521038 - [refactoring] Replace anonymous Runnable classes by lambdaAlexander Kurtakov3-25/+12
expression Changed some formatters to Eclipse so there is some formatting happening as the debug one is not clear where to get from and it's unrealistic to expect random contributors to do it. Change-Id: I731410854f9a4ac0c9fc18bcf3ad3dcf7d941c9a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-11Bug 536681 - [ZipSlip] ArchiveSourceContainer can create ZipEntryStorageY20180712-0200I20180712-2000I20180711-2000Sarika Sinha1-11/+22
objects containing unintended entries Change-Id: I2aa47ef66f92852671fbf0330056ac5516116693
2018-06-19Added toString() to a Breakpoint for debugging debuggerAndrey Loskutov1-0/+12
Change-Id: I13f3064cd851efb05acd7435af03ce63f6d84661 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-12Bug 534681 - Remove redundant modifiers in org.eclipse.debug.coreKarsten Thoms89-545/+539
Change-Id: I1c7eb444218819aa200fd8471ccfc99285bf5cd4 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-05-09Bug 533788 - Use StandardCharsetsI20180509-0800Alexander Kurtakov2-4/+4
Another bunch of such changes. Change-Id: I4012772607b8f7c165156b8d03fbd5bcbee4b581 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-03Using StringBuilder instead of StringBuffer in org.eclipse.debug.coreLars Vogel10-23/+23
Change-Id: If82d175d5e2793cf3974a05980fa95f348bc97ed Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-24Remove redundant type arguments in o.e.debug.core.Alexander Kurtakov29-875/+199
Remove useless see comments. MessageForma varargs to ease reading. Change-Id: I09c8202aed6441969d252d28d198b5d2a0d78fa7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-18Bug 533788 - Use StandardCharsetsI20180423-2000I20180423-0655I20180423-0640I20180422-2000I20180421-1500I20180420-2000I20180419-2000I20180418-2000Alexander Kurtakov1-97/+7
Also remove useless see comments, convert to lambda and remove redundant type arguments in touched files. Change-Id: Ia38a6b2b4861a75f7b3d16bef471bc3393f938f2 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-11Bug 529635 - [sonar] Resolve "Possible null pointer dereference"I20180114-2000I20180113-1500I20180112-2000René Purrio1-2/+2
Change-Id: I2d445f9e52fa07ade342c7252ff5154737cedd48 Signed-off-by: René Purrio <rpurrio@itemis.de>
2017-12-11Bug 41353 - Launch configuration prototypesI20171211-2000Axel Richard14-73/+1053
First implementation of the launch configuration prototypes mechanism. Change-Id: I21a2a97b83aa9cb1be79153bbc4b72171cc6be20 Signed-off-by: Axel Richard <axel.richard@obeo.fr>
2017-11-08Bug 527018 - [refactoring] Replace use of Number constructors by valueOfI20171113-2000I20171112-2000I20171111-1500I20171111-0410I20171111-0155I20171110-2000I20171109-2000Karsten Thoms1-1/+1
Change-Id: I67272d54f503635c460ccf382322ac4487933f71 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-09-08Revert "Bug 521038 - Replaced anonymous Runnable classes by lambda expression"Alexander Kurtakov3-11/+24
This reverts commit d8621eaf55a1e95ff894dda0a241af08cc6111fe. Change-Id: I30777d3cf90d9a14f5de5e599b8a0ceefe1c8292
2017-09-06Bug 521038 - Replaced anonymous Runnable classes by lambda expressionI20170906-2000I20170906-0815Karsten Thoms3-24/+11
Change-Id: Ia0d3478be72f514cce6e57cb679fa60668bdb23f Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-08-07Bug 520273 - synchronize access to group subLaunchesI20170906-0225Markus Duft1-54/+69
This fix makes sure that concurrent access to the subLaunches of a group cannot cause Exceptions - e.g. while terminating a launch group. Change-Id: I4e009b41b4acaa6104c2c53159e34c7f95841dbe Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-08-07Bug 519684 - don't execute post launch actions when adoptingMarkus Duft1-6/+16
When adopting already existing launches, the group should not execute that launches post launch action. Also notification about a launched group element can/must be inhibited. Change-Id: I3e162f376eb6a47a4580f4ddb20257962b33ed53 Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-06-05Bug 517740: [Launch Group] Externalisation of strings broke Group LaunchNoopur Gupta3-3/+3
UI Change-Id: I2acb3933ccc9ccfe2a90fd73014dc1ef0ecffb3d Signed-off-by: Noopur Gupta <noopur_gupta@in.ibm.com>
2017-05-04Fixed bug 516076: GVT47 : Non-externalized strings in Launch mode dropI20170504-2000Noopur Gupta3-4/+6
down list Change-Id: Ib0b746c8bbb8266a26116b6d50280cd1854476b2 Signed-off-by: Noopur Gupta <noopur_gupta@in.ibm.com>
2017-04-28Bug 515941 - ConcurrentModificationException inY20170504-1000I20170503-2000I20170502-2000I20170501-2000I20170430-2000I20170429-2000I20170429-1330I20170429-1230I20170428-2000I20170428-0830I20170428-0700I20170428-0550Andrey Loskutov1-6/+17
ExternalArchiveSourceContainer Don't try to dispose while the search is running, don't continue with search if container was disposed. Change-Id: Ida0e5e07a5cafe5bdab4096e991bacb13c8872bd Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-04-28Bug 515941 - code cleanup before fixAndrey Loskutov1-19/+4
Change-Id: I972d855a75f81d61b237bfe1b4b53a8d01a4894b Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-02-07Add missing copyright headers for recent changesY20170223-1000Y20170216-1515Y20170216-1450Y20170216-1000I20170228-2000I20170228-0330I20170228-0240I20170227-2000I20170226-2000I20170225-2000I20170224-2000I20170223-2000I20170222-2000I20170221-2000I20170220-2000I20170219-2000I20170218-2000I20170217-2000I20170216-2000I20170216-0140I20170215-2000I20170214-2200I20170214-2000I20170213-2000Markus Duft1-0/+10
Change-Id: I166699318948cff0bef1304aff7b635c5d0a5c6a Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-02-06Bug 508718 - Allow groups to catch up with renames in launch configsMarkus Duft2-0/+67
This change registers a global listener in the LaunchManager that handles updating launch groups whenever a member of that group is renamed. This relies on the workings of the ILaunchmanager#getMovedFrom method. Change-Id: Ie1a617b6e826b0a1b6adb0a1b962dc18484f071a Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-02-06Bug 510990 - don't FAIL if regex doesn't match, but don't continueMarkus Duft3-8/+10
Change-Id: I437f0bbd361a942761f114dc067ed532a182a474 Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-01-13Bug 510100 - [cleanup] Get rid of trailing white space in platform.debugY20170119-1000I20170119-2000I20170119-1010I20170119-0345I20170118-2000I20170118-1215I20170117-2000I20170116-2000I20170115-2000I20170114-2000I20170113-2000Andrey Loskutov87-722/+722
Also enabled "cleanup whitespace on save" actions for debug.ui and debug.tests bundles. Change-Id: I755b879ab1d49144a1bec3f4318dbb8b29521bb3 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-01-13Launch Groups: Support to wait for output on child stdoutMarkus Duft7-6/+182
This adds support to listen for output on the console of the launched item before continuing the launch. Bug: 508420 Change-Id: I84027592c82b546ddf60c415bcc7047d9bc5490a Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-01-12Launch Groups: Support to skip running launchesMarkus Duft2-17/+41
This change introduces a flag on each group entry that allows to skip launching that configuration in case it is already running, launched either manually or by another group. This allows to prevent duplicate launches for certain configurations. Bug: 508420 Change-Id: If0bac83f4486967c9b634dcad8ebdc848c1a1e8e Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-01-12Initial contribution of LaunchGroupTestsY20170112-1300Y20170112-1000I20170112-2000Markus Duft1-1/+3
These contain basic test for the existing launch group functionality. No tests for the additional functionality are provided in this commit. Test for additional functionality will be in the according commits. This commit also fixes a bug in the existing functionality that marks a group as terminated too early. Bug: 508420 Change-Id: I1e1e0ae512384665f926d7225b55c701dca92409 Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2017-01-02Bug 509825 - ResourceException below BreakpointManager$5.run (thrown inI20170105-0320I20170105-0230I20170104-2000I20170104-0800I20170103-2000Andrey Loskutov1-1/+5
Marker.checkInfo) Change-Id: I573ad6db8f41e3d03a8e0d03dc149275ef3a506d Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-11-30Initial contribution of Launch GroupsMarkus Duft5-0/+686
The initial contribution is a slightly modified/polished version of the launch group code in org.eclipse.cdt.launch. A follow up commit will contain additional modifications to merge features from another (external) implementation of launch groups. Bug: 492788 Change-Id: Ie0a902b857a5c2cc02f5c36d8591001493bd6e19 Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
2016-11-09Bug 506182 - Launch is not multi-thread safeAndrey Loskutov1-61/+149
Protect access to fTargets and fProcesses with read/write lock to avoid possible ConcurrentModificationExceptions. Change-Id: I1a42b263cd9b64c7ebb914b5fdea0d2d3e408b73 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-10-27Bug 501245 - Trigger points -- API deficienciesY20161103-1000I20161108-1015I20161108-0800Sarika Sinha5-107/+118
Change-Id: Ic30d5b6894408d5371b2095ef1b6cb109fbe318f
2016-09-14Bug 501333 - Trigger Points -- remove "Active Trigger" stateY20160915-1000I20160915-0230I20160915-0200I20160914-2300I20160914-2000I20160914-0800Sarika Sinha4-83/+15
Change-Id: I533652d802fac7de2db1ea8a98893cc02fbeca4e
2016-09-13Bug 501315 - Disabled by trigger icon not updated in Breakpoints viewI20160914-0430I20160914-0030I20160913-2000I20160913-0800Sarika Sinha1-0/+1
Change-Id: If2ccc9147e08c99240ed9b92e916d8bb6b11f4d0
2016-09-12Bug 488664: [Breakpoints] Ability to set up Breakpoint dependencyI20160912-2000I20160912-1005Markus Keller1-4/+4
fixed Javadoc error from build set reasonable Javadoc compiler settings
2016-09-12Bug 488664 - [Breakpoints] Ability to set up Breakpoint dependencyI20160912-0800Sarika Sinha3-12/+12
Change-Id: I36ebade65a7882afabfdaf86e5ac512fcc5a1e8d
2016-09-12Bug 488664 - [Breakpoints] Ability to set up Breakpoint dependencyI20160912-0430I20160912-0225Sarika Sinha1-1/+0
Change-Id: I1c1fac528621051b13ef70fe123499d08844dc8d
2016-09-09Bug 488664 - [Breakpoints] Ability to set up Breakpoint dependencySarika Sinha5-75/+453
Change-Id: I62043723be1a1448ba3fe38e60b0e67f10c5df05
2016-06-10Bug 469193 - Eclipse doesn't close debug session after project is closedSarika Sinha1-2/+8
(if launch configuration stores in project) Change-Id: If64676c7f3c8a9fec87ea9b8a9672427770766a5
2016-01-25Bug 486157: Adapt to ListenerList changesI20160126-0800I20160125-2000I20160125-0800Markus Keller1-6/+6
- removed outdated commented code - avoided loop when list is empty
2016-01-22Bug 486157 - Adapt to ListenerList changesI20160125-0400I20160124-2000Sarika Sinha5-75/+52
Change-Id: If4f1f4d0ccb2f8451b4901a2139aa6537542d41e
2016-01-04Bug 484882: Synchronize access to fSortedConfigNamesI20160112-1800I20160112-0800I20160105-1000I20160105-0800Jonah Graham1-2/+2
The new test demonstrates the problem by running two threads, one creating/deleting launch configs, the other one accessing fSortedConfigNames. Note if you set fSortedConfigNames to volatile without making clearConfigNameCache synchronized you can see the test fails generally very fast. Change-Id: I981d7054d51e263f5d097096ffe23cdc1fa74256 Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2015-09-11Bug 476814 - Replace new Integer() with Integer.valueOf()Alex Blewitt4-9/+9
Using Integer.valueOf() instead of new Integer() allows for the runtime to cache commonly instantiated values; typically, this will be for values in the range -128..127. Using valueOf is preferred for this reason. Change-Id: I1022eb4973b760b830ace5d39b76eea9353d4ca2 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>

Back to the top