Skip to main content
summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-02-24Bug 560274 - Race condition when updating debug toolbar button statesY20200318-0540Y20200317-0225Y20200316-1300Y20200316-0820Y20200314-1405Y20200313-1100Y20200311-0915Y20200310-0525Y20200305-0600Y20200225-1040X20200306-0700X20200305-1900X20200305-0700X20200304-1900X20200304-0700X20200303-1900X20200303-0700X20200302-1900X20200302-0930X20200302-0700X20200301-1900X20200301-0700X20200229-1900X20200229-0700X20200228-1900X20200228-0700X20200228-0520X20200227-1900X20200227-0700X20200227-0130X20200226-0700X20200225-1900X20200225-0700X20200224-1900X20200224-0700S4_15_0_RC2S4_15_0_RC1R4_15I20200305-0155I20200304-1800I20200304-0600I20200303-1800I20200303-0600I20200302-1800I20200302-0600I20200301-2310I20200301-1800I20200301-0600I20200301-0030I20200229-1800I20200229-0600I20200228-1800I20200226-1800I20200226-0600I20200225-1800I20200225-0600I20200224-1800I20200224-0600Simeon Andreev1-0/+28
This change adjusts the scheduling rule when updating toolbar command enablement via "org.eclipse.debug.internal.core.commands.ForEachCommand", e.g. the suspend toolbar enabled button state. The new rule is exclusive per command, as opposed to exclusive per selection type. I.e. before, debug target updates were exclusive, stack frame updates were exclusive, etc. Now, disconnect command updates are exclusive, suspend command updates are exclusive, etc. Change-Id: Ia22232b0a55c3aba429bc980ec5a26eb238afd44 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2020-02-22Bug 560353 - Sub-option "Interpret Carriage Return ..." must be indentedX20200223-1900X20200223-0700X20200223-0250I20200223-2335I20200223-1800I20200223-0600I20200222-1800Paul Pazderski1-1/+5
Change-Id: I8f464d6e0eae9afdc7ce6506243944680a341e5f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-20Bug 560352 - Migrate debug.tests to JUnit 4X20200222-0700X20200221-1130X20200221-0700I20200222-0600I20200221-1800Alexander Kurtakov68-866/+976
Change-Id: I63e3acd4d926282e5b2c92e63d01004376c108fc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-17Bug 251642 - [Tests] Fix race condition in testTerminateTimeStampY20200219-1055Y20200219-0850Y20200218-1420Y20200218-1210Y20200218-0315Y20200218-0120X20200221-0440X20200221-0310X20200221-0050X20200220-1900X20200220-0700X20200219-1900X20200219-0700X20200219-0500X20200218-0510X20200217-1120S4_15_0_M3I20200219-1800I20200219-0600I20200218-1800I20200218-0600I20200217-1800Paul Pazderski1-0/+29
Process termination is recognized in a separate thread. Looking for termination timestamp without waiting for termination is a bad idea. Change-Id: I2fe934b898b689a7cfba9e2eaec4676bd97103cd Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-17Bug 251642 - [console] Shorten terminate timestamp for same dayPaul Pazderski1-9/+29
If process started and terminated at same day (the most common case for process run in IDE) do not show the day part twice. Change-Id: I6b080af23b44b3bd6db5d6301794705fb5359c56 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-16Bug 251642 - Store termination timestamp as launch and process attributeI20200217-0600I20200216-1800Paul Pazderski14-49/+191
Also show termination time in process property dialog and process console label and set launch time as process attribute for external tool launches. Change-Id: I052d280d16d8ad42d70992b0a57324a9ce2e4963 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-15Bug 345435 - [console] EOF Ctrl+Z keybinding doesn't work with twoPaul Pazderski1-10/+17
consoles up Change-Id: I1e45eb5450887c9107e1cb46b3f3894e5443d85c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-12Bug 550195 - Reduce wait time in runtime process terminationI20200216-1145I20200215-1800I20200215-0600I20200214-1800I20200214-0620I20200213-1800I20200213-1520I20200213-1210I20200213-1100I20200213-0640I20200212-1810I20200212-1800Paul Pazderski4-5/+147
Java 8 added a waitFor method with timeout for the Process class. Using this instead of the plain Thread.sleep can reduce waiting time in some situations from 500 ms down to 10 ms. For the case that Process is not a native process and has no optimized waitFor implementation the situation still improves since the terminated check is performed every 100 ms instead every 500 ms. Change-Id: I0fc54981b53615fbae14d46a6c82a9b85d64b035 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-11Clean-up use lambdas and method references in ui.consoleI20200212-1420Lars Vogel3-49/+24
Using the JDT cleanup action -> - Use lambda where possible - Simplify lambda expression and method reference syntax Change-Id: Icdce7db08c100cf4eda0e9ebabf20afbe64ba36f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-02-05Bug 559814 - Shorter text for remove dialogsI20200212-0910I20200211-1800I20200210-1800I20200209-1800I20200208-1800I20200207-1800I20200206-1805I20200205-1800Lars Vogel2-5/+5
Change-Id: Ic8eb6641bce888366ac1971852a5fd3035b71099 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-02-04Use method reference instead of lambdasI20200205-0030I20200204-1800Lars Vogel3-4/+4
Method references are slightly faster than lambdas and better readable. Change-Id: I1eb012c76a425358503f171d291d6abe9a45d219 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-31Bug 559590 - "Custom" debug view is not considered inY20200204-0035I20200203-1800I20200202-1800Andrey Loskutov1-3/+12
SourceLookupService.debugContextChanged Check if the view part provided by the DebugContextProvider is shown, if the DebugContextProvider for given DebugContextEvent specifies its own part. This part is not necessarily the default Debug view. If this is the case, we also want to proceed with displaySource(). Change-Id: I1b86b3d2224c8532ddf23b4d423f211267ff3106 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-01-22Bug 553282 - [console] Handle \f and \v in console outputY20200130-0045Y20200127-1055Y20200126-2245I20200201-1800I20200131-1800I20200130-1800I20200129-1800I20200129-0935I20200129-0100I20200128-1805I20200127-1800I20200126-1800I20200126-0250I20200125-1805I20200124-1800I20200123-1800I20200123-0525I20200123-0430I20200122-1805Paul Pazderski3-14/+96
Change-Id: I8c86ad1116aa12c59ec4cbfbf2662e484c55c1c4 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-22Bug 553282 - Extract code to partition newly appended outputPaul Pazderski1-276/+309
This change is pure refactoring to simplify the diff of the actual enhancement from bug 553282. Change-Id: I36d531e9c2872b68608b8b54343220a558e4f5e7 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-20Use ArrayList instead of VectorY20200121-0055Y20200120-2315I20200121-2225I20200121-1805I20200120-1800I20200120-0715Lars Vogel2-4/+3
Vector is an outdated data structure and ArrayList should be preferred as it is faster. Change-Id: I93106bc75dfd76b9118ae607c0504efacd91ce3f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-20Use ArrayDeque in StringSubstitutionEngine instead of StackLars Vogel1-3/+4
Change-Id: I65b227abde82a39cde30834960344c9930663d20 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-204.15 update of org.eclipse.core.variablesLars Vogel2-2/+2
Required for https://git.eclipse.org/r/156114 Change-Id: Ia574a2d2941289c2cbc2cb733593d92dc194773f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-17Bug 365770 - Race condition in IOConsolePartitioner causes consoleY20200120-0020I20200120-0530I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800Paul Pazderski3-46/+95
output to be lost or not cleared Due to the race condition when calling outStream.print("First"); console.clearConsole(); outStream.print("Second"); from a single thread the actual console content could be "FirstSecond" or "" where only "Second" is correct. Change-Id: Ifeaed46e11652c53297c1aac3ff4fa1dd07e401b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-17Bug 229202 - [console] Open link in console context menu gets disabledPaul Pazderski2-11/+9
when activating Consequence was that context menu showed an active menu entry to open link but nothing was opened/executed. Change-Id: Ia2db5fe2caf3f7de9735e99732c691ba9c163e85
2020-01-15Use System.lineSeparator()I20200116-1800I20200116-0930I20200116-0330I20200116-0310I20200115-1800Lars Vogel4-6/+6
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: Ib14dc56626a541a2bace31952281cfbb6e0a9a00 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-14Bug 421303 - Potential deadlock in IOConsolePartitioner.streamAppendedPaul Pazderski2-3/+71
The deadlock requires that a separate thread is write large amounts of content rapidly to console and while doing this holds lock(s) with UI thread may require. An example is that both (UI and non-UI thread) write to console using the same IOConsoleOutputStream and therefore sharing the streams write lock. Change-Id: I5c72b60e765ec550928ba872f089494593475856 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-13Iterate over Map.entrySet instead of Map.keySet and value searchI20200114-1805Lars Vogel5-16/+24
Faster than first getting the keys and afterwards reading the value. Done with Autorefactor https://github.com/JnRouvignac/AutoRefactor/ batch conversion using the iterate over Map.entrySet instead of Map.keySet and value search Change-Id: I438796d7ce3abd35c5a8922559c582ef8685ed08 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Bug 559097 - Compile warnings in I20200113-0130Y20200114-0045I20200113-1800Paul Pazderski5-2/+6
Change-Id: I9dd25d7fe0d02a13f9cd3466756ada5a1b8a901f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-11Bug 559070 - Fix resource related compiler warnings in platform.debugPaul Pazderski9-27/+66
Change-Id: If9102e5fcd24e7888596fd33a14ed5529419acc2 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-10Use lambdas where possibleI20200113-0130I20200112-1800I20200111-1800I20200111-0325I20200111-0230I20200110-1805Lars Vogel7-131/+46
Using the batch cleanup operation via Source -> Cleanup -> "Use lambdas where possible" from standard JDT. Just a small number of changes files to make review easier. Change-Id: If684f937bd8e5f4fb2e72fc8a342ff03739ab367 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-10fixed plugin.xml example in javadoc that leads to warnings when copy&pastedChristian Dietrich1-2/+2
Change-Id: Ic134456ded541b2771601f6fe92b45ae2369d92c Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
2020-01-09Bug 558991 - Value column in Environment Variable table shows nameS4_15_0_M1I20200110-0905I20200110-0200I20200109-2350Andrew Obuchowicz1-1/+1
Change-Id: If8004aaceffc522c266dda3b503cb6bc4997ae74 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2020-01-06Remove trailing whitespace in debug repoY20200108-0435I20200108-2240I20200108-0600I20200108-0025I20200107-1800I20200107-0600I20200106-1805Lars Vogel26-40/+40
Change-Id: I845c923a09e0458fff1d960469da08404547de7f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-03Bug 558772 - [console] Remove obsolete code in IOConsolePartitionerI20200106-0600Paul Pazderski1-30/+1
The method applyStreamOutput can do the same as the removed code block. Change-Id: I090b45de41bae48376f87e0e5e67a2ff058df592 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-03Bug 558732 - Fix compile error 'closable should be managed byY20200103-2350I20200105-1800I20200105-0955I20200105-0600I20200104-1800I20200104-0625I20200104-0600I20200103-1800Paul Pazderski2-26/+28
try-with-resource' Change-Id: I82ad6831d4282e6626fd38f001ea12bd15335226 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-21Bug 558489 - [console] Remove unnecessary recoding in ProcessConsoleI20200102-1800I20200101-1800I20191231-1800I20191230-1800I20191229-2200I20191229-1800I20191228-1800I20191227-1800I20191226-1800I20191225-1800I20191224-1800I20191223-1800I20191222-1800I20191221-2205I20191221-1800Paul Pazderski8-82/+90
output handling Apart from removing an unnecessary string -> bytes -> string round trip it fix a potential content corruption since the source (TextConsole) encoding and target (IOConsoleOutputStream) encoding can differ. Also the stream listener implementation in ProcessConsole is simplified a lot and lost some dead code. Last but not least it replaced some usages of encoding names as strings with using the Charset class to reduce overall number of charset lookups. Change-Id: Ie94aa433e571a2f9898c950d2997f598618aca18 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-21Bug 552883 - Organize Favorites dialog too smallMichael Keppler1-1/+1
Enlarge dialog in both directions to deal with nowadays larger fonts. Change-Id: I5cf3428a3b4cfccf30723dfc595f5cb74e115e3a Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2019-12-20Bug 558403 - Use lambda API for LabelProviderAndrew Obuchowicz1-12/+4
Change-Id: I20dca496bd76d20f2714b3a3a479388d91c6a151 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-12-17Bug 553354 - Catch SecurityException if setting sysprop is forbiddenY20191217-0600I20191220-1805I20191219-1800I20191218-1805I20191218-0015I20191217-1800Sarika Sinha1-4/+17
A security manager might disallow setting of system properties. As there are no clients of that rely on this property in the platform, the combination of external clients together with a restrictive security manager is unlikely. When clients have a restrictive security manager there error log should not be polluted with error entries. Thus the potential SecurityException is silently ignored. Change-Id: I6cfa04cbed0537e7c92ad42284de56f81c77b97e Also-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-11Bug 553753 - [console] Provide stacktrace if partitioner stream closedI20191216-1805I20191215-1800I20191214-1800I20191213-1805Paul Pazderski1-1/+6
is called twice Change-Id: I7ce2f14e1dc14328d9bfdf7e7c126f47c5674ded Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-11Bug 553770 - Error when closing output stream of disposed MessageConsoleI20191213-0155I20191212-1800I20191211-1805Simeon Andreev2-4/+15
The fix for bug 551745 adds logging, in case an IOConsole stream is closed after all streams of the console are considered closed (e.g. on dispose()). For a MessageConsole, its possible to create a new MessageConsoleStream and close it after the MessageConsole is disposed. This will produce the new error log entry. This change adds any MessageConsoleStream created by MessageConsole.newMessageStream() to IOConsole.openStream, so that the streams created by MessageConsole are also correctly handled by IOConsole. Change-Id: I09156248fac6b6f63daab88b8881a197e7fe83fb Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2019-12-114.15 version update for org.eclipse.ui.consoleKarsten Thoms2-2/+2
Required for https://git.eclipse.org/r/#/c/153801/ Change-Id: I81a174b9401d1d1d1b8e9208522fda5824c3055a Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-10Use jdk 5 for-each loopI20191211-0135I20191210-1800chammer17-140/+93
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I41b3c365ba0817028550574834223d2d72569144 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer10-225/+169
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: Ic778a3ae3faac8009970f13a7f9f15f07d5d7b58 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer12-179/+142
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I776fe6cfac6df083601f714474d8561af657e7c5 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer19-114/+85
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I6bef6d52ae3ebad62598d6ab3ce74d00638d3d83 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer13-166/+106
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: Ibbb60232f6a15f80f8975ca5f9056104be5351ba Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Version updates for 4.15 streamKarsten Thoms10-10/+10
Required for - https://git.eclipse.org/r/#/c/152520/ - https://git.eclipse.org/r/#/c/152522/ - https://git.eclipse.org/r/#/c/152524/ - https://git.eclipse.org/r/#/c/152530/ - https://git.eclipse.org/r/#/c/152603/ Change-Id: I9d4adfecb5688da93ff737cb2daae83a2102c4bd Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-06Bug 553742 - POM and product version change for 4.15 releaseY20191208-2315I20191210-0230I20191209-2205I20191209-1600I20191209-1310I20191209-1130I20191209-1110Niraj Modi12-12/+12
Change-Id: Idaef2793bf1fa8aece6a02b2136b1fd09d344d73 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-11-26Bug 553461 - NPE in TextConsoleViewer.lineGetStyleY20191127-0140S4_14_0_RC2aS4_14_0_RC2S4_14_0_RC1R4_14I20191210-0610I20191204-1800I20191204-0600I20191203-1800I20191203-0600I20191202-1800I20191202-0600I20191201-1800I20191201-0600I20191130-1800I20191130-0600I20191129-1800I20191127-1800I20191127-0600I20191126-2315I20191126-1800Paul Pazderski3-4/+13
Change-Id: If5bc348ffc127ac097b34e25a6a835e9891c11ee Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-16Bug 76936 - [console] Handle \b and \r in console outputY20191126-0500I20191126-0600I20191125-1800I20191125-0600I20191124-1800I20191124-0600I20191123-1800I20191123-1115I20191123-0600I20191123-0100I20191122-1800I20191120-2335I20191120-1800I20191120-0840I20191120-0600I20191119-2200I20191119-1800I20191119-1250I20191119-1235I20191119-1215I20191119-1155I20191119-0850I20191119-0725I20191119-0510I20191119-0315I20191119-0020I20191118-2230I20191118-1800Paul Pazderski9-18/+692
Change-Id: Ia5e5b2760a0a9a097c003c41e3229e149003f22b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-16Bug 551745 - [console] Revise IOConsolePartitioner output appending andI20191118-0600Paul Pazderski3-242/+313
initialization Remove, rename or rework some fields and simplify how stream output is appended to document. (without losing existing functionality) Second try. This time with deadlock protection. Change-Id: I8d80ade8bb521895c97d6e08d2f520dd9b182a3b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-15Bug 511338 - Perform tooltip update in background threadI20191117-1800I20191117-0600I20191116-1800I20191116-0600I20191115-1800Karsten Thoms1-2/+7
The UI thread does not have to be blocked for the retrieval of the action's tooltip text. Using a CompletableFuture to retrieve the tooltip text and setting it for the action when done on the UI thread. Change-Id: I363c7ab642efd078de12cc08fe3cc3226793b4e9 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-11-15Bug 548841 - Mark internal package as x-internal in manifestPaul Pazderski3-1/+68
Change-Id: Id85473d37f23636a38325f1ced9f034a46bcd313 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-14Use jdk 5 for-each loopI20191114-1800chammer15-104/+70
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I87544aca0942d3b3a9ea40f9994f1a12c75a4f9e Signed-off-by: chammer <carsten.hammer@t-online.de>

Back to the top