Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-12-24Bug 577894 - Security Issue -- XXE AttackR4_16_maintenanceSarika Sinha1-4/+43
Applications using XMLMemento are vulnerable to XXE Attack see https://docs.oracle.com/en/java/javase/17/security/java-api-xml-processing-jaxp-security-guide.html Change-Id: I3f413123158ce2ff76ff250f84fe338520d0882e Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/187978 Reviewed-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com> Tested-by: Platform Bot <platform-bot@eclipse.org> (cherry picked from commit e81a54a076c159432d2e8b1c661d94a805516849) Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/188348 Tested-by: Sarika Sinha <sarika.sinha@in.ibm.com> Reviewed-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2021-12-24Bug 577894 - Backport Bug 577341 from 4.22 to 4.7Sarika Sinha2-3/+3
Change-Id: I6ab63d0feb6d48df5d922b1a7f424029040d4f48 Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189122 Tested-by: Sarika Sinha <sarika.sinha@in.ibm.com> Reviewed-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2020-05-20Bug 548430: [Cocoa] NullPointerException in Image.internal_new_GCY20200609-2100Y20200609-0150Y20200528-0030S4_16_0_RC2S4_16_0_RC1S4_16_0_M3R4_16I20200604-0540I20200603-0600I20200602-1800I20200602-0600I20200602-0510I20200602-0010I20200601-1800I20200601-0640I20200601-0140I20200531-1800I20200531-0600I20200530-0600I20200529-0550I20200528-0200I20200528-0000I20200527-1800I20200527-0600I20200526-1800I20200526-0600I20200525-1800I20200525-0640I20200524-1800I20200524-0850I20200524-0600I20200524-0220I20200523-1800I20200523-0600I20200522-1800I20200521-1000I20200520-1800I20200520-0600Matthias Becker1-0/+10
- There is an underlying assumption while creating breadcrumb arrows. The image creation logic assumes the new image created is always created with transparent color. Currently only the opaque areas are set with alpha 255, which is opaque. But the areas where transparency should be set is not handled at all. This patch sets transparent area with alpha 0, which is transparent. This change is based on https://git.eclipse.org/r/#/c/163181/ Change-Id: I371373a7d7e1825fb17032465ddbe4e31fb8c0db
2020-05-14Bug 563151 - NPE in DebugContextManager.createServiceI20200519-1800I20200519-1130I20200519-1010I20200518-2220I20200518-1800I20200516-0600I20200515-1930I20200514-1800Andrey Loskutov1-0/+4
Change-Id: Ie38807e6b637db51decf3151802c619d85bfc411 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-05-14Bug 563154 - Add tracing to DebugCommandServiceAndrey Loskutov6-6/+45
Change-Id: I9549ebac8e45d70f3141e45a20887ec5a15fbb55 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-05-13Bug 560630 - fixed compilation errors with new JDT buildI20200513-1800Andrey Loskutov1-2/+0
Change-Id: I612832aa2762916f4a41e3fbed5c98617273d9d7 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-05-12Bug 456304 - Import Breakpoints doesn't seem to support selectingI20200512-1800Sarika Sinha1-2/+92
multiple bookmarks at once Change-Id: Iaefced80efe41c1aef367c3a124b12f604c1de23
2020-05-11Bug 563041 - NPE in IOConsolePartitioner output appendingI20200511-1800Paul Pazderski1-3/+7
Unlikely but possible that after output appending job is started but before entering the synchronized block a partitioner disconnect happens and 'nulls' the document. Change-Id: I8be692b7f7374dfe8234e22571c1561f63e07c80 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-05-08Bug 562608 - Complete freeze of the UI while RCP debuggingI20200511-0700I20200510-1800I20200509-1800I20200509-0600I20200509-0450Sarika Sinha1-6/+3
Change-Id: I109630bf60b2026b04b1cba420a4b6017d6c97ff
2020-05-07Bug 562911 - Shorter debug perspective textLars Vogel1-1/+1
Change-Id: Ie9b4e9974bc93db200d8a7cb2fd3fa951000ae35 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-05-06Bug 562496: Hard to see icons for Variables view in dark themeI20200506-1800Matthias Becker42-0/+0
Change-Id: Ibc85709079eff3314492f6bed56f61982769ebf2
2020-05-01Bug 333239 - [console] Console redirection treats file name as regularI20200505-1800I20200504-1800I20200503-1800I20200502-1800Paul Pazderski3-19/+193
expression Change-Id: I8b475d001a6e0a626540d9aa93285fa918d4b21e Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-04-30Bug 562653 - an internal error occurred during: "Launching XXX Debug."Paul Pazderski3-8/+50
Some client code tries to create an internal class via a constructor which was recently changed and therefore breaks. Since it is trivial for us to keep the old constructor it was restored for the time being. Change-Id: Ic03b2a559a3387a20c03d8ba07c509875ec257b4 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-04-29Bug 562511 - [Dark Theme] Improve "Skip All Breakpoints" iconY20200430-0210Y20200429-0730I20200501-1800I20200501-0520I20200429-1800Karsten Thoms4-0/+0
Change-Id: I463d5db09b8b79e57c73007dd7d4dbe7fb1529d7 Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com> Signed-off-by: Matthias Becker <ma.becker@sap.com>
2020-04-27Bug 562456 - Show Command Line => Command Line could not be retrievedY20200428-2310Y20200428-0250Y20200428-0140Y20200427-2330I20200429-0600I20200428-2300I20200428-1800I20200428-0630I20200428-0610I20200428-0230I20200427-1800Sarika Sinha2-57/+72
Change-Id: Idf807f8684a3e444c03c6522b81252e70b7cb09b
2020-04-16Bug 562191 - External tools command line starts with superfluous blankI20200426-1800I20200425-1800I20200424-1800I20200424-0540I20200423-1800I20200422-1800I20200421-1800I20200420-1800I20200419-1800I20200418-1800I20200417-1800Michael Keppler3-3/+5
Remove the superfluous blank when creating the command line. Also bump version since this is the first change in core.externaltools for 4.16. Change-Id: Ib0243fc787d0d252aeb8be25c631d0cdb13c6dcb Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2020-04-10Bug 561983 - Remove dependnecy on icu from debug.[core|ui]I20200416-1800I20200416-0410I20200415-1800I20200415-0620I20200415-0200I20200414-1010I20200414-0630I20200413-1800I20200412-1800I20200411-1800I20200411-0950I20200411-0720I20200411-0510I20200411-0300I20200410-2300I20200410-1800Alexander Kurtakov65-132/+82
java.util classes are more than good for these bundle needs. Change-Id: Ia13b39e79d4058cdfa9b2b20cc1e7b41be4ba6f3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-04-10Bug 561919 - Remove com.ibm.icu.text from org.eclipse.ui.consoleLars Vogel3-3/+3
Change-Id: I0e5237a881efd90c67947ba56853a07c421de081 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-04-10Bump version for 4.16Alexander Kurtakov2-2/+2
Needed for https://git.eclipse.org/r/#/c/160657/ Change-Id: Ic0cf7bd36e359aea4bf0fd071ff5b85801e5bf2a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-03-29Bug 559180 - Suppress false potential resource leak warningS4_16_0_M1I20200409-0200I20200408-1800I20200408-0600I20200407-1800I20200407-1210I20200407-0120I20200406-1800I20200406-0600I20200406-0350I20200406-0120I20200405-1800I20200405-0600I20200404-1800I20200404-1220I20200404-0600I20200404-0330I20200403-1800I20200402-2250I20200402-1800I20200402-0850I20200402-0410I20200401-1800I20200331-1800I20200330-1800I20200329-1800Paul Pazderski2-0/+3
And add comment why it is no leak. Change-Id: I67364abc6f2c8cc607219946e8c9bad56f8d0fc6 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-03-26Bug 561451: Call wrong UI String for quick access label/headerI20200328-1800I20200327-1800Noopur Gupta2-4/+6
Change-Id: I87fe61f223677348cf45231e7339f1b7dc025c07
2020-03-24Bug 559180 - Close stream when NullStreamMonitor finishesI20200326-1800I20200325-1800I20200324-1800Paul Pazderski1-2/+2
Change-Id: Ifb13a0609c150d2ca1f87e43957068fcec8bb271 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-03-22Bug 561338 - Random IOOB on updating breadcrumb in Debug viewI20200323-1800Andrey Loskutov1-1/+8
Do not call into JFace with invalid index. Change-Id: I62cd885cb5fae2bc6e3ca540f1b691f9ce1e113d Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-03-20Remove unnecessary whitespace in LaunchFavoriteTestsI20200322-1800I20200322-1150I20200322-0300I20200321-1800I20200321-0440Lars Vogel1-1/+1
Change-Id: Ie6f8f66a92b6c8afbf3c1fd0a4667a0c4549f71a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-204.16 version bump for org.eclipse.debug.testsKarsten Thoms2-2/+2
Required for https://git.eclipse.org/r/#/c/159780/ Change-Id: Ifbe341df5329658ccadeadf4b73b31ea7d69e673 Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>
2020-03-19Clean-up use method references in debug coreI20200320-1800I20200319-1800I20200319-0550Lars Vogel4-114/+57
Using the JDT cleanup action -> Use lambda where possible Simplify lambda expression and method reference syntax Change-Id: I93d3cc199321c22e96e514d0f8c601fee0a147d4 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-19Clean-up use method references in debug external toolsLars Vogel4-70/+38
Using the JDT cleanup action -> Use lambda where possible Simplify lambda expression and method reference syntax Change-Id: I24c897659916e472b24d6a5c71c5660f2a00d0d9 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-19Version increment for org.eclipse.debug.coreKarsten Thoms2-2/+2
Required for https://git.eclipse.org/r/#/c/157581/ Change-Id: I08f0c3d6f07d9ddb3484c8b2950584862098be9f Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>
2020-03-174.16 update for org.eclipse.ui.externaltoolsI20200318-1800I20200318-1400Lars Vogel2-2/+2
Required for https://git.eclipse.org/r/157582 Change-Id: Ia2bd77b0fe4bcf511cb9f6b14729698afd1312da Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-14Bug 560348 - Wrong toolbar debug button state with two windowsI20200318-1100I20200317-1800I20200316-1800I20200315-2240I20200315-1800I20200314-1800Simeon Andreev1-2/+31
When debugging with 2 workbench windows, sometimes the main toolbar debug buttons enabled state is incorrect. E.g. step over would be disabled in 1 window, but not in the other window. This is caused by job cancellation in DebugCommandService.postUpdateCommand(). In particular, each window will schedule an AbstractDebugCommand.UpdateJob per debug command (suspend, resume, step over, etc.) and some of those jobs are cancelled by postUpdateCommand(). A cancelled job can contain the action to update for a specific window, in UpdateActionsRequest.fActions (stored in AbstractDebugCommand.UpdateJob.request). The cancellation does not take this into account, sometimes leading to wrong main toolbar debug button states in either window. This change disables the job cancellation if there are 2 or more workbench windows. In addition, the change moves cancellation to before new UpdateJobs are triggered. This avoids cases in which updates triggered by a custom debug context provider become cancelled, but newer updates only come much later on from the Debug view context provider. Change-Id: Ic9d4f87882982e745dfa4fb41f7ed0d856533566 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2020-03-14Version bump for 4.16 changes in org.eclipse.debug.uiAndrey Loskutov2-2/+2
Required for https://git.eclipse.org/r/#/c/158082/ Change-Id: I456255c21dab3c2cef33225b3b8a6716955cd8eb Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-03-06Bug 560872 - POM and product version change for 4.16 releaseY20200309-1300Y20200308-0700Y20200308-0520X20200313-0410X20200312-1900X20200312-1530X20200312-1210X20200312-0700X20200311-2150X20200311-1900X20200311-0820X20200306-1900I20200313-1800I20200313-0810I20200312-1835I20200312-1800I20200311-1800I20200310-1800I20200310-0810I20200309-1800I20200309-0810I20200308-1800I20200307-1800I20200307-1145Mat Booth12-12/+12
Change-Id: Ifcb7805f8c4c779f434dc85604d0b8c24ad08890 Signed-off-by: Mat Booth <mat.booth@redhat.com>
2020-02-24Bug 560274 - Race condition when updating debug toolbar button statesY20200318-0540Y20200317-0225Y20200316-1300Y20200316-0820Y20200314-1405Y20200313-1100Y20200311-0915Y20200310-0525Y20200305-0600Y20200225-1040X20200306-0700X20200305-1900X20200305-0700X20200304-1900X20200304-0700X20200303-1900X20200303-0700X20200302-1900X20200302-0930X20200302-0700X20200301-1900X20200301-0700X20200229-1900X20200229-0700X20200228-1900X20200228-0700X20200228-0520X20200227-1900X20200227-0700X20200227-0130X20200226-0700X20200225-1900X20200225-0700X20200224-1900X20200224-0700S4_15_0_RC2S4_15_0_RC1R4_15I20200305-0155I20200304-1800I20200304-0600I20200303-1800I20200303-0600I20200302-1800I20200302-0600I20200301-2310I20200301-1800I20200301-0600I20200301-0030I20200229-1800I20200229-0600I20200228-1800I20200226-1800I20200226-0600I20200225-1800I20200225-0600I20200224-1800I20200224-0600Simeon Andreev1-0/+28
This change adjusts the scheduling rule when updating toolbar command enablement via "org.eclipse.debug.internal.core.commands.ForEachCommand", e.g. the suspend toolbar enabled button state. The new rule is exclusive per command, as opposed to exclusive per selection type. I.e. before, debug target updates were exclusive, stack frame updates were exclusive, etc. Now, disconnect command updates are exclusive, suspend command updates are exclusive, etc. Change-Id: Ia22232b0a55c3aba429bc980ec5a26eb238afd44 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2020-02-22Bug 560353 - Sub-option "Interpret Carriage Return ..." must be indentedX20200223-1900X20200223-0700X20200223-0250I20200223-2335I20200223-1800I20200223-0600I20200222-1800Paul Pazderski1-1/+5
Change-Id: I8f464d6e0eae9afdc7ce6506243944680a341e5f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-20Bug 560352 - Migrate debug.tests to JUnit 4X20200222-0700X20200221-1130X20200221-0700I20200222-0600I20200221-1800Alexander Kurtakov68-866/+976
Change-Id: I63e3acd4d926282e5b2c92e63d01004376c108fc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-17Bug 251642 - [Tests] Fix race condition in testTerminateTimeStampY20200219-1055Y20200219-0850Y20200218-1420Y20200218-1210Y20200218-0315Y20200218-0120X20200221-0440X20200221-0310X20200221-0050X20200220-1900X20200220-0700X20200219-1900X20200219-0700X20200219-0500X20200218-0510X20200217-1120S4_15_0_M3I20200219-1800I20200219-0600I20200218-1800I20200218-0600I20200217-1800Paul Pazderski1-0/+29
Process termination is recognized in a separate thread. Looking for termination timestamp without waiting for termination is a bad idea. Change-Id: I2fe934b898b689a7cfba9e2eaec4676bd97103cd Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-17Bug 251642 - [console] Shorten terminate timestamp for same dayPaul Pazderski1-9/+29
If process started and terminated at same day (the most common case for process run in IDE) do not show the day part twice. Change-Id: I6b080af23b44b3bd6db5d6301794705fb5359c56 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-16Bug 251642 - Store termination timestamp as launch and process attributeI20200217-0600I20200216-1800Paul Pazderski14-49/+191
Also show termination time in process property dialog and process console label and set launch time as process attribute for external tool launches. Change-Id: I052d280d16d8ad42d70992b0a57324a9ce2e4963 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-15Bug 345435 - [console] EOF Ctrl+Z keybinding doesn't work with twoPaul Pazderski1-10/+17
consoles up Change-Id: I1e45eb5450887c9107e1cb46b3f3894e5443d85c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-12Bug 550195 - Reduce wait time in runtime process terminationI20200216-1145I20200215-1800I20200215-0600I20200214-1800I20200214-0620I20200213-1800I20200213-1520I20200213-1210I20200213-1100I20200213-0640I20200212-1810I20200212-1800Paul Pazderski4-5/+147
Java 8 added a waitFor method with timeout for the Process class. Using this instead of the plain Thread.sleep can reduce waiting time in some situations from 500 ms down to 10 ms. For the case that Process is not a native process and has no optimized waitFor implementation the situation still improves since the terminated check is performed every 100 ms instead every 500 ms. Change-Id: I0fc54981b53615fbae14d46a6c82a9b85d64b035 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-02-11Clean-up use lambdas and method references in ui.consoleI20200212-1420Lars Vogel3-49/+24
Using the JDT cleanup action -> - Use lambda where possible - Simplify lambda expression and method reference syntax Change-Id: Icdce7db08c100cf4eda0e9ebabf20afbe64ba36f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-02-05Bug 559814 - Shorter text for remove dialogsI20200212-0910I20200211-1800I20200210-1800I20200209-1800I20200208-1800I20200207-1800I20200206-1805I20200205-1800Lars Vogel2-5/+5
Change-Id: Ic8eb6641bce888366ac1971852a5fd3035b71099 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-02-04Use method reference instead of lambdasI20200205-0030I20200204-1800Lars Vogel3-4/+4
Method references are slightly faster than lambdas and better readable. Change-Id: I1eb012c76a425358503f171d291d6abe9a45d219 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-31Bug 559590 - "Custom" debug view is not considered inY20200204-0035I20200203-1800I20200202-1800Andrey Loskutov1-3/+12
SourceLookupService.debugContextChanged Check if the view part provided by the DebugContextProvider is shown, if the DebugContextProvider for given DebugContextEvent specifies its own part. This part is not necessarily the default Debug view. If this is the case, we also want to proceed with displaySource(). Change-Id: I1b86b3d2224c8532ddf23b4d423f211267ff3106 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-01-22Bug 553282 - [console] Handle \f and \v in console outputY20200130-0045Y20200127-1055Y20200126-2245I20200201-1800I20200131-1800I20200130-1800I20200129-1800I20200129-0935I20200129-0100I20200128-1805I20200127-1800I20200126-1800I20200126-0250I20200125-1805I20200124-1800I20200123-1800I20200123-0525I20200123-0430I20200122-1805Paul Pazderski3-14/+96
Change-Id: I8c86ad1116aa12c59ec4cbfbf2662e484c55c1c4 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-22Bug 553282 - Extract code to partition newly appended outputPaul Pazderski1-276/+309
This change is pure refactoring to simplify the diff of the actual enhancement from bug 553282. Change-Id: I36d531e9c2872b68608b8b54343220a558e4f5e7 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-20Use ArrayList instead of VectorY20200121-0055Y20200120-2315I20200121-2225I20200121-1805I20200120-1800I20200120-0715Lars Vogel2-4/+3
Vector is an outdated data structure and ArrayList should be preferred as it is faster. Change-Id: I93106bc75dfd76b9118ae607c0504efacd91ce3f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-20Use ArrayDeque in StringSubstitutionEngine instead of StackLars Vogel1-3/+4
Change-Id: I65b227abde82a39cde30834960344c9930663d20 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-204.15 update of org.eclipse.core.variablesLars Vogel2-2/+2
Required for https://git.eclipse.org/r/156114 Change-Id: Ia574a2d2941289c2cbc2cb733593d92dc194773f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-17Bug 365770 - Race condition in IOConsolePartitioner causes consoleY20200120-0020I20200120-0530I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800Paul Pazderski3-46/+95
output to be lost or not cleared Due to the race condition when calling outStream.print("First"); console.clearConsole(); outStream.print("Second"); from a single thread the actual console content could be "FirstSecond" or "" where only "Second" is correct. Change-Id: Ifeaed46e11652c53297c1aac3ff4fa1dd07e401b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>

Back to the top