Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-07-14Bug 565208: Remove calls to Color.disposeY20200729-1200Y20200729-0630Y20200728-0600Y20200727-0310Y20200725-1200Y20200722-1200Y20200722-0040Y20200721-0610Y20200721-0450Y20200718-1200I20200731-0520I20200730-1800I20200729-1800I20200729-0120I20200728-1800I20200728-1120I20200727-1800I20200726-1800I20200724-1800I20200724-0600I20200723-1800I20200723-1030I20200723-0620I20200722-1800I20200722-1140I20200722-0610I20200721-1800I20200721-1400I20200721-0950I20200721-0610I20200721-0130I20200720-1800I20200720-0850I20200720-0020I20200719-2010I20200718-1800I20200717-1800Lars Vogel1-17/+0
As these calls are no longer needed, remove the calls and related code around such dispose that is also now redundant. Change-Id: I8e2e690bc54f02321a761136cd2fe904025e6662
2020-07-01Bug 564849 - [Tests] Fix unstable JUnit testsY20200716-0820Y20200715-1200Y20200711-1200Y20200708-1200Y20200704-1200S4_17_0_M1I20200716-1800I20200715-1800I20200714-1800I20200713-2230I20200713-1800I20200712-1800I20200711-2250I20200711-1800I20200710-1800I20200710-0230I20200708-1800I20200708-0600I20200707-1800I20200707-0600I20200706-2300I20200706-1800I20200706-0600I20200705-1800I20200705-0710I20200705-0600I20200704-1800I20200704-0600I20200703-1800Paul Pazderski3-15/+29
OutputStreamMonitorTests Two of the tests are explicit written for UTF-8 but the monitor is initialized with default charset. Since many modern systems use UTF-8 as default the test still works most of the times. InputStreamMonitorTests The closing test stops the input monitoring thread and immediately checks if the thread is stopped. I saw a few random test failures locally from this race condition. BreakpointTests Calling dispose on a view is not the right way to close the view. Change-Id: I4e01475032dc5dd69810eedc467ba1ff3efb2ef3 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-30Bug 306131 - [console] Null byte to stdout results in truncation of lineY20200703-0300Y20200701-1200Y20200701-0020I20200702-2150I20200702-1800I20200701-2350I20200701-2210I20200701-1800I20200701-0330I20200630-1800Paul Pazderski2-2/+30
If interpretation of ASCII control characters is enabled handle null bytes (\0) by simply filtering them out. This is useful because null bytes can truncate console lines on some platforms and brings unexpected results on copy text on most platforms. Change-Id: Ic6a46c3eba4582c8f54fcd6735b8763738d47623 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-30Bug 563752 - [console] FileLink with offset need line number which isPaul Pazderski3-14/+164
ignored FileLink can be created with offset+length or line number to be selected once the link is activated. All of those position parameters are optional and there is no reason to specify offset+length and line number on the same link. However before this commit the offset+length was ignored if no line number >= 0 was given. Change-Id: Iaf105bc25acaec064763ebe60abf7cdcc409b58c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-30Bug 81461 - [console] needs key to clearPaul Pazderski3-13/+51
Does not include a default key binding. Change-Id: I93361fa760ba7c72e83da39abee10dfbb6e35abb Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-29Bug 404990 - [breakpoints] Delete breakpoint, undo, redo, undo. Gone.Paul Pazderski10-125/+356
The issue is located in both, the redo and the second undo operation. Delete breakpoint and redo of this operation have the (for this issue relevant) difference that the first set a 'breakpoint deleted' attribute on the marker while the redo does not set/update this attribute. The simple fix is to move the "mark deleted" into the delete marker operation which is executed from an 'initial' delete as well as from a redo. After fixing that a breakpoint is restored but the view does not updated. BreakpointManager does not properly send added notifications. Most of the time it works because an added breakpoint will be registered and the registration will trigger the added notification. However for the add of the second undo the registered attribute is already set, the setRegister(true) which normally triggers the add notification is not executed. Change-Id: Ib509ec9c8116ac4a7bb3f8bcf38dc470e0b90b8b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-27Bug 558463 - [console] Console redirection changes contentY20200629-1000Y20200629-0740I20200629-1800I20200628-1800Paul Pazderski25-269/+1258
Unfortunately all the existing streams monitoring/proxying/redirection or basically most of the console IO stack is based upon strings. If a program produce 'random' binary output and user configures console to redirect the output to a file it might still be changed due to the (until now) unavoidable string decoding. Keeping existing API and not breaking clients made this change in some parts more complex than it could be. Change-Id: Id8e8fa1f777f06220af86dd4f026873c6b0b2d7b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-22Bug 564429 - VirtualCopyToClipboardActionDelegate: Add TAB even forY20200624-1200Y20200622-0340I20200626-1800I20200625-1800I20200624-1800I20200623-1800I20200623-1010I20200622-1800Sebastian Ratz1-1/+2
empty value Change-Id: Ib6e954cd6671b50ced75ef757a3cf49c882fe594
2020-06-18Bug 564330 - Lambda and method cleanup on o.e.debug.ui plug-inY20200620-1200I20200621-1800I20200620-1800I20200619-1800I20200618-1800Lars Vogel50-992/+530
Running the JDT batch cleanup for lambdas and method reference showed still some places where they can be used. As we received lots of cleanups in this area, I think it is good to finish this. Change-Id: I560d28b914c67387a83f600bba12a920f7d69dc7 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-17Bug 564330 - Lambda and method cleanup on o.e.debug.examples.core plug-inLars Vogel2-25/+16
Running the JDT batch cleanup for lambdas and method reference showed still some places where they can be used. As we received lots of cleanups in this area, I think it is good to finish this. Change-Id: I15d68377f660b84439fbe7cec108d9ac79cd4aff Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-164.17 update for org.eclipse.debug.examples.coreY20200617-2350Y20200617-1200Y20200617-1040Y20200617-0510Y20200617-0320I20200617-1800I20200616-1800Lars Vogel2-2/+2
For https://git.eclipse.org/r/#/c/164885/ Change-Id: Ice0e5bf347acf2c0db7fcf8c02b954c7e7eebb32
2020-06-16Using lambdas in BreakpointOrganizerManager.javaI20200616-0620Lars Vogel1-13/+3
This allows to remove a cast as the types are inferred. Change-Id: Ia454fa87f24c91feb03ee7d97956bd7991fe91ea Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-15Bug 563873 - replaced synchronous layout() callsI20200616-0320I20200616-0140Julian Honnen1-4/+6
Speed up selection of launch configurations by replacing synchronous layout() calls with requestLayout(). The change reduces the number of Tree::computeSizeInPixels calls when switching between two eclipse launch configs from 55(!) to 6. With a large plugins tree (~2000 items), this saves ~30% time. Change-Id: Iabde07f2281331009ee2cdaf435dc0a4f39242e9 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2020-06-12Use lambdas and method references in ui.externaltoolsI20200615-1800I20200614-1800I20200613-1800I20200612-1800I20200612-0650Lars Vogel1-1/+1
JDT cleanup batch cleanup Change-Id: I65415fbb8bb85d3af8f40cac16072bd96940bc6b
2020-06-124.17 update of org.eclipse.ui.externaltoolsLars Vogel2-2/+2
For https://git.eclipse.org/r/#/c/164735/ Change-Id: Ia89434885099bc117134eb30d86fe20270e3ded6
2020-06-12[Bug 550832] Remove gif which we left during the move to png filesLars Vogel9-0/+0
Change-Id: I33f6ffedc639d62fb14b12fc3929e63ee39b81cc Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-12[Bug 550832] Remove gif which we left during the move to png filesLars Vogel3-0/+0
Change-Id: I8db69f1c50f69934e1946e7900c6d6d34b8d2375 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-12Bug 551568 - add children to delegatesI20200612-0400Carsten Hammer1-9/+4
Change-Id: Ib911d62c6a4e066b0e15a924c778b1d64b39ceb3 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2020-06-11Use lambdas and method references in ui.consoleLars Vogel1-1/+1
JDT cleanup batch cleanup Change-Id: I6a6af8501d362dd5e425c782bce2c378601c3350
2020-06-114.17 update of org.eclipse.ui.consoleI20200611-1800Lars Vogel2-2/+2
For https://git.eclipse.org/r/164734 Change-Id: Ic0af7c457ebf3b9d90ca0decc07fcd8dd2d318e8
2020-06-10Bug 564063 - AbstractDebugSelectionDialog can use ↵Lars Vogel1-1/+1
ArrayContentProvider.getInstance() ArrayContentProvider does not hold any data, so sharing the instance is fine. Change-Id: Ica87c3baf7cbdaa3c88ea2a7142cac1b679e2fa3 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-10Bug 564117 - Using lazy logical operatorI20200610-1800Lars Vogel7-9/+9
Use lazy logical operator (&& and ||) as it is potentially faster. Change-Id: I73f4bae34305b349af92986f4c9b845b6a4d241a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-09Bug 563505 - [Javadoc] Extension point example in IBreakpoint is wrongI20200609-1800Paul Pazderski1-5/+5
Change-Id: I74f53e44dc8f3e9206d711502e54d41829f9e14e Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-09Bug 344352 - [breakpoints] Error dialog when deleting a working setPaul Pazderski1-0/+7
In fact there is no issue with deleting working set but a regular user is most likely seeing this unnecessary error message from that action. Deleting working set give the option to remove the working set, all containing breakpoints or both. If removing breakpoints is unselected it will still perform a remove operation for zero markers and the standard remove-marker-operation will produce an error dialog because there are no markers to delete. Change-Id: If08c5f930bbdbf0236dd8a20af3f43b60b77d427 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-09Remove random System.out.println() in BreakpointsViewPaul Pazderski1-1/+0
Change-Id: I18c812e9f05d8f7a02e34e13daac8f2126ed0bfc Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-06-07Removes unnecessary whitespace in platform.debug which sneaked inI20200609-0150I20200608-1800I20200607-1800Lars Vogel2-2/+2
Change-Id: I2933d1a8ddf4d2a2acfb1c4d95ac5058b3099022 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-074.17 update of org.eclipse.debug.coreLars Vogel2-2/+2
Required for https://git.eclipse.org/r/#/c/164283 Change-Id: I7c8e1c82bc1f70d7ec9cf7486a6475f30ea1e32d
2020-06-07Using ArrayContentProvider.getInstance() instead of new instanceLars Vogel3-3/+3
ArrayContentProvider does not hold any data, hence it can be shared across instances. Change-Id: Ib12140bfad3bcec6596640a0227400520e9b20f1 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-074.17 update of org.eclipse.debug.uiLars Vogel2-2/+2
Required for https://git.eclipse.org/r/#/c/164283 Change-Id: I16ac71afd1a8fa7d705d15667581f1e77086d668 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-06-04Bug 563840 - POM and product version change for 4.17 releaseI20200606-1800I20200606-0940I20200606-0910I20200606-0700I20200606-0400I20200606-0050I20200605-2140I20200605-1500I20200605-1230I20200605-1200I20200605-1150I20200605-0950I20200605-0910I20200605-0720Sravan Kumar Lakkimsetti12-12/+12
Change-Id: I1bfac7ee8f58d204e62028bbac0cd7e25051520d Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2020-05-20Bug 548430: [Cocoa] NullPointerException in Image.internal_new_GCY20200609-2100Y20200609-0150Y20200528-0030S4_16_0_RC2S4_16_0_RC1S4_16_0_M3R4_16I20200604-0540I20200603-0600I20200602-1800I20200602-0600I20200602-0510I20200602-0010I20200601-1800I20200601-0640I20200601-0140I20200531-1800I20200531-0600I20200530-0600I20200529-0550I20200528-0200I20200528-0000I20200527-1800I20200527-0600I20200526-1800I20200526-0600I20200525-1800I20200525-0640I20200524-1800I20200524-0850I20200524-0600I20200524-0220I20200523-1800I20200523-0600I20200522-1800I20200521-1000I20200520-1800I20200520-0600Matthias Becker1-0/+10
- There is an underlying assumption while creating breadcrumb arrows. The image creation logic assumes the new image created is always created with transparent color. Currently only the opaque areas are set with alpha 255, which is opaque. But the areas where transparency should be set is not handled at all. This patch sets transparent area with alpha 0, which is transparent. This change is based on https://git.eclipse.org/r/#/c/163181/ Change-Id: I371373a7d7e1825fb17032465ddbe4e31fb8c0db
2020-05-14Bug 563151 - NPE in DebugContextManager.createServiceI20200519-1800I20200519-1130I20200519-1010I20200518-2220I20200518-1800I20200516-0600I20200515-1930I20200514-1800Andrey Loskutov1-0/+4
Change-Id: Ie38807e6b637db51decf3151802c619d85bfc411 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-05-14Bug 563154 - Add tracing to DebugCommandServiceAndrey Loskutov6-6/+45
Change-Id: I9549ebac8e45d70f3141e45a20887ec5a15fbb55 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-05-13Bug 560630 - fixed compilation errors with new JDT buildI20200513-1800Andrey Loskutov1-2/+0
Change-Id: I612832aa2762916f4a41e3fbed5c98617273d9d7 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-05-12Bug 456304 - Import Breakpoints doesn't seem to support selectingI20200512-1800Sarika Sinha1-2/+92
multiple bookmarks at once Change-Id: Iaefced80efe41c1aef367c3a124b12f604c1de23
2020-05-11Bug 563041 - NPE in IOConsolePartitioner output appendingI20200511-1800Paul Pazderski1-3/+7
Unlikely but possible that after output appending job is started but before entering the synchronized block a partitioner disconnect happens and 'nulls' the document. Change-Id: I8be692b7f7374dfe8234e22571c1561f63e07c80 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-05-08Bug 562608 - Complete freeze of the UI while RCP debuggingI20200511-0700I20200510-1800I20200509-1800I20200509-0600I20200509-0450Sarika Sinha1-6/+3
Change-Id: I109630bf60b2026b04b1cba420a4b6017d6c97ff
2020-05-07Bug 562911 - Shorter debug perspective textLars Vogel1-1/+1
Change-Id: Ie9b4e9974bc93db200d8a7cb2fd3fa951000ae35 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-05-06Bug 562496: Hard to see icons for Variables view in dark themeI20200506-1800Matthias Becker42-0/+0
Change-Id: Ibc85709079eff3314492f6bed56f61982769ebf2
2020-05-01Bug 333239 - [console] Console redirection treats file name as regularI20200505-1800I20200504-1800I20200503-1800I20200502-1800Paul Pazderski3-19/+193
expression Change-Id: I8b475d001a6e0a626540d9aa93285fa918d4b21e Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-04-30Bug 562653 - an internal error occurred during: "Launching XXX Debug."Paul Pazderski3-8/+50
Some client code tries to create an internal class via a constructor which was recently changed and therefore breaks. Since it is trivial for us to keep the old constructor it was restored for the time being. Change-Id: Ic03b2a559a3387a20c03d8ba07c509875ec257b4 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-04-29Bug 562511 - [Dark Theme] Improve "Skip All Breakpoints" iconY20200430-0210Y20200429-0730I20200501-1800I20200501-0520I20200429-1800Karsten Thoms4-0/+0
Change-Id: I463d5db09b8b79e57c73007dd7d4dbe7fb1529d7 Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com> Signed-off-by: Matthias Becker <ma.becker@sap.com>
2020-04-27Bug 562456 - Show Command Line => Command Line could not be retrievedY20200428-2310Y20200428-0250Y20200428-0140Y20200427-2330I20200429-0600I20200428-2300I20200428-1800I20200428-0630I20200428-0610I20200428-0230I20200427-1800Sarika Sinha2-57/+72
Change-Id: Idf807f8684a3e444c03c6522b81252e70b7cb09b
2020-04-16Bug 562191 - External tools command line starts with superfluous blankI20200426-1800I20200425-1800I20200424-1800I20200424-0540I20200423-1800I20200422-1800I20200421-1800I20200420-1800I20200419-1800I20200418-1800I20200417-1800Michael Keppler3-3/+5
Remove the superfluous blank when creating the command line. Also bump version since this is the first change in core.externaltools for 4.16. Change-Id: Ib0243fc787d0d252aeb8be25c631d0cdb13c6dcb Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2020-04-10Bug 561983 - Remove dependnecy on icu from debug.[core|ui]I20200416-1800I20200416-0410I20200415-1800I20200415-0620I20200415-0200I20200414-1010I20200414-0630I20200413-1800I20200412-1800I20200411-1800I20200411-0950I20200411-0720I20200411-0510I20200411-0300I20200410-2300I20200410-1800Alexander Kurtakov65-132/+82
java.util classes are more than good for these bundle needs. Change-Id: Ia13b39e79d4058cdfa9b2b20cc1e7b41be4ba6f3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-04-10Bug 561919 - Remove com.ibm.icu.text from org.eclipse.ui.consoleLars Vogel3-3/+3
Change-Id: I0e5237a881efd90c67947ba56853a07c421de081 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-04-10Bump version for 4.16Alexander Kurtakov2-2/+2
Needed for https://git.eclipse.org/r/#/c/160657/ Change-Id: Ic0cf7bd36e359aea4bf0fd071ff5b85801e5bf2a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-03-29Bug 559180 - Suppress false potential resource leak warningS4_16_0_M1I20200409-0200I20200408-1800I20200408-0600I20200407-1800I20200407-1210I20200407-0120I20200406-1800I20200406-0600I20200406-0350I20200406-0120I20200405-1800I20200405-0600I20200404-1800I20200404-1220I20200404-0600I20200404-0330I20200403-1800I20200402-2250I20200402-1800I20200402-0850I20200402-0410I20200401-1800I20200331-1800I20200330-1800I20200329-1800Paul Pazderski2-0/+3
And add comment why it is no leak. Change-Id: I67364abc6f2c8cc607219946e8c9bad56f8d0fc6 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-03-26Bug 561451: Call wrong UI String for quick access label/headerI20200328-1800I20200327-1800Noopur Gupta2-4/+6
Change-Id: I87fe61f223677348cf45231e7339f1b7dc025c07
2020-03-24Bug 559180 - Close stream when NullStreamMonitor finishesI20200326-1800I20200325-1800I20200324-1800Paul Pazderski1-2/+2
Change-Id: Ifb13a0609c150d2ca1f87e43957068fcec8bb271 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>

Back to the top