Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-01-17Bug 365770 - Race condition in IOConsolePartitioner causes consoleY20200120-0020I20200120-0530I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800Paul Pazderski3-46/+95
output to be lost or not cleared Due to the race condition when calling outStream.print("First"); console.clearConsole(); outStream.print("Second"); from a single thread the actual console content could be "FirstSecond" or "" where only "Second" is correct. Change-Id: Ifeaed46e11652c53297c1aac3ff4fa1dd07e401b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-17Bug 229202 - [console] Open link in console context menu gets disabledPaul Pazderski2-11/+9
when activating Consequence was that context menu showed an active menu entry to open link but nothing was opened/executed. Change-Id: Ia2db5fe2caf3f7de9735e99732c691ba9c163e85
2020-01-15Use System.lineSeparator()I20200116-1800I20200116-0930I20200116-0330I20200116-0310I20200115-1800Lars Vogel4-6/+6
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: Ib14dc56626a541a2bace31952281cfbb6e0a9a00 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-14Bug 421303 - Potential deadlock in IOConsolePartitioner.streamAppendedPaul Pazderski2-3/+71
The deadlock requires that a separate thread is write large amounts of content rapidly to console and while doing this holds lock(s) with UI thread may require. An example is that both (UI and non-UI thread) write to console using the same IOConsoleOutputStream and therefore sharing the streams write lock. Change-Id: I5c72b60e765ec550928ba872f089494593475856 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-13Iterate over Map.entrySet instead of Map.keySet and value searchI20200114-1805Lars Vogel5-16/+24
Faster than first getting the keys and afterwards reading the value. Done with Autorefactor https://github.com/JnRouvignac/AutoRefactor/ batch conversion using the iterate over Map.entrySet instead of Map.keySet and value search Change-Id: I438796d7ce3abd35c5a8922559c582ef8685ed08 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Bug 559097 - Compile warnings in I20200113-0130Y20200114-0045I20200113-1800Paul Pazderski5-2/+6
Change-Id: I9dd25d7fe0d02a13f9cd3466756ada5a1b8a901f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-11Bug 559070 - Fix resource related compiler warnings in platform.debugPaul Pazderski9-27/+66
Change-Id: If9102e5fcd24e7888596fd33a14ed5529419acc2 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-10Use lambdas where possibleI20200113-0130I20200112-1800I20200111-1800I20200111-0325I20200111-0230I20200110-1805Lars Vogel7-131/+46
Using the batch cleanup operation via Source -> Cleanup -> "Use lambdas where possible" from standard JDT. Just a small number of changes files to make review easier. Change-Id: If684f937bd8e5f4fb2e72fc8a342ff03739ab367 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-10fixed plugin.xml example in javadoc that leads to warnings when copy&pastedChristian Dietrich1-2/+2
Change-Id: Ic134456ded541b2771601f6fe92b45ae2369d92c Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
2020-01-09Bug 558991 - Value column in Environment Variable table shows nameS4_15_0_M1I20200110-0905I20200110-0200I20200109-2350Andrew Obuchowicz1-1/+1
Change-Id: If8004aaceffc522c266dda3b503cb6bc4997ae74 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2020-01-06Remove trailing whitespace in debug repoY20200108-0435I20200108-2240I20200108-0600I20200108-0025I20200107-1800I20200107-0600I20200106-1805Lars Vogel26-40/+40
Change-Id: I845c923a09e0458fff1d960469da08404547de7f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-03Bug 558772 - [console] Remove obsolete code in IOConsolePartitionerI20200106-0600Paul Pazderski1-30/+1
The method applyStreamOutput can do the same as the removed code block. Change-Id: I090b45de41bae48376f87e0e5e67a2ff058df592 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-03Bug 558732 - Fix compile error 'closable should be managed byY20200103-2350I20200105-1800I20200105-0955I20200105-0600I20200104-1800I20200104-0625I20200104-0600I20200103-1800Paul Pazderski2-26/+28
try-with-resource' Change-Id: I82ad6831d4282e6626fd38f001ea12bd15335226 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-21Bug 558489 - [console] Remove unnecessary recoding in ProcessConsoleI20200102-1800I20200101-1800I20191231-1800I20191230-1800I20191229-2200I20191229-1800I20191228-1800I20191227-1800I20191226-1800I20191225-1800I20191224-1800I20191223-1800I20191222-1800I20191221-2205I20191221-1800Paul Pazderski8-82/+90
output handling Apart from removing an unnecessary string -> bytes -> string round trip it fix a potential content corruption since the source (TextConsole) encoding and target (IOConsoleOutputStream) encoding can differ. Also the stream listener implementation in ProcessConsole is simplified a lot and lost some dead code. Last but not least it replaced some usages of encoding names as strings with using the Charset class to reduce overall number of charset lookups. Change-Id: Ie94aa433e571a2f9898c950d2997f598618aca18 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-21Bug 552883 - Organize Favorites dialog too smallMichael Keppler1-1/+1
Enlarge dialog in both directions to deal with nowadays larger fonts. Change-Id: I5cf3428a3b4cfccf30723dfc595f5cb74e115e3a Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2019-12-20Bug 558403 - Use lambda API for LabelProviderAndrew Obuchowicz1-12/+4
Change-Id: I20dca496bd76d20f2714b3a3a479388d91c6a151 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-12-17Bug 553354 - Catch SecurityException if setting sysprop is forbiddenY20191217-0600I20191220-1805I20191219-1800I20191218-1805I20191218-0015I20191217-1800Sarika Sinha1-4/+17
A security manager might disallow setting of system properties. As there are no clients of that rely on this property in the platform, the combination of external clients together with a restrictive security manager is unlikely. When clients have a restrictive security manager there error log should not be polluted with error entries. Thus the potential SecurityException is silently ignored. Change-Id: I6cfa04cbed0537e7c92ad42284de56f81c77b97e Also-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-11Bug 553753 - [console] Provide stacktrace if partitioner stream closedI20191216-1805I20191215-1800I20191214-1800I20191213-1805Paul Pazderski1-1/+6
is called twice Change-Id: I7ce2f14e1dc14328d9bfdf7e7c126f47c5674ded Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-11Bug 553770 - Error when closing output stream of disposed MessageConsoleI20191213-0155I20191212-1800I20191211-1805Simeon Andreev2-4/+15
The fix for bug 551745 adds logging, in case an IOConsole stream is closed after all streams of the console are considered closed (e.g. on dispose()). For a MessageConsole, its possible to create a new MessageConsoleStream and close it after the MessageConsole is disposed. This will produce the new error log entry. This change adds any MessageConsoleStream created by MessageConsole.newMessageStream() to IOConsole.openStream, so that the streams created by MessageConsole are also correctly handled by IOConsole. Change-Id: I09156248fac6b6f63daab88b8881a197e7fe83fb Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2019-12-114.15 version update for org.eclipse.ui.consoleKarsten Thoms2-2/+2
Required for https://git.eclipse.org/r/#/c/153801/ Change-Id: I81a174b9401d1d1d1b8e9208522fda5824c3055a Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-10Use jdk 5 for-each loopI20191211-0135I20191210-1800chammer17-140/+93
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I41b3c365ba0817028550574834223d2d72569144 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer10-225/+169
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: Ic778a3ae3faac8009970f13a7f9f15f07d5d7b58 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer12-179/+142
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I776fe6cfac6df083601f714474d8561af657e7c5 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer19-114/+85
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I6bef6d52ae3ebad62598d6ab3ce74d00638d3d83 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Use jdk 5 for-each loopchammer13-166/+106
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: Ibbb60232f6a15f80f8975ca5f9056104be5351ba Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-12-10Version updates for 4.15 streamKarsten Thoms10-10/+10
Required for - https://git.eclipse.org/r/#/c/152520/ - https://git.eclipse.org/r/#/c/152522/ - https://git.eclipse.org/r/#/c/152524/ - https://git.eclipse.org/r/#/c/152530/ - https://git.eclipse.org/r/#/c/152603/ Change-Id: I9d4adfecb5688da93ff737cb2daae83a2102c4bd Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-06Bug 553742 - POM and product version change for 4.15 releaseY20191208-2315I20191210-0230I20191209-2205I20191209-1600I20191209-1310I20191209-1130I20191209-1110Niraj Modi12-12/+12
Change-Id: Idaef2793bf1fa8aece6a02b2136b1fd09d344d73 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-11-26Bug 553461 - NPE in TextConsoleViewer.lineGetStyleY20191127-0140S4_14_0_RC2aS4_14_0_RC2S4_14_0_RC1R4_14I20191210-0610I20191204-1800I20191204-0600I20191203-1800I20191203-0600I20191202-1800I20191202-0600I20191201-1800I20191201-0600I20191130-1800I20191130-0600I20191129-1800I20191127-1800I20191127-0600I20191126-2315I20191126-1800Paul Pazderski3-4/+13
Change-Id: If5bc348ffc127ac097b34e25a6a835e9891c11ee Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-16Bug 76936 - [console] Handle \b and \r in console outputY20191126-0500I20191126-0600I20191125-1800I20191125-0600I20191124-1800I20191124-0600I20191123-1800I20191123-1115I20191123-0600I20191123-0100I20191122-1800I20191120-2335I20191120-1800I20191120-0840I20191120-0600I20191119-2200I20191119-1800I20191119-1250I20191119-1235I20191119-1215I20191119-1155I20191119-0850I20191119-0725I20191119-0510I20191119-0315I20191119-0020I20191118-2230I20191118-1800Paul Pazderski9-18/+692
Change-Id: Ia5e5b2760a0a9a097c003c41e3229e149003f22b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-16Bug 551745 - [console] Revise IOConsolePartitioner output appending andI20191118-0600Paul Pazderski3-242/+313
initialization Remove, rename or rework some fields and simplify how stream output is appended to document. (without losing existing functionality) Second try. This time with deadlock protection. Change-Id: I8d80ade8bb521895c97d6e08d2f520dd9b182a3b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-15Bug 511338 - Perform tooltip update in background threadI20191117-1800I20191117-0600I20191116-1800I20191116-0600I20191115-1800Karsten Thoms1-2/+7
The UI thread does not have to be blocked for the retrieval of the action's tooltip text. Using a CompletableFuture to retrieve the tooltip text and setting it for the action when done on the UI thread. Change-Id: I363c7ab642efd078de12cc08fe3cc3226793b4e9 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-11-15Bug 548841 - Mark internal package as x-internal in manifestPaul Pazderski3-1/+68
Change-Id: Id85473d37f23636a38325f1ced9f034a46bcd313 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-14Use jdk 5 for-each loopI20191114-1800chammer15-104/+70
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I87544aca0942d3b3a9ea40f9994f1a12c75a4f9e Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-11-14Use jdk 5 for-each loopchammer10-117/+79
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I64fa6afd85181b24a5cc3bd13a61aca68dc59a00 Signed-off-by: chammer <carsten.hammer@t-online.de>
2019-11-14Unnecessary whitespace removalLars Vogel2-4/+4
Change-Id: I16039f99f6aaf7781b5be60694589f353c6e3f05 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-13Bug 552896 - Use varargs in AbstractLaunchConfigurationTabGroup#setTabsI20191114-0410I20191113-2315I20191113-1800Lars Vogel1-1/+1
Requires also to bump the minor version Change-Id: I839da215ca738c1c3d28092f815b139207d7afc0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-13Bug 552982 - Shorter text for Delete launch configurationLars Vogel1-2/+2
Change-Id: I7b9dcba459f6f7d63f0f0dc7e7657940a90221c5 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-12Bug 552014 - [console] Input problem with fixed width console and IMEI20191112-1800Paul Pazderski6-75/+256
When IME is started at end of fixed width line the first stroke is immediately inserted as character and the IME continued after. Change-Id: I9a197f49b9b9aae8c279fe5638fa5278d66294c8 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-12Bug 551935 - Replace usage of deprecated TextUtilities.indexOf with newPaul Pazderski2-21/+27
MultiStringMatcher Change-Id: I6ca1bae81e71f12c16e006887c4932c084eb970c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-12Use a more telling parameter name in DebugUIPlugin#getImageDescriptorLars Vogel1-3/+3
Change-Id: Ib062a2df9dba1d1ae494cc7d3e5c37ea9c79f7de Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-08Bug 552350 - Disable debug toolbar actions until plugin is loadedY20191112-0030I20191111-1800I20191111-0920I20191111-0655I20191111-0435I20191111-0145I20191110-1800I20191109-1800Paul Pazderski2-12/+22
Change-Id: I2bf6dc475a0ec08589ca5b236bbbaccc1d72afb0 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-06Improve tear down in IOConsoleTests and ProcessConsoleTestsY20191107-0440Y20191107-0420I20191109-0650I20191109-0330I20191108-1800I20191107-1800I20191106-1805Paul Pazderski2-2/+4
Before 'asserting' in tearDown do the cleanup stuff which would not be executed if the assertion fails. Change-Id: I9f72d0a073957aea4d216be4cff58729494bbe82 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-06Bug 552015 - Check stream closed before trying to readPaul Pazderski1-4/+5
Change-Id: I7a626dd99a75a481a48d07aff24ff665a98df6d1 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-04Bug 551955 - Discouraged access in jdt.debugI20191105-1800I20191105-0025I20191104-1800Sarika Sinha1-1/+1
Change-Id: Ife26359b179debe93c72da79334c3dcf6074c91c
2019-10-25Bug 552423 - Replace usage of deprecated AbstractUIPlugin#getWorkbenchI20191103-1800I20191102-1800I20191101-1800I20191101-0300I20191031-1800I20191031-1325I20191030-1800I20191030-0010I20191029-1800I20191028-1800I20191027-1800I20191026-1800I20191025-1805Karsten Thoms4-5/+6
Change-Id: I3bc803f894aa33e94ed53789789148362d4c2a4b Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-10-19Use jdk 5 for-each loop (Part 2)I20191024-1800I20191023-1810Carsten Hammer127-776/+634
Replace simple uses of Iterator with a corresponding for-each loop. Also add missing braces on loops as necessary. Change-Id: I5c017921217bcbc2909c30ef120a2104a26254b5 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-10-16Bug 551923 - [Memory View] Disposed Exception during “Terminate&Launch”I20191022-1800I20191022-0405I20191020-1800I20191019-1800I20191018-1800I20191018-0720I20191016-1800Johannes Faltermeier1-1/+5
* don't perform update if table cursor is disposed Change-Id: Ic07fcb496cbd741c9e1f42e45a099be9fffeddba Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
2019-10-16Bug 550220 Sometimes incomplete stack is shown for threads that wereUmair Sair2-23/+189
expanded before resume CheckState model delta visitor removes delta if parent flags are NO_CHANGE and there are no pending updates reported for it from content provider. In case of this bug, the updates for elements (threads in view) are a bit late and CheckState visitor removes that delta. The removal of delta causes improper view like expanded thread with only one frame. Change-Id: Ia1d33d6e59db285dbd6c1acf4503b7406809ecdb Signed-off-by: Umair Sair <umair_sair@hotmail.com>
2019-10-15Bug 498365 - Add collapse all to Debug ViewI20191015-1800Sarika Sinha3-2/+131
Change-Id: I0c1febb5633fe00e2892664cdcb4778a1ef8d474 Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2019-10-14Bug 551955 - Discouraged access in jdt.debugI20191014-1800Sarika Sinha1-1/+1
Change-Id: Ib2bfa97f5a5bcfc26eae41070730f0003c19aede Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>

Back to the top