Iterate over Map.entrySet instead of Map.keySet and value searchI20200114-1805

Faster than first getting the keys and afterwards reading the value.

Done with Autorefactor https://github.com/JnRouvignac/AutoRefactor/
batch conversion using the iterate over
Map.entrySet instead of Map.keySet and value search

Change-Id: I438796d7ce3abd35c5a8922559c582ef8685ed08
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

1 files changed, 3 insertions, 2 deletions

diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java
index e3b96d32d..439b641f3 100644
--- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java
+++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java
@@ -1171,8 +1171,9 @@ public final class BuilderPropertyPage extends PropertyPage implements ICheckSta
 				if(oldArgs.size() != newArgs.size()) {
 					return true;
 				}
-				for (String key : oldArgs.keySet()) {
-					if (comparator.compare(oldArgs.get(key), newArgs.get(key)) != 0) {
+				for (Map.Entry<String, String> entry : oldArgs.entrySet()) {
+					String key = entry.getKey();
+					if (comparator.compare(entry.getValue(), newArgs.get(key)) != 0) {
 						return true;
 					}
 				}