Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDarin Swanson2005-01-11 22:59:14 +0000
committerDarin Swanson2005-01-11 22:59:14 +0000
commit87f5b06b99acd13ba3b919ec3af0eab517511359 (patch)
tree4b09335d3fdeed01ba702e942329c3fb7c925ae3 /org.eclipse.ui.externaltools
parentb83d88a40e2c43e570620ce930366fe1a922b9ab (diff)
downloadeclipse.platform.debug-87f5b06b99acd13ba3b919ec3af0eab517511359.tar.gz
eclipse.platform.debug-87f5b06b99acd13ba3b919ec3af0eab517511359.tar.xz
eclipse.platform.debug-87f5b06b99acd13ba3b919ec3af0eab517511359.zip
Bug 81029 - Silent failure on build if .launch for builder is missing
Diffstat (limited to 'org.eclipse.ui.externaltools')
-rw-r--r--org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolBuilder.java5
-rw-r--r--org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsModelMessages.properties1
2 files changed, 5 insertions, 1 deletions
diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolBuilder.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolBuilder.java
index 948043ce1..d3a003ba4 100644
--- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolBuilder.java
+++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolBuilder.java
@@ -85,7 +85,10 @@ public final class ExternalToolBuilder extends IncrementalProjectBuilder {
projectsWithinScope= new ArrayList();
ILaunchConfiguration config = BuilderUtils.configFromBuildCommandArgs(getProject(), args, new String[1]);
- if (config != null && buildKindCompatible(kind, config) && configEnabled(config)) {
+ if (config == null) {
+ throw ExternalToolsPlugin.newError(ExternalToolsModelMessages.getString("ExternalToolBuilder.0"), null); //$NON-NLS-1$
+ }
+ if (buildKindCompatible(kind, config) && configEnabled(config)) {
doBuildBasedOnScope(kind, config, monitor);
}
return getProjectsWithinScope();
diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsModelMessages.properties b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsModelMessages.properties
index 61fcca0f3..75efe1075 100644
--- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsModelMessages.properties
+++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsModelMessages.properties
@@ -11,6 +11,7 @@
ImageDescriptorRegistry.Allocating_image_for_wrong_display_1=Allocating image for wrong display
ExternalToolBuilder.Running_{0}..._1=Running {0}...
+ExternalToolBuilder.0=The builder launch configuration could not be found.
BuilderUtils.5=Command Error
BuilderUtils.6=An error occurred while saving the project's build commands
BuilderUtils.7=\ [Builder]

Back to the top