Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCurtis Windatt2007-05-07 17:04:38 +0000
committerCurtis Windatt2007-05-07 17:04:38 +0000
commit74d4af174a20ccb5a186da654b7f7974e34b34f2 (patch)
tree987e40aaed31e8a04d734cf8518e229e6c8d9b92 /org.eclipse.debug.ui
parent654e67fe88b3fcd6783f23a6bfc76dfd14656b6e (diff)
downloadeclipse.platform.debug-74d4af174a20ccb5a186da654b7f7974e34b34f2.tar.gz
eclipse.platform.debug-74d4af174a20ccb5a186da654b7f7974e34b34f2.tar.xz
eclipse.platform.debug-74d4af174a20ccb5a186da654b7f7974e34b34f2.zip
Bug 184999 - Add/Edit File System Directory Dialog has incorrect F1 help
Diffstat (limited to 'org.eclipse.debug.ui')
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/IDebugHelpContextIds.java1
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/AddSourceContainerDialog.java2
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/browsers/DirectorySourceContainerDialog.java5
3 files changed, 6 insertions, 2 deletions
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/IDebugHelpContextIds.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/IDebugHelpContextIds.java
index 80a039f26..ee5ddc30d 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/IDebugHelpContextIds.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/IDebugHelpContextIds.java
@@ -113,6 +113,7 @@ public interface IDebugHelpContextIds {
public static final String SELECT_LAUNCHERS_DIALOG = PREFIX + "select_launchers_dialog"; //$NON-NLS-1$
public static final String SELECT_RESOURCES_TO_SAVE_DIALOG = PREFIX + "select_resources_to_save_dialog"; //$NON-NLS-1$
public static final String SELECT_LAUNCH_METHOD_DIALOG = PREFIX + "select_launch_method_dialog"; //$NON-NLS-1$
+ public static final String SELECT_DIRECTORY_SOURCE_CONTAINER_DIALOG = PREFIX + "select_directory_source_container_dialog"; //$NON-NLS-1$
// Property pages
public static final String PROCESS_PROPERTY_PAGE = PREFIX + "process_property_page_context"; //$NON-NLS-1$
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/AddSourceContainerDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/AddSourceContainerDialog.java
index 244d6d4e1..dcf26e664 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/AddSourceContainerDialog.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/AddSourceContainerDialog.java
@@ -149,7 +149,7 @@ public class AddSourceContainerDialog extends TitleAreaDialog {
ISourceContainerBrowser browser = DebugUITools.getSourceContainerBrowser(type.getId());
if (browser != null) {
ISourceContainer[] results = browser.addSourceContainers(getShell(), fDirector);
- if (results != null) {
+ if (results != null && results.length > 0) {
fSourceContainerViewer.addEntries(results);
}
}
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/browsers/DirectorySourceContainerDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/browsers/DirectorySourceContainerDialog.java
index e0add8833..5660b0f9b 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/browsers/DirectorySourceContainerDialog.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/browsers/DirectorySourceContainerDialog.java
@@ -15,6 +15,7 @@ import java.io.File;
import org.eclipse.debug.internal.ui.DebugPluginImages;
import org.eclipse.debug.internal.ui.DebugUIPlugin;
+import org.eclipse.debug.internal.ui.IDebugHelpContextIds;
import org.eclipse.debug.internal.ui.IInternalDebugUIConstants;
import org.eclipse.debug.internal.ui.sourcelookup.SourceLookupUIMessages;
import org.eclipse.jface.dialogs.IDialogConstants;
@@ -37,6 +38,7 @@ import org.eclipse.swt.widgets.DirectoryDialog;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Text;
+import org.eclipse.ui.PlatformUI;
/**
* The dialog for selecting the external folder for which a source container will be created.
@@ -70,7 +72,7 @@ public class DirectorySourceContainerDialog extends TitleAreaDialog {
* Creates a dialog to edit file system folder.
*
* @param shell shell
- * @param directory directory to edit or empyy string
+ * @param directory directory to edit or empty string
* @param searchSubfolders whether the search subfolders button should be checked
* @param newContainer
*/
@@ -186,6 +188,7 @@ public class DirectorySourceContainerDialog extends TitleAreaDialog {
fDirText.setText(fDirectory);
fSubfoldersButton.setSelection(fSearchSubfolders);
validate();
+ PlatformUI.getWorkbench().getHelpSystem().setHelp(c, IDebugHelpContextIds.SELECT_DIRECTORY_SOURCE_CONTAINER_DIALOG);
return c;
}

Back to the top