Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrey Loskutov2020-03-22 11:39:54 +0000
committerAndrey Loskutov2020-03-22 11:39:54 +0000
commit24015b387c3630e603f6eada267ebc6ab79d3c02 (patch)
tree9a8765a396a15d661371c8af5a2d96f23d44d1d3 /org.eclipse.debug.ui
parent04459456c8e9a051ae1c13dab6bc3bd5e7324b46 (diff)
downloadeclipse.platform.debug-24015b387c3630e603f6eada267ebc6ab79d3c02.tar.gz
eclipse.platform.debug-24015b387c3630e603f6eada267ebc6ab79d3c02.tar.xz
eclipse.platform.debug-24015b387c3630e603f6eada267ebc6ab79d3c02.zip
Bug 561338 - Random IOOB on updating breadcrumb in Debug viewI20200323-1800
Do not call into JFace with invalid index. Change-Id: I62cd885cb5fae2bc6e3ca540f1b691f9ce1e113d Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Diffstat (limited to 'org.eclipse.debug.ui')
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/TreeModelContentProvider.java9
1 files changed, 8 insertions, 1 deletions
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/TreeModelContentProvider.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/TreeModelContentProvider.java
index 50724c0c2..4ed94c55a 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/TreeModelContentProvider.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/TreeModelContentProvider.java
@@ -1543,7 +1543,14 @@ public class TreeModelContentProvider implements ITreeModelContentProvider, ICon
DebugUIPlugin.trace(" - (found) remove(" + parentPath.getLastSegment() + ", viewIndex: " + viewIndex + " modelIndex: " + modelIndex); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
}
rescheduleUpdates(parentPath, modelIndex);
- getViewer().remove(parentPath, viewIndex);
+ if (viewIndex >= 0) {
+ getViewer().remove(parentPath, viewIndex);
+ } else {
+ if (DebugUIPlugin.DEBUG_CONTENT_PROVIDER && DebugUIPlugin.DEBUG_TEST_PRESENTATION_ID(getPresentationContext())) {
+ DebugUIPlugin.trace(" - (not found in UI) remove(" + parentPath.getLastSegment() + ", viewIndex: " //$NON-NLS-1$ //$NON-NLS-2$
+ + viewIndex + " modelIndex: " + modelIndex); //$NON-NLS-1$
+ }
+ }
removeElementFromFilters(parentPath, modelIndex);
return;
}

Back to the top