Bug 52017 - Add createCheckButton API to AbstractLaunchConfigurationTab

3 files changed, 22 insertions, 10 deletions

diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/AbstractLaunchConfigurationTab.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/AbstractLaunchConfigurationTab.java
index 684b31b34..aef0aab8e 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/AbstractLaunchConfigurationTab.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/AbstractLaunchConfigurationTab.java
@@ -213,6 +213,25 @@ public abstract class AbstractLaunchConfigurationTab implements ILaunchConfigura
 	}	
 	
 	/**
+	 * Creates and returns a new check button with the given
+	 * label.
+	 * 
+	 * @param parent the parent composite
+	 * @param label the button label
+	 * @return a new check button
+	 * @since 3.0
+	 */
+	protected Button createCheckButton(Composite parent, String label) {
+		Button button = new Button(parent, SWT.CHECK);
+		button.setText(label);
+		GridData data = new GridData();
+		button.setLayoutData(data);
+		button.setFont(parent.getFont());
+		SWTUtil.setButtonDimensionHint(button);
+		return button;
+	}
+	
+	/**
 	 * @see ILaunchConfigurationTab#canSave()
 	 */
 	public boolean canSave() {
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java
index 8add96145..6c2de44d8 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java
@@ -214,8 +214,7 @@ public class CommonTab extends AbstractLaunchConfigurationTab {
 	 * @param parent the composite to create the controls in
 	 */
 	protected void createLaunchInBackgroundComponent(Composite parent) {
-		fLaunchInBackgroundButton = new Button(parent, SWT.CHECK);
-		fLaunchInBackgroundButton.setText(LaunchConfigurationsMessages.getString("CommonTab.10")); //$NON-NLS-1$
+		fLaunchInBackgroundButton = createCheckButton(parent, LaunchConfigurationsMessages.getString("CommonTab.10")); //$NON-NLS-1$
 		GridData data = new GridData(GridData.HORIZONTAL_ALIGN_FILL);
 		data.horizontalSpan = 2;
 		fLaunchInBackgroundButton.setLayoutData(data);
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/RefreshTab.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/RefreshTab.java
index ffeaca4c3..de36439e0 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/RefreshTab.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/RefreshTab.java
@@ -127,11 +127,7 @@ public class RefreshTab extends AbstractLaunchConfigurationTab {
 		
 		createVerticalSpacer(mainComposite, 1);
 		
-		fRefreshButton = new Button(mainComposite, SWT.CHECK);
-		fRefreshButton.setFont(mainComposite.getFont());
-		fRefreshButton.setText(StringSubstitutionMessages.getString("RefreshTab.31")); //$NON-NLS-1$
-		gd = new GridData(GridData.BEGINNING);
-		fRefreshButton.setLayoutData(gd);
+		fRefreshButton = createCheckButton(mainComposite, StringSubstitutionMessages.getString("RefreshTab.31")); //$NON-NLS-1$
 		fRefreshButton.addSelectionListener(new SelectionAdapter() {
 			public void widgetSelected(SelectionEvent e) {
 				updateEnabledState();
@@ -228,12 +224,10 @@ public class RefreshTab extends AbstractLaunchConfigurationTab {
 	 * @param parent the composite to create the controls in
 	 */
 	private void createRecursiveComponent(Composite parent) {
-		fRecursiveButton = new Button(parent, SWT.CHECK);
-		fRecursiveButton.setText(StringSubstitutionMessages.getString("RefreshTab.0")); //$NON-NLS-1$
+		fRecursiveButton = createCheckButton(parent, StringSubstitutionMessages.getString("RefreshTab.0")); //$NON-NLS-1$
 		GridData data = new GridData(GridData.HORIZONTAL_ALIGN_FILL);
 		data.horizontalSpan = 2;
 		fRecursiveButton.setLayoutData(data);
-		fRecursiveButton.setFont(parent.getFont());
 		fRecursiveButton.addSelectionListener(new SelectionAdapter() {
 			public void widgetSelected(SelectionEvent e) {
 				updateLaunchConfigurationDialog();