Bug 198437 EMPTY_STRING constant not used

1 files changed, 6 insertions, 11 deletions

diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java
index 2b0585694..79cd4061b 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java
@@ -150,11 +150,6 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun
 	 */
 	public static final int LAUNCH_CONFIGURATION_DIALOG_REUSE_OPEN = 4;
 	/**
-	 * defines the empty string
-	 * @since 3.2
-	 */
-	private static final String EMPTY_STRING = ""; //$NON-NLS-1$
-	/**
 	 * defines the delimiter used in the persistence of the expanded state
 	 * @since 3.2
 	 */
@@ -636,7 +631,7 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun
 	 */
 	public String generateName(String name) {
 		if (name == null) {
-			name = EMPTY_STRING;
+			name = IInternalDebugUIConstants.EMPTY_STRING;
 		}
 		return getLaunchManager().generateUniqueLaunchConfigurationNameFrom(name);
 	}
@@ -653,7 +648,7 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun
 	 */
 	public String generateName(String name, Set reservednames) {
 		if(name == null) {
-			name = EMPTY_STRING;
+			name = IInternalDebugUIConstants.EMPTY_STRING;
 		}
 		return ((LaunchManager)getLaunchManager()).generateUniqueLaunchConfigurationNameFrom(name, reservednames);
 	}
@@ -1143,14 +1138,14 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun
 			TreeItem[] items = fLaunchConfigurationView.getTreeViewer().getTree().getItems();
 			String value = settings.get(DIALOG_EXPANDED_NODES);
 			if(value == null) {
-				value = EMPTY_STRING;
+				value = IInternalDebugUIConstants.EMPTY_STRING;
 			}
 			ArrayList list = new ArrayList();
 			String[] persisted = value.split(DELIMITER); 
 			for(int i = 0; i < persisted.length; i++) {
 				list.add(persisted[i]);
 			}
-			String type = EMPTY_STRING;
+			String type = IInternalDebugUIConstants.EMPTY_STRING;
 			//if the item is not in the list and is expanded add it, otherwise if it
 			//is not expanded do a remove...either way for the else we query the list
 			for(int i = 0; i < items.length; i++) {
@@ -1162,7 +1157,7 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun
 					list.remove(type);
 				}
 			}
-			value = EMPTY_STRING;
+			value = IInternalDebugUIConstants.EMPTY_STRING;
 			//build the preference string
 			for(Iterator iter = list.iterator(); iter.hasNext();) {
 				value += iter.next() + DELIMITER;
@@ -1523,7 +1518,7 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun
 	 * @see org.eclipse.jface.util.IPropertyChangeListener#propertyChange(org.eclipse.jface.util.PropertyChangeEvent)
 	 */
 	public void propertyChange(final PropertyChangeEvent event) {
-		WorkbenchJob job = new WorkbenchJob(EMPTY_STRING) {
+		WorkbenchJob job = new WorkbenchJob(IInternalDebugUIConstants.EMPTY_STRING) {
 			public IStatus runInUIThread(IProgressMonitor monitor) {
 				TreeViewer viewer = fLaunchConfigurationView.getTreeViewer();
 				boolean newvalue = Boolean.valueOf(event.getNewValue().toString()).booleanValue();