Use addAll, deleteAll instead of looping through a collectionI20190620-0130I20190619-1820I20190619-1800I20190618-1805

Change-Id: I9c95900ed1b6e8823bb30c4ded37f214a92deffc
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

1 files changed, 6 insertions, 15 deletions

diff --git a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/expressions/ExpressionManagerTests.java b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/expressions/ExpressionManagerTests.java
index 3f51c5d6f..24434287e 100644
--- a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/expressions/ExpressionManagerTests.java
+++ b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/expressions/ExpressionManagerTests.java
@@ -14,6 +14,7 @@
 package org.eclipse.debug.tests.expressions;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 import org.eclipse.debug.core.DebugPlugin;
@@ -71,25 +72,19 @@ public class ExpressionManagerTests extends AbstractDebugTest {
 
 		@Override
 		public void expressionsAdded(IExpression[] expressions) {
-			for (int i = 0; i < expressions.length; i++) {
-				added.add(expressions[i]);
-			}
+			Collections.addAll(added, expressions);
 			addedCallbacks++;
 		}
 
 		@Override
 		public void expressionsRemoved(IExpression[] expressions) {
-			for (int i = 0; i < expressions.length; i++) {
-				removed.add(expressions[i]);
-			}
+			Collections.addAll(removed, expressions);
 			removedCallbacks++;
 		}
 
 		@Override
 		public void expressionsChanged(IExpression[] expressions) {
-			for (int i = 0; i < expressions.length; i++) {
-				changed.add(expressions[i]);
-			}
+			Collections.addAll(changed, expressions);
 			changedCallbacks++;
 		}
 
@@ -105,18 +100,14 @@ public class ExpressionManagerTests extends AbstractDebugTest {
 
 		@Override
 		public void expressionsMoved(IExpression[] expressions, int index) {
-			for (int i = 0; i < expressions.length; i++) {
-				moved.add(expressions[i]);
-			}
+			Collections.addAll(moved, expressions);
 			movedCallbacks++;
 			insertIndex = index;
 		}
 
 		@Override
 		public void expressionsInserted(IExpression[] expressions, int index) {
-			for (int i = 0; i < expressions.length; i++) {
-				inserted.add(expressions[i]);
-			}
+			Collections.addAll(inserted, expressions);
 			insertedCallbacks++;
 			insertIndex = index;
 		}