diff options
| author | Lars Vogel | 2021-07-21 13:36:20 +0000 |
|---|---|---|
| committer | Alexander Kurtakov | 2021-07-21 13:55:25 +0000 |
| commit | 5143924c24f9fe9c69fdf72fa1a0ac14c895ddf0 (patch) | |
| tree | 3546f76be1a6ba0876d7f5a61ad8ad1238bec264 /org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui | |
| parent | 5d074b295f483924811b6e11a39600f0b76b0034 (diff) | |
| download | eclipse.platform.debug-5143924c24f9fe9c69fdf72fa1a0ac14c895ddf0.tar.gz eclipse.platform.debug-5143924c24f9fe9c69fdf72fa1a0ac14c895ddf0.tar.xz eclipse.platform.debug-5143924c24f9fe9c69fdf72fa1a0ac14c895ddf0.zip | |
Use JDT static inner class clean up for platform.debug internal packagesY20210810-0820Y20210810-0500Y20210805-0800Y20210804-1030Y20210730-0530Y20210729-0800Y20210727-0800Y20210722-0800I20210811-1800I20210810-1800I20210809-1800I20210808-1800I20210807-1800I20210806-1800I20210805-1800I20210804-1800I20210804-0930I20210730-1800I20210729-1800I20210729-0050I20210728-1800I20210727-1800I20210726-1800I20210725-1800I20210724-1800I20210723-1800I20210722-1800I20210721-1800
This ticket uses and tests the "Use static inner class" cleanup feature:
- It reviews the feature
- It reduces the memory consumption as it avoids the pointer to the
outer class
Example:
Before:
public class Outer {
public class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
After:
public class Outer {
public static class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
Change-Id: Id13e31a83bc9a0740a17b1d409aebc613bcbdb7f
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/180223
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Diffstat (limited to 'org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui')
2 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java index 3e002de85..37d115b47 100644 --- a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java +++ b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java @@ -67,7 +67,7 @@ public class PDAVirtualFindAction extends Action implements IUpdate { private final TreeModelViewer fClientViewer; - protected class VirtualViewerListener implements IViewerUpdateListener, ILabelUpdateListener { + protected static class VirtualViewerListener implements IViewerUpdateListener, ILabelUpdateListener { private boolean fViewerUpdatesComplete = false; private boolean fLabelUpdatesComplete = false; diff --git a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/editor/PDAScanner.java b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/editor/PDAScanner.java index aa586afe5..4de0f7c77 100644 --- a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/editor/PDAScanner.java +++ b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/editor/PDAScanner.java @@ -39,7 +39,7 @@ public class PDAScanner extends BufferedRuleBasedScanner { /** * Detects potential keywords */ - class PDAWordDetector implements IWordDetector { + static class PDAWordDetector implements IWordDetector { @Override public boolean isWordStart(char c) { |