Bug 413095 - Clean up deprecation and code warnings

2 files changed, 15 insertions, 11 deletions

diff --git a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAThreadEventHandler.java b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAThreadEventHandler.java
index ab77bd09d..60d0bbc6c 100644
--- a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAThreadEventHandler.java
+++ b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAThreadEventHandler.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2005, 2011 IBM Corporation and others.
+ * Copyright (c) 2005, 2013 IBM Corporation and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -108,6 +108,10 @@ public class PDAThreadEventHandler extends DebugEventHandler {
 		return newdelta.addNode(debugTarget, indexOf(children, debugTarget), IModelDelta.NO_CHANGE, numFrames);
 	}
 
+	/**
+	 * @param thread
+	 * @param flags
+	 */
 	private void fireDeltaAndClearTopFrame(IThread thread, int flags) {
 		ModelDelta delta = buildRootDelta();
 		addTarget(delta, thread);
diff --git a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java
index d594d8fab..b5e613ef3 100644
--- a/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java
+++ b/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/adapters/PDAVirtualFindAction.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2004, 2012 IBM Corporation and others.
+ * Copyright (c) 2004, 2013 IBM Corporation and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -62,7 +62,7 @@ import org.eclipse.ui.texteditor.IUpdate;
  */
 public class PDAVirtualFindAction extends Action implements IUpdate {
 	
-    private TreeModelViewer fClientViewer;
+    private final TreeModelViewer fClientViewer;
 	
 	protected class VirtualViewerListener implements IViewerUpdateListener, ILabelUpdateListener {
 	    
@@ -121,8 +121,8 @@ public class PDAVirtualFindAction extends Action implements IUpdate {
 	}
 	
 	private static class FindLabelProvider extends LabelProvider {
-		private VirtualTreeModelViewer fVirtualViewer;
-		private Map fTextCache = new HashMap();
+		private final VirtualTreeModelViewer fVirtualViewer;
+		private final Map fTextCache = new HashMap();
 		public FindLabelProvider(VirtualTreeModelViewer viewer, List items) {
 		    fVirtualViewer = viewer;
 		    for (int i = 0; i < items.size(); i++) {
@@ -141,7 +141,7 @@ public class PDAVirtualFindAction extends Action implements IUpdate {
 	}
 
 	public PDAVirtualFindAction(IPresentationContext context) {
-		setText("Find");
+		setText("Find"); //$NON-NLS-1$
 		setId(DebugUIPlugin.getUniqueIdentifier() + ".FindElementAction"); //$NON-NLS-1$
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IDebugHelpContextIds.FIND_ELEMENT_ACTION);
 		setActionDefinitionId(IWorkbenchCommandConstants.EDIT_FIND_AND_REPLACE);
@@ -280,8 +280,8 @@ public class PDAVirtualFindAction extends Action implements IUpdate {
 		    fClientViewer.getControl().getShell(), 
 		    labelProvider, 
 		    items.toArray());
-		dialog.setTitle("PDA Variables View Find");
-		dialog.setMessage("&Specify an element to select (? = any character, * = any String):");
+		dialog.setTitle("PDA Variables View Find"); //$NON-NLS-1$
+		dialog.setMessage("&Specify an element to select (? = any character, * = any String):"); //$NON-NLS-1$
 		if (dialog.open() == Window.OK) {
 			Object[] elements = dialog.getResult();
 			if (elements.length == 1) {
@@ -304,9 +304,9 @@ public class PDAVirtualFindAction extends Action implements IUpdate {
         } else {
             DebugUIPlugin.errorDialog(
                 fClientViewer.getControl().getShell(), 
-                "Error",
-                "Could not select item:" + labelProvider.getText(findItem),
-                new Status(IStatus.ERROR, DebugUIPlugin.getUniqueIdentifier(), "Element no longer in viewer."));
+ "Error", //$NON-NLS-1$
+					"Could not select item:" + labelProvider.getText(findItem), //$NON-NLS-1$
+					new Status(IStatus.ERROR, DebugUIPlugin.getUniqueIdentifier(), "Element no longer in viewer.")); //$NON-NLS-1$
         }	    
 	}