API review/cleanup

3 files changed, 10 insertions, 4 deletions

diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/core/ILaunchConfigurationType.java b/org.eclipse.debug.core/core/org/eclipse/debug/core/ILaunchConfigurationType.java
index f8ef276de..2dff04d70 100644
--- a/org.eclipse.debug.core/core/org/eclipse/debug/core/ILaunchConfigurationType.java
+++ b/org.eclipse.debug.core/core/org/eclipse/debug/core/ILaunchConfigurationType.java
@@ -32,6 +32,8 @@ import org.eclipse.debug.core.sourcelookup.ISourcePathComputer;
  *      delegate="com.example.ExampleLaunchConfigurationDelegate"
  *      modes="run, debug"
  *      name="Example Application">
+ *      sourceLocatorId="com.example.SourceLocator">
+ *      sourcePathComputerId="com.example.SourcePathComputer">
  *   </launchConfigurationType>
  * </extension>
  * </pre>
@@ -50,9 +52,14 @@ import org.eclipse.debug.core.sourcelookup.ISourcePathComputer;
  * <li><code>category</code> is an optional attribute that specifies a category
  * for this launch configuration type. Categories are client defined. This
  * attribute was added in the 2.1 release.</li>
+ * <li><code>sourceLocatorId</code> an optional unique identifier of a sourceLocator extension that
+ * is used to create the source locator for sessions launched using launch configurations
+ * of this type. This atttribute was added in the 3.0 release.</li>
+ * <li><code>sourcePathComputerId</code> an optional unique identifier of a sourcePathComputer extension
+ * that is used to compute a default source lookup path for launch configurations of this type.
+ * This atttribute was added in the 3.0 release.</li>
  * </ul>
  * </p>
- * TODO: add new attributes - sourcePathComputerId and sourceLocatorId
  * <p>
  * The <code>category</code> attribute has been added in release 2.1, such that other
  * tools may re-use the launch configuration framework for purposes other than
diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/containers/FolderSourceContainerType.java b/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/containers/FolderSourceContainerType.java
index 4e462f044..035a7ad08 100644
--- a/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/containers/FolderSourceContainerType.java
+++ b/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/containers/FolderSourceContainerType.java
@@ -63,7 +63,6 @@ public class FolderSourceContainerType extends AbstractSourceContainerTypeDelega
 				boolean nested = "true".equals(nest); //$NON-NLS-1$
 				IWorkspace workspace = ResourcesPlugin.getWorkspace();
 				IFolder folder = workspace.getRoot().getFolder(new Path(string));
-				// TODO: what if folder does not exist
 				return new FolderSourceContainer(folder, nested);
 			} 
 			abort(SourceLookupMessages.getString("FolderSourceContainerType.11"), null); //$NON-NLS-1$
diff --git a/org.eclipse.debug.core/schema/launchConfigurationTypes.exsd b/org.eclipse.debug.core/schema/launchConfigurationTypes.exsd
index bbaed66f1..954f899e3 100644
--- a/org.eclipse.debug.core/schema/launchConfigurationTypes.exsd
+++ b/org.eclipse.debug.core/schema/launchConfigurationTypes.exsd
@@ -103,14 +103,14 @@ Launch configuration instances of this type will delegate to instances of this c
          <attribute name="sourcePathComputerId" type="string">
             <annotation>
                <documentation>
-                  The unique identifier of a sourcePathComputer extension that is used to compute a default source lookup path for launch configurations of this type
+                  The unique identifier of a sourcePathComputer extension that is used to compute a default source lookup path for launch configurations of this type. This atttribute was added in the 3.0 release.
                </documentation>
             </annotation>
          </attribute>
          <attribute name="sourceLocatorId" type="string">
             <annotation>
                <documentation>
-                  The unique identifier of a sourceLocator extension that is used to create the source locator for sessions launched using launch configurations of this type
+                  The unique identifier of a sourceLocator extension that is used to create the source locator for sessions launched using launch configurations of this type. This atttribute was added in the 3.0 release.
                </documentation>
             </annotation>
          </attribute>