Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Keppler2021-11-03 20:00:56 +0000
committerAndrey Loskutov2021-11-04 11:06:56 +0000
commit88cc79b6cb9e1c3a0b8f826403bf219018c37490 (patch)
tree4ed4a7584be853e9649f7f953af41a70b7e76632
parente346d49025b6a976213a3baf4a7955f802b325b4 (diff)
downloadeclipse.platform.debug-88cc79b6cb9e1c3a0b8f826403bf219018c37490.tar.gz
eclipse.platform.debug-88cc79b6cb9e1c3a0b8f826403bf219018c37490.tar.xz
eclipse.platform.debug-88cc79b6cb9e1c3a0b8f826403bf219018c37490.zip
Bug 577047 - Non disposed image
Register not only the overlay image in the registry (to be automatically disposed), but also the base image. Change-Id: I092cce20c44fc17691330a095f59eab230a4e191 Signed-off-by: Michael Keppler <michael.keppler@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/187284 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationManager.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationManager.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationManager.java
index b2f01fdaf..95b9ce0b7 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationManager.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationManager.java
@@ -983,6 +983,9 @@ public class LaunchConfigurationManager implements ILaunchListener, ISavePartici
base = DebugPluginImages.getImage(IInternalDebugUIConstants.IMG_OVR_TRANSPARENT);
}
base = new Image(Display.getCurrent(), base, SWT.IMAGE_COPY);
+ // register the base image, to avoid nondisposed resource error
+ fErrorImages.put(key + "-baseImage", base); //$NON-NLS-1$
+
LaunchConfigurationTabImageDescriptor desc = new LaunchConfigurationTabImageDescriptor(base, LaunchConfigurationTabImageDescriptor.ERROR);
image = desc.createImage();
fErrorImages.put(key, image);

Back to the top