diff options
author | Sarika Sinha | 2021-01-04 11:55:52 +0000 |
---|---|---|
committer | Sarika Sinha | 2021-01-04 11:55:52 +0000 |
commit | f09b8b873ffbf52209123168872193a8488c779d (patch) | |
tree | 2e7350f0baabade5ad3e6681f408c10328da0649 | |
parent | e2d47cf8b6ac0d51dfb3e28d05f13a922c35fec0 (diff) | |
download | eclipse.platform.debug-f09b8b873ffbf52209123168872193a8488c779d.tar.gz eclipse.platform.debug-f09b8b873ffbf52209123168872193a8488c779d.tar.xz eclipse.platform.debug-f09b8b873ffbf52209123168872193a8488c779d.zip |
Revert "Bug 482711 - [launch] Creating the first launch config does not notify"I20210105-0600I20210104-1800
This reverts commit e2d47cf8b6ac0d51dfb3e28d05f13a922c35fec0.
Reason for revert: This causes looping in some scenario.
Change-Id: I4f5ff80fcd3cf787068b503e33a73d937b4e790a
-rw-r--r-- | org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchManager.java | 6 | ||||
-rw-r--r-- | org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/LaunchConfigurationTests.java | 33 |
2 files changed, 2 insertions, 37 deletions
diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchManager.java b/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchManager.java index aae9eab19..caf10c2d7 100644 --- a/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchManager.java +++ b/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchManager.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2000, 2021 IBM Corporation and others. + * Copyright (c) 2000, 2020 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -179,10 +179,6 @@ public class LaunchManager extends PlatformObject implements ILaunchManager, IRe */ private StepFilterManager fStepFilterManager = null; - public LaunchManager() { - getAllLaunchConfigurations(); - } - /** * Notifies a launch config listener in a safe runnable to handle * exceptions. diff --git a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/LaunchConfigurationTests.java b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/LaunchConfigurationTests.java index 1f16e87e2..5447884d9 100644 --- a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/LaunchConfigurationTests.java +++ b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/LaunchConfigurationTests.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2000, 2021 IBM Corporation and others. + * Copyright (c) 2000, 2020 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -1873,35 +1873,4 @@ public class LaunchConfigurationTests extends AbstractLaunchTest implements ILau assertTrue(t2.isPrototype()); } - @Test - public void testNewInstanceNotifiesListener() throws CoreException { - ILaunchManager launchManager = DebugPlugin.getDefault().getLaunchManager(); - final ArrayList<String> added = new ArrayList<>(); - ILaunchConfigurationListener listener = new ILaunchConfigurationListener() { - - @Override - public void launchConfigurationRemoved(ILaunchConfiguration configuration) { - - } - - @Override - public void launchConfigurationChanged(ILaunchConfiguration configuration) { - - } - - @Override - public void launchConfigurationAdded(ILaunchConfiguration configuration) { - added.add("Launch Configuration added"); - - } - }; - launchManager.addLaunchConfigurationListener(listener); - String typeId = "org.eclipse.ui.externaltools.ProgramLaunchConfigurationType"; - - ILaunchConfigurationType type = launchManager.getLaunchConfigurationType(typeId); - type.newInstance(null, "new-lc").doSave(); - assertEquals(1, added.size()); - assertEquals("Launch Configuration added", added.get(0)); - - } } |