diff options
| author | Paul Pazderski | 2020-02-20 09:05:45 +0000 |
|---|---|---|
| committer | Karsten Thoms | 2020-03-29 21:11:07 +0000 |
| commit | 5e2b2514fadb5ddea9bcfe8b723e8eb7d15e525d (patch) | |
| tree | d6fb9f0c0aabc6e304c0c758f540f77fffa808c8 | |
| parent | 4f984bac9597c5b0e8422a9923e971b0e502261f (diff) | |
| download | eclipse.platform.debug-5e2b2514fadb5ddea9bcfe8b723e8eb7d15e525d.tar.gz eclipse.platform.debug-5e2b2514fadb5ddea9bcfe8b723e8eb7d15e525d.tar.xz eclipse.platform.debug-5e2b2514fadb5ddea9bcfe8b723e8eb7d15e525d.zip | |
Bug 559180 - Suppress false potential resource leak warningS4_16_0_M1I20200409-0200I20200408-1800I20200408-0600I20200407-1800I20200407-1210I20200407-0120I20200406-1800I20200406-0600I20200406-0350I20200406-0120I20200405-1800I20200405-0600I20200404-1800I20200404-1220I20200404-0600I20200404-0330I20200403-1800I20200402-2250I20200402-1800I20200402-0850I20200402-0410I20200401-1800I20200331-1800I20200330-1800I20200329-1800
And add comment why it is no leak.
Change-Id: I67364abc6f2c8cc607219946e8c9bad56f8d0fc6
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2 files changed, 3 insertions, 0 deletions
diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/ExternalArchiveSourceContainer.java b/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/ExternalArchiveSourceContainer.java index b3ed3ef00..3f66da872 100644 --- a/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/ExternalArchiveSourceContainer.java +++ b/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/ExternalArchiveSourceContainer.java @@ -78,6 +78,8 @@ public class ExternalArchiveSourceContainer extends AbstractSourceContainer { fDetectRoots = detectRootPaths; } + // Suppress resource leak warning. The ZipFile is provided from + // SourceLookupUtils which take care to close them at some point. @SuppressWarnings("resource") @Override public Object[] findSourceElements(String name) throws CoreException { diff --git a/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/SourceLookupUtils.java b/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/SourceLookupUtils.java index ea44ed1c5..5891e9258 100644 --- a/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/SourceLookupUtils.java +++ b/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/sourcelookup/SourceLookupUtils.java @@ -51,6 +51,7 @@ public class SourceLookupUtils { * @exception IOException if unable to create the specified zip * file */ + @SuppressWarnings("resource") public static ZipFile getZipFile(String name) throws IOException { synchronized (fgZipFileCache) { if (fgCleaner == null) { |