diff options
author | Paul Pazderski | 2019-10-08 18:48:21 +0000 |
---|---|---|
committer | Paul Pazderski | 2019-10-13 11:59:25 +0000 |
commit | 7d66945dc54589ce4d538434d0c9fea5f272746c (patch) | |
tree | 4189ce76e0f5d81ca58f037695c7c11917047977 | |
parent | f99a92ff42bbdea4a8942581dfe84029df7d8e98 (diff) | |
download | eclipse.platform.debug-7d66945dc54589ce4d538434d0c9fea5f272746c.tar.gz eclipse.platform.debug-7d66945dc54589ce4d538434d0c9fea5f272746c.tar.xz eclipse.platform.debug-7d66945dc54589ce4d538434d0c9fea5f272746c.zip |
Bug 252433 - [detail] Variable detail calculation can unnecessarily wait
for 30 seconds before displaying variable value
Change-Id: I81e380751fc40d96bc23dbc18ef4253f2fc95baf
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
-rw-r--r-- | org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java index fd18bf7b4..cc889805e 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/details/DefaultDetailPane.java @@ -236,10 +236,13 @@ public class DefaultDetailPane extends AbstractDetailPane implements IDetailPane fModel.computeDetail(val, this); synchronized (this) { try { - // wait for a max of 30 seconds for result, then cancel - wait(30000); + // detail could already computed at this point (see bug 252433) if (!fComputed) { - fMonitor.setCanceled(true); + // wait for a max of 30 seconds for result, then cancel + wait(30000); + if (!fComputed) { + fMonitor.setCanceled(true); + } } } catch (InterruptedException e) { break; |