Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPawel Piech2012-03-02 05:40:30 +0000
committerPawel Piech2012-03-02 05:44:40 +0000
commit3c08aeeb1e0759e8fc8bca29a20e7d5ae79d504e (patch)
tree565fdb9d4003cc7ab67c229326803c941ad6f4c7
parentb8a6d681c35fc32520e868052315e993b782c7ec (diff)
downloadeclipse.platform.debug-3c08aeeb1e0759e8fc8bca29a20e7d5ae79d504e.tar.gz
eclipse.platform.debug-3c08aeeb1e0759e8fc8bca29a20e7d5ae79d504e.tar.xz
eclipse.platform.debug-3c08aeeb1e0759e8fc8bca29a20e7d5ae79d504e.zip
Bug 373030 - [breakpoints] Make BreakpointTypesContribution to a public package
-rw-r--r--org.eclipse.debug.ui/plugin.xml2
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/BreakpointTypesContribution.java (renamed from org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpoints/BreakpointTypesContribution.java)38
-rw-r--r--org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/RulerBreakpointTypesActionDelegate.java3
3 files changed, 36 insertions, 7 deletions
diff --git a/org.eclipse.debug.ui/plugin.xml b/org.eclipse.debug.ui/plugin.xml
index 6b71457e4..00b93055e 100644
--- a/org.eclipse.debug.ui/plugin.xml
+++ b/org.eclipse.debug.ui/plugin.xml
@@ -648,7 +648,7 @@
</visibleWhen>
<dynamic
id="org.eclipse.debug.ui.actions.BreakpointTypesContribution"
- class="org.eclipse.debug.internal.ui.actions.breakpoints.BreakpointTypesContribution">
+ class="org.eclipse.debug.ui.actions.BreakpointTypesContribution">
</dynamic>
</menu>
</menuContribution>
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpoints/BreakpointTypesContribution.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/BreakpointTypesContribution.java
index f7cc32c4b..dec47e0cd 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpoints/BreakpointTypesContribution.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/BreakpointTypesContribution.java
@@ -8,7 +8,7 @@
* Contributors:
* Wind River Systems - initial API and implementation
*******************************************************************************/
-package org.eclipse.debug.internal.ui.actions.breakpoints;
+package org.eclipse.debug.ui.actions;
import java.util.ArrayList;
import java.util.Iterator;
@@ -16,8 +16,8 @@ import java.util.List;
import java.util.Set;
import org.eclipse.debug.internal.ui.actions.ToggleBreakpointsTargetManager;
+import org.eclipse.debug.internal.ui.actions.breakpoints.Messages;
import org.eclipse.debug.ui.DebugUITools;
-import org.eclipse.debug.ui.actions.IToggleBreakpointsTargetManager;
import org.eclipse.jface.action.Action;
import org.eclipse.jface.action.ActionContributionItem;
import org.eclipse.jface.action.ContributionItem;
@@ -34,10 +34,36 @@ import org.eclipse.ui.menus.IWorkbenchContribution;
import org.eclipse.ui.services.IServiceLocator;
/**
- * Dynamic menu contribution that shows available breakpoint types from
- * toggleBreakpointsTargetFactories extension point.
- *
- * @since 3.5
+ * Breakpoint ruler pop-up action that creates a sub-menu to select the currently
+ * active breakpoint type. This menu contribution can be added to an editor
+ * with the <code>org.eclipse.ui.menus</code> extension point. The breakpoint
+ * types are calculated based on the toggle breakpoint target factories
+ * contributed through the <code>toggleBreakpointsTargetFactories</code> extension point.
+ * <p>
+ * Following is example plug-in XML used to contribute this action to an editor's
+ * vertical ruler context menu.
+ * <pre>
+ * &lt;extension point="org.eclipse.ui.menus"&gt;
+ * &lt;menuContribution
+ * locationURI="popup:#CEditorRulerContext?after=additions"
+ * id="example.RulerPopupActions"&gt;
+ * &lt;menu\
+ * id="breakpointTypes"
+ * label="Toggle Breakpoint"&gt;
+ * &lt;dynamic\
+ * id="example.rulerContextMenu.breakpointTypesAction"&gt;
+ * class="org.eclipse.debug.ui.actions.BreakpointTypesContribution"
+ * menubarPath="additions"&gt;/
+ * &lt;/menu&gt;
+ * &lt;/menuContribution&gt;
+ * </pre>
+ * </p>
+ * <p>
+ * Clients may refer to this class in plug-in XML. This class
+ * is not intended to be subclassed.
+ * </p>
+ * @since 3.8
+ * @noextend
*/
public class BreakpointTypesContribution extends CompoundContributionItem implements IWorkbenchContribution {
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/RulerBreakpointTypesActionDelegate.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/RulerBreakpointTypesActionDelegate.java
index ee4083dad..a6ff4db4d 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/RulerBreakpointTypesActionDelegate.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/RulerBreakpointTypesActionDelegate.java
@@ -73,6 +73,7 @@ import org.eclipse.ui.texteditor.ITextEditorExtension;
* @noextend This class is not intended to be subclassed by clients.
* @since 3.5
*
+ * @deprecated Should use BreakpointTypesContribution instead.
*/
public class RulerBreakpointTypesActionDelegate implements IEditorActionDelegate, IMenuListener, IMenuCreator {
private ITextEditor fEditor = null;
@@ -150,6 +151,7 @@ public class RulerBreakpointTypesActionDelegate implements IEditorActionDelegate
}
public void menuAboutToShow(IMenuManager manager) {
+ System.out.println("about to show");
fSelection = StructuredSelection.EMPTY;
if (fEditor != null && fRulerInfo != null) {
@@ -166,6 +168,7 @@ public class RulerBreakpointTypesActionDelegate implements IEditorActionDelegate
}
ToggleBreakpointsTargetManager toggleTargetManager = ToggleBreakpointsTargetManager.getDefault();
Set enabledIDs = toggleTargetManager.getEnabledToggleBreakpointsTargetIDs(fEditor, fSelection);
+ System.out.println(enabledIDs.toString());
fCallerAction.setEnabled(enabledIDs.size() > 0);
} else {
fCallerAction.setEnabled(false);

Back to the top