Bug 221234 - [console] Programs with lots of output cause major eclipse unresponsiveness with large console buffer

1 files changed, 23 insertions, 25 deletions

diff --git a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java
index cbc70c71c..82ea4fa6f 100644
--- a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java
+++ b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java
@@ -533,31 +533,29 @@ public class IOConsolePartitioner implements IConsoleDocumentPartitioner, IDocum
     		ArrayList pendingCopy = new ArrayList();
     		StringBuffer buffer = null;
     		boolean consoleClosed = false;
-    		while (pendingPartitions.size() > 0) {
-    			synchronized(pendingPartitions) {
-    				pendingCopy.addAll(pendingPartitions);
-    				pendingPartitions.clear();
-    				fBuffer = 0;
-    				pendingPartitions.notifyAll();
-    			}
-    			// determine buffer size
-    			int size = 0;
-    			for (Iterator i = pendingCopy.iterator(); i.hasNext(); ) {
-    				PendingPartition pp = (PendingPartition) i.next();
-    				if (pp != consoleClosedPartition) { 
-    					size+= pp.text.length();
-    				} 
-    			}
-    			buffer = new StringBuffer(size);
-    			for (Iterator i = pendingCopy.iterator(); i.hasNext(); ) {
-    				PendingPartition pp = (PendingPartition) i.next();
-    				if (pp != consoleClosedPartition) { 
-    					buffer.append(pp.text);
-    				} else {
-    					consoleClosed = true;
-    				}
-    			}
-    		}
+			synchronized(pendingPartitions) {
+				pendingCopy.addAll(pendingPartitions);
+				pendingPartitions.clear();
+				fBuffer = 0;
+				pendingPartitions.notifyAll();
+			}
+			// determine buffer size
+			int size = 0;
+			for (Iterator i = pendingCopy.iterator(); i.hasNext(); ) {
+				PendingPartition pp = (PendingPartition) i.next();
+				if (pp != consoleClosedPartition) { 
+					size+= pp.text.length();
+				} 
+			}
+			buffer = new StringBuffer(size);
+			for (Iterator i = pendingCopy.iterator(); i.hasNext(); ) {
+				PendingPartition pp = (PendingPartition) i.next();
+				if (pp != consoleClosedPartition) { 
+					buffer.append(pp.text);
+				} else {
+					consoleClosed = true;
+				}
+			}
 
     		if (connected) {
     			setUpdateInProgress(true);