Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-02-21Bug 571301 - Copyright needs to updated to 2021S4_19_0_RC2S4_19_0_RC1R4_19I20210303-1800I20210303-0600I20210302-1800I20210302-0930I20210302-0720I20210302-0600I20210301-1800I20210301-0600I20210228-1800I20210228-0600I20210227-1800I20210227-0600I20210226-2140I20210226-1800I20210226-0220I20210224-1800I20210224-0840I20210224-0600I20210223-1800I20210223-0650I20210223-0600I20210222-1800I20210222-0600I20210221-1800R4_19_maintenanceSravan Kumar Lakkimsetti1-2/+2
Change-Id: I3daf4412a059987828a1c3a594cf557a8e35a663 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-02-194.19 increase for ds/org.eclipse.pde.ds.coreI20210221-0600I20210220-1800I20210220-0600I20210219-1800Lars Vogel2-2/+2
Required for https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/176339 Change-Id: Iee1398ee4afd8af769dd3e55ada6c2ce785be0ae Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-13Bug 570900 - Tests on ClasspathResolutionTest are not run in I build.S4_19_0_M3I20210219-0300I20210217-1800I20210217-0600I20210216-2020I20210216-1800I20210216-1340I20210216-1140I20210216-1030I20210216-0600I20210215-1800I20210215-0700I20210215-0600I20210214-1800I20210214-0600I20210213-1800Alexander Kurtakov3-6/+6
Switch to use org.w3c.dom.events instead of javax.xml bundle as the former is part of the I-build p2 repo and the later is not. Change-Id: I89bbfbcfd751c598e95b9ad48f7ed1342370aa5a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-02-11Bug 570951 - Use new atomic marker creation API in ↵I20210213-0600I20210212-1840I20210211-1810Lars Vogel2-6/+6
DSAnnotationCompilationParticipant The new marker API from Bug 570914 allows to create markers with attributes and therefore avoids sending out resource change events for every attribute change. Includes the update of min version requirement for resource API as only 3.14 provides this API. Change-Id: Ie8eaba0f80fd78bfc2ba76008cf86e432b8225c0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-114.19 update for ds/org.eclipse.pde.ds.annotationsLars Vogel2-2/+2
Required for https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/175863 Change-Id: I7d3212f587a65f3ed9fc0cfe7cee068e8cc5c9af Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-09Bug 571010 - Move Bree to JavaSE-1.8 or aboveI20210210-1800I20210210-0910I20210209-1800Vikas Chandra6-10/+34
Change-Id: Iad7d6fca655de8f8722c6202f1896862cea126db Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-02-09update version Bug 571010 - Move Bree to JavaSE-1.8 or aboveVikas Chandra4-4/+4
Change-Id: Ib48c9bcd3ffdca674ec60459fddfc9fc2a8fadab Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-02-09Bug 571039 - While hovering on a version change due to BREE, reason forVikas Chandra1-3/+8
the change is empty. Change-Id: I9ad100c6cf4e113667ead205d35b958719a4e45c Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-02-08Bug 570951- Increase resource MANIFEST.MF minimum requirement inI20210208-1800Lars Vogel2-2/+2
pde.ua.core New Marker API is available as of 3.14, so we should increase the minimum version. Change-Id: Ic94d575bc874726ca3d369730bab98f99173d766 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-08Bug 570951 - Use new atomic marker creation API inLars Vogel2-2/+2
IncrementalErrorReporter The new marker API from Bug 570914 allows to create markers with attributes and therefore avoids sending out resource change events for every attribute change. Also increases the minimum required version of resource API as 3.14 defines the new API. Change-Id: Icfc9257c61b1e91431206fd5b58236b8965c80b0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-08[performance] Avoid replaceAll(regExp,)jkubitz9-19/+32
Avoiding regular expressions for simple character replacements. String.replaceAll() is twice as slow as String.replace() and uses far more ephemeral memory allocation which result in GC pause times for big projects. RequiredPluginsClasspathContainer.getRule is a hot spot during "Updating plug-in dependencies". Other occurrences of replaceAll have been substituted as well. Bug: 570904 Change-Id: I89a11d23dacd5b689789546d83abd590287a000d Signed-off-by: jkubitz <jkubitz-eclipse@gmx.de>
2021-02-08Bug 570952 - Use new atomic marker creation API in CtxHelpMarkerManagerLars Vogel1-6/+5
The new marker API from Bug 570914 allows to create markers with attributes and therefore avoids sending out resource change events for every attribute change. Change-Id: Ib23b18c872b0d9fc783a2ffe07da6b41fa8d1043 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-08Bug 570951 - Use new atomic marker creation API inLars Vogel1-7/+12
ManifestConsistencyChecker The new marker API from Bug 570914 allows to create markers with attributes and therefore avoids sending out resource change events for every attribute change. Change-Id: I275a15e9ca638fb358526e9bb8b5eb9882358af8 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-08Bug 570951 - Use new atomic marker creation API inLars Vogel1-3/+6
DeletePluginBaseResolution The new marker API from Bug 570914 allows to create markers with attributes and therefore avoids sending out resource change events for every attribute change. Change-Id: I389c812328e6fed513c1a3c7616a3d55ad05f4a5 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-08Bug 570953 - don't inject BREE when bundle declares Require-CapabilityJulian Honnen8-7/+120
Skip the injection of missing BREE header when bundle already has a Require-Capability: osgi.ee header. Change-Id: I6ca9ecd5b17530a80274563114f7a71ed93f3704 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2021-02-07Bug 570951 - Removes unused createMarker method in PDEMarkerFactoryI20210207-1800Lars Vogel1-11/+0
After updating the method to the new API I noted that it is not used. Change-Id: I3b0adef587a71c37f0a92cce6db3df08f0cfad3c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-05Bug 570959 - ApiAnalysisApplication: Remove imported project on exitI20210206-1800I20210206-0720I20210206-0050I20210205-1800Hannes Wellmann1-0/+7
Change-Id: I524c88959d6cdb336f61619327fd428e141c8011 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
2021-02-05Bug 570956 - ApiAnalysisApplication: Restore original project buildSpecHannes Wellmann1-6/+27
Change-Id: Ic52ddbe3dcb966eed21cbc40782c8841926657d7 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
2021-02-05Bug 570900 - Tests on ClasspathResolutionTest are not run in IVikas Chandra1-2/+4
build. Change-Id: Id3522680514587b61169cbd4577f189d90adedf6 Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-02-05Bug 570963 - DirectoryBundleContainer unify feature & bundle resolutionHannes Wellmann1-22/+17
Change-Id: I38997bc5ba1cc085da18a709ac60486417e552b3 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
2021-02-05Pre Bug 570956 - minor refactoring & fix Exception if project is closedHannes Wellmann1-31/+33
Refactor ApiAnalysisApplication.importProject() to improve readability and unncessary modification of a project's build-spec. Also avoid an potential CoreException if project exists but is closed. After the check for existence the project's location was checked but the doc of IProject.getDescriptor() states that it throws a " CoreException - if this method fails. Reasons include: - This project does not exist. - This project is not open. " Now the location is checked after the project is (definitive) open. Change-Id: I6c4f253d8e71cee5b910e5b80b0cdbe3ea3fe12d Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
2021-02-05Bug 570948 - PDE can't resolve / build projects anymoreAndrey Loskutov1-1/+3
Change-Id: I61466ab9dee314d8365ea23d6f7e3aa24c47361a Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2021-02-04Boolean.toString instead of Boolean.valueOf(b).toString inI20210204-2320I20210204-1800I20210204-1430I20210204-1300I20210204-1100Lars Vogel1-1/+1
DocumentObject New statement is shorter, discovered by testing JDT cleanups. Change-Id: I8ce59da09648a86cca6edd9af5d7a62f2c9a285a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-04Boolean.toString instead of Boolean.valueOf(b).toString inLars Vogel1-1/+1
CompCSTaskObject New statement is shorter, discovered by testing JDT cleanups. Change-Id: I4acd4a45d27e8d9bfbccbd96fb380fc3712cc48e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-04Bug 569905 - inject missing BREE based on project's JREI20210204-0900Julian Honnen8-1/+128
When no Bundle-RequiredExecutionEnvironment is specified, matching system packages from all execution environments will satisfy the import. When building against Java 11, e.g an Import-Package: javax.annotation may be resolved with the JavaSE-8 execution environment instead of an javax.annotation bundle, causing compile errors because that bundle won't be added to the classpath. This change injects an BREE based on the project's JRE into the manifest provided to the OSGi state if the manifest doesn't declare one. Change-Id: I75a71570a86a625eefd7bab2c27256b316e6e7c3 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2021-02-03Inner class in XMLErrorReporter can be staticLars Vogel1-1/+1
MutableInt can be a static inner class, as a reference to the outer class is not used. This save the internal pointer generated by the compiler to the outer class. Done during testing of the related JDT static inner class testing Change-Id: I6394623ca0276903a9682d46fb6da6e3078b93a7 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-02-03Inner class in SchemaErrorReporter can be staticLars Vogel1-1/+1
MutableInt can be a static inner class, as a reference to the outer class is not used. This save the internal pointer generated by the compiler to the outer class. Done during testing of the related JDT static inner class testing Change-Id: I41c201e0182e37d53917af8be62f1d383c1fbd01 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-01-29Bug 570736 - API tool errors are not refreshed unless baseline isI20210204-0300I20210203-1800I20210202-1840I20210201-1800I20210131-1800I20210130-1800I20210129-1800Vikas Chandra2-13/+4
re-added Change-Id: I991369f7497b11edb57a4a5a7ee2adaddb30c093 Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-01-27Bug 568885 - [spy] Plug-in Spy should resolve E4PartWrapper classI20210128-1800I20210127-1800Wim Jongman3-9/+31
Before this patch, for E4 parts: * The spy shows the generic E4PartWrapper as the view class * the contributing bundle is not available. With this patch: * the spy correctly finds the real class * the contributing bundle is visible Change-Id: Id2e2c4b5dcb863727964d54855b606f7eecd68b0 Signed-off-by: Wim Jongman <wim.jongman@remainsoftware.com>
2021-01-21Bug 569389 - Remove code that supports target state dependence onI20210126-1800I20210125-1800I20210124-1800I20210123-1800I20210123-0020I20210121-2140Vikas Chandra6-512/+96
preferences Change-Id: I29a700b08972d07cb24d85dc1e6bbd4498f4496c Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-01-21Bug 570433 - Improve Package Visibility text in PDE editorLars Vogel1-3/+3
The current text refer to the strict mode which is not supported by Equinox anymore. Also improve the text. Change-Id: Idbd15034847146583b31bd089567b5e356689fc5 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-01-21Bug 569394 - Remove IModelProvider from PDE Vikas Chandra3-69/+19
Change-Id: Ied80c9eb624ea12dc146f7054cb9a576a7460bd5 Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-01-20Revert "Bug: Invocation of hashCode on array"I20210120-1800I20210120-1400Alexander Kurtakov1-2/+1
This reverts commit 1b95d8ef7af35b0bd0c1d348776868c45016ccd4. Reason for revert: Concern raised on the initial patch. Change-Id: I59b6f5a8297aa26889903bd8c68b2704b0be438f
2021-01-20Bug: Invocation of hashCode on arrayCarsten Hammer1-1/+2
in org.eclipse.pde.api.tools.internal.comparator.Delta.hashCode() The code invokes hashCode on an array. Calling hashCode on an array returns the same value as System.identityHashCode, and ignores the contents and length of the array. If you need a hashCode that depends on the contents of an array a, use java.util.Arrays.hashCode(a). Rank: Scary (5), confidence: Normal Pattern: DMI_INVOKING_HASHCODE_ON_ARRAY Type: DMI, Category: CORRECTNESS (Correctness) Change-Id: I7c510508153988cc93be05aad86a3698f2be806f Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-01-19Bug 570441 - Move to Tycho 2.2.0Alexander Kurtakov1-5/+5
Migrate pde.ui git repo features to the new feature-source. Change-Id: I2c7890c60aac18c5a552f2d58f3816c13f3646a3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-18Bug 570441 - Move to Tycho 2.2.0I20210118-1800Alexander Kurtakov1-1/+1
Update pomless extension in pde.ui. Change-Id: I540577591f8f5236cb289d2c3061a0fb915c976c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-18Bug 570370 - Useless warnings for missing "Execution environmentVikas Chandra8-157/+10
references" Change-Id: I48cfabbbebf65df243f614b8ade10225aeb83a45 Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
2021-01-17Bug 570278 - Shorter "Exported Packages" text in the MANIFEST editorI20210117-1940I20210117-1800Wim Jongman1-0/+1
Fixed accidentally removed property Change-Id: Ib1abf29b02e5295ea7d290fd01e023b29eb42f00 Signed-off-by: Wim Jongman <wim.jongman@remainsoftware.com>
2021-01-15Bug 570278 - Shorter "Exported Packages" text in the MANIFEST editorI20210116-1800I20210116-0340I20210115-1810Lars Vogel1-3/+2
Currently the text says: Enumerate all the packages that this plug-in exposes to clients. All other packages will be hidden from clients at all times. The above is not true for non OSGi clients. So this commit makes the text correct and shorter. Change-Id: Ie1a1e3df058fbd3bdec478c62d82f63fb248032e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-01-14Bug 569189 - Fix feature descriptionI20210114-1800Alexander Kurtakov1-2/+1
It shouldn't claim to contain JRE-1.1, J2SE-1.2, J2SE-1.3, J2SE-1.4, J2SE-1.5, JavaSE-1.6, JavaSE-1.7, JavaSE-1.8 profiles as they have been removed. Change-Id: I8205c50cb7e7a6b68074211e11f02503d053f665 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Bug 570222 - Move org.eclipse.tools.layout.spy to Java 11I20210114-0510I20210114-0310I20210112-1800I20210112-0850I20210111-1800I20210110-1800Alexander Kurtakov4-11/+34
It has dependencies already on Java 11 so it's safer to move it. It also fixes warnings in the workspace. Change-Id: I8b33c81d10d540cc5f497c3ac002533235cb5edd Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Remove useless non-javadoc comments.Alexander Kurtakov17-125/+0
Change-Id: Ia8e1b7f90c90b37d4aa1e44b35c88408455c76f7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Don't link to Workbench in javadoc.Alexander Kurtakov1-2/+1
It's not API and this generates warnings in the workbench. Navigating to Workbench from the javadoc still works. Change-Id: I38f4d5865ee3a92a4c52cb0cd5238cf9debaa08e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Version bump for 4.19Alexander Kurtakov2-2/+2
Needed by https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/174536 Change-Id: Ifc1b12c52ecc90af41ab04461c22a1e52b811c78 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Version bump for 4.19Alexander Kurtakov2-2/+2
Needed by https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/174538 Change-Id: I531f52c8ee99abacc6772f2aa654adcce6b7ad07 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Remove useless @see comments.Alexander Kurtakov10-87/+3
Documentation is properly covered by Override annotation. Fixed some typos where spotted too. Change-Id: I4871b4c2d25a5e905fd18308127ccd4a0ac7a08a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Use Collections.empty* methodsAlexander Kurtakov3-7/+7
To get generified collections rather than non-generified constants. Change-Id: I3f47558d2bbd77e37b040b395ad3c6d05ec03f03 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-10Bug 570219 - Move o.e.ui.trace to Java 11Alexander Kurtakov4-11/+34
Change-Id: Ide62b8177ed4a181e5a3313ff82262217f9bf698 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-09Fix deprecated File.toURL usage in testAlexander Kurtakov1-2/+2
Change-Id: I88b855b9de4f10985ae7f4c937d03c9d7df5eed1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-09Version bump for 4.19.I20210109-1830Alexander Kurtakov2-2/+2
Needed byhttps://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/174533/ Change-Id: I6f04a36cc10823a0fc254ea2d216cf84fa746700 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>

Back to the top