diff options
| author | Alexander Fedorov | 2018-11-24 09:00:07 +0000 |
|---|---|---|
| committer | Vikas Chandra | 2018-11-27 12:53:18 +0000 |
| commit | fa02fe6675537ac5c0fca92742651b748da82718 (patch) | |
| tree | 2f603dd7b7308c11b4d31198473fb03654616d6b | |
| parent | 6a9933c2bc439754b0106c01abd7f3502276558e (diff) | |
| download | eclipse.pde.ui-fa02fe6675537ac5c0fca92742651b748da82718.tar.gz eclipse.pde.ui-fa02fe6675537ac5c0fca92742651b748da82718.tar.xz eclipse.pde.ui-fa02fe6675537ac5c0fca92742651b748da82718.zip | |
Bug 541511 - Editing a .target file make the code mining vanishY20181205-2200Y20181204-0315Y20181128-2200S4_10_0_RC2S4_10_0_RC1R4_10I20181206-0815I20181206-0320I20181206-0225I20181206-0030I20181205-1800I20181205-0600I20181204-1800I20181204-0600I20181203-1800I20181203-0600I20181202-1800I20181202-0600I20181201-1800I20181201-0600I20181130-1800I20181129-0330I20181128-1800I20181128-1105I20181128-0810I20181128-0600I20181128-0130I20181127-1800R4_10_maintenance
Use "target" element start line and line=0 for invalid cases
Change-Id: I5e5b263c4dc160c2369c51994ac99719f6d84167
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
| -rw-r--r-- | ui/org.eclipse.pde.genericeditor.extension/src/org/eclipse/pde/internal/genericeditor/target/extension/codemining/TargetDefinitionCodeMiningProvider.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/ui/org.eclipse.pde.genericeditor.extension/src/org/eclipse/pde/internal/genericeditor/target/extension/codemining/TargetDefinitionCodeMiningProvider.java b/ui/org.eclipse.pde.genericeditor.extension/src/org/eclipse/pde/internal/genericeditor/target/extension/codemining/TargetDefinitionCodeMiningProvider.java index d374e33692..6c8061a62e 100644 --- a/ui/org.eclipse.pde.genericeditor.extension/src/org/eclipse/pde/internal/genericeditor/target/extension/codemining/TargetDefinitionCodeMiningProvider.java +++ b/ui/org.eclipse.pde.genericeditor.extension/src/org/eclipse/pde/internal/genericeditor/target/extension/codemining/TargetDefinitionCodeMiningProvider.java @@ -46,18 +46,20 @@ public class TargetDefinitionCodeMiningProvider extends AbstractCodeMiningProvid } void fillCodeMinings(IDocument document, List<ICodeMining> minings) throws BadLocationException { + int line = 0; try { Parser parser = Parser.getDefault(); parser.parse(document); Node target = parser.getRootNode(); if (target != null) { - minings.add(new TargetDefinitionActivationCodeMining(2, document, this, null)); + line = document.getLineOfOffset(target.getOffsetStart()); + minings.add(new TargetDefinitionActivationCodeMining(line, document, this, null)); } else { - minings.add(new TargetDefinitionActivationCodeMining(2, document, this, + minings.add(new TargetDefinitionActivationCodeMining(line, document, this, Messages.TargetDefinitionCodeMiningProvider_e_format_invalid)); } } catch (XMLStreamException e) { - minings.add(new TargetDefinitionActivationCodeMining(2, document, this, + minings.add(new TargetDefinitionActivationCodeMining(line, document, this, Messages.TargetDefinitionCodeMiningProvider_e_format_invalid)); } } |