Bug 572215 - Use JDT static inner class clean up in PDE api toolsI20210506-1800

This ticket uses and tests the "Use static inner class" cleanup feature:
 - It reviews the feature
 - It reduces the memory consumption as it avoids the pointer to the
outer class

Example:

Before:

public class Outer {

public class InnerClass {
    int i;

    public boolean anotherMethod() {
        return true;
    }
}
}

After:

public class Outer {

public static class InnerClass {
    int i;

    public boolean anotherMethod() {
        return true;
    }
}
}

Change-Id: I6d5c01fb79bfb89059430138bc1c9ffcac1ae959
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180215
Tested-by: PDE Bot <pde-bot@eclipse.org>

9 files changed, 9 insertions, 9 deletions

diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java
index 0a47227ebc..1b3efbb51b 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java
+++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java
@@ -61,7 +61,7 @@ public class ApiDescriptionTests {
 	/**
 	 * Wraps an element with its API description
 	 */
-	class ElementDescription {
+	static class ElementDescription {
 
 		public IElementDescriptor fElement;
 		public int fVis, fRes;
diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java
index ea63d84be3..b1b95e90c7 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java
+++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java
@@ -92,7 +92,7 @@ public class ApiBaselineManagerTests extends AbstractApiTest {
 	static final String TESTDEFAULT = "testdefault"; //$NON-NLS-1$
 	static final String ADDTEST = "addtest"; //$NON-NLS-1$
 
-	class SourceChangeVisitor extends ASTVisitor {
+	static class SourceChangeVisitor extends ASTVisitor {
 		String name = null;
 		String signature = null;
 		String tagname = null;
diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiDescriptionProcessorTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiDescriptionProcessorTests.java
index 96c3bbb210..df66ffb36a 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiDescriptionProcessorTests.java
+++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiDescriptionProcessorTests.java
@@ -81,7 +81,7 @@ public class ApiDescriptionProcessorTests extends AbstractApiTest {
 	 * added to ensure the tags as specified in the component.xml file were
 	 * added.
 	 */
-	class ChangeVisitor extends ASTVisitor {
+	static class ChangeVisitor extends ASTVisitor {
 		String type, membername, signature, innertypename;
 
 		String[] expectedtags = null;
diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/ApiDescription.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/ApiDescription.java
index 46136f3dfc..3dad9d1d44 100644
--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/ApiDescription.java
+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/ApiDescription.java
@@ -99,7 +99,7 @@ public class ApiDescription implements IApiDescription {
 	/**
 	 * Represents a single node in the tree of mapped manifest items
 	 */
-	class ManifestNode {
+	static class ManifestNode {
 		protected IElementDescriptor element = null;
 		protected int visibility, restrictions;
 		protected ManifestNode parent = null;
diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/AbstractProblemDetector.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/AbstractProblemDetector.java
index 52d6416f44..f62f38fb18 100644
--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/AbstractProblemDetector.java
+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/AbstractProblemDetector.java
@@ -77,7 +77,7 @@ public abstract class AbstractProblemDetector implements IApiProblemDetector {
 	 * {@link IApiType} when we do not have any enclosing method infos (pre Java
 	 * 1.5 class files
 	 */
-	class MethodFinder extends ASTVisitor {
+	static class MethodFinder extends ASTVisitor {
 		IMethod method = null;
 		private IType jtype = null;
 		private ApiType type = null;
diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/IncrementalApiBuilder.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/IncrementalApiBuilder.java
index 753c8a8936..9b39955037 100644
--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/IncrementalApiBuilder.java
+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/IncrementalApiBuilder.java
@@ -67,7 +67,7 @@ public class IncrementalApiBuilder {
 	private static final int STRUCTURAL = 0x0001;
 	private static final int DESCRIPTION = 0x0002;
 
-	class Change {
+	static class Change {
 		int changeKind; // STUCTURAL | DESCRIPTION
 		int fileKind; // JAVA | CLASS
 		int deltaKind;
diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/ProjectTypeContainer.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/ProjectTypeContainer.java
index 13a2087400..2ecf9385d9 100644
--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/ProjectTypeContainer.java
+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/ProjectTypeContainer.java
@@ -46,7 +46,7 @@ public class ProjectTypeContainer extends ApiElement implements IApiTypeContaine
 	 *
 	 * @since 1.1
 	 */
-	class ContainerVisitor implements IResourceProxyVisitor {
+	static class ContainerVisitor implements IResourceProxyVisitor {
 
 		List<String> collector = null;
 		int segmentcount = 0;
diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/ConsumerReportConvertor.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/ConsumerReportConvertor.java
index 3647311c84..321a512637 100644
--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/ConsumerReportConvertor.java
+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/ConsumerReportConvertor.java
@@ -53,7 +53,7 @@ public class ConsumerReportConvertor extends UseReportConverter {
 	 * Use scan visitor that collects a list of the bundles (as
 	 * {@link IComponentDescriptor}s) that consume api references.
 	 */
-	class ListConsumersVisitor extends UseScanVisitor {
+	static class ListConsumersVisitor extends UseScanVisitor {
 		/**
 		 * Set of {@link IComponentDescriptor}s representing the consumers of
 		 * references
diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/MissingRefParser.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/MissingRefParser.java
index 9a7d58480e..f042349900 100644
--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/MissingRefParser.java
+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/MissingRefParser.java
@@ -39,7 +39,7 @@ import org.xml.sax.helpers.DefaultHandler;
 
 class MissingRefParser extends UseScanParser {
 
-	class MissingRefProblemHandler extends DefaultHandler {
+	static class MissingRefProblemHandler extends DefaultHandler {
 
 		List<IApiProblem> problems = new ArrayList<>();
 		private String typename;