diff options
| author | Christoph Läubrich | 2021-12-21 15:06:00 +0000 |
|---|---|---|
| committer | Lars Vogel | 2021-12-22 12:12:24 +0000 |
| commit | d184fe0d16882b06fd7ccb80af6c9cf12755b298 (patch) | |
| tree | a747c56867c3003dca9bdafc7c06518ea0c54011 | |
| parent | bcbf07b0a50c8e0eda370887acccb081940a0751 (diff) | |
| download | eclipse.pde.ui-d184fe0d16882b06fd7ccb80af6c9cf12755b298.tar.gz eclipse.pde.ui-d184fe0d16882b06fd7ccb80af6c9cf12755b298.tar.xz eclipse.pde.ui-d184fe0d16882b06fd7ccb80af6c9cf12755b298.zip | |
Bug 577927 - provide a better error message
Change-Id: Ie05d05f24436761adfe48c9a3ce8a7c691c246fa
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Reviewed-on: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/189053
Tested-by: PDE Bot <pde-bot@eclipse.org>
Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
| -rwxr-xr-x | ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/Messages.properties | 2 | ||||
| -rw-r--r-- | ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetPlatformService.java | 9 |
2 files changed, 9 insertions, 2 deletions
diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/Messages.properties b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/Messages.properties index 4c96a54deb..2465fc78c5 100755 --- a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/Messages.properties +++ b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/Messages.properties @@ -61,7 +61,7 @@ TargetDefinitionPersistenceHelper_WrongRootElementInXML=XML for target locations TargetFeature_FileDoesNotExist=File does not exist: {0} TargetPersistence38Helper_NoTargetLocationExtension=Could not find a org.eclipse.pde.core.targetLocations extension for type: {0} TargetPlatformService_0=Unable to restore target memento -TargetPlatformService_1=Unrecognized target memento scheme +TargetPlatformService_1=Unrecognized target memento scheme '{0}', supported scheme are {1} TargetPlatformService_2=Target extension does not exist: {0} TargetPlatformService_3=Error reading target extension file: {0} TargetPlatformService_4=Target extension file does not exist: {0} diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetPlatformService.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetPlatformService.java index 4e99176e93..acda7fd1c5 100644 --- a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetPlatformService.java +++ b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/TargetPlatformService.java @@ -32,6 +32,8 @@ import java.util.List; import java.util.Map; import java.util.Objects; import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IResourceProxy; @@ -174,7 +176,12 @@ public class TargetPlatformService implements ITargetPlatformService { } catch (URISyntaxException e) { throw new CoreException(Status.error(Messages.TargetPlatformService_0, e)); } - throw new CoreException(Status.error(Messages.TargetPlatformService_1, null)); + throw new CoreException( + Status.error(NLS.bind(Messages.TargetPlatformService_1, memento, + Stream.of(WorkspaceFileTargetHandle.SCHEME, LocalTargetHandle.SCHEME, + ExternalFileTargetHandle.SCHEME, RemoteTargetHandle.SCHEME) + .collect(Collectors.joining(", "))), //$NON-NLS-1$ + null)); } @Override |
