Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulian Honnen2020-06-16 07:56:22 +0000
committerJulian Honnen2020-06-16 09:18:45 +0000
commit712f656b63c4583aa69b56416a2a7d3428ed4ad2 (patch)
treee72c414817c3b512b7e4a8f5a4b6099372053ccb
parentdcfa044502b13c30c56a41b0d4fcca8ea0608dc6 (diff)
downloadeclipse.pde.ui-712f656b63c4583aa69b56416a2a7d3428ed4ad2.tar.gz
eclipse.pde.ui-712f656b63c4583aa69b56416a2a7d3428ed4ad2.tar.xz
eclipse.pde.ui-712f656b63c4583aa69b56416a2a7d3428ed4ad2.zip
Bug 564320 - avoid redundant viewer refreshI20200616-0620
Omit the pointless refresh by handleFilterButton() during initialization if the filter is disabled to improve performance. Change-Id: Ia02d33447df125fd9fff19277b41ce18bd1535d5 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
-rw-r--r--ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/AbstractPluginBlock.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/AbstractPluginBlock.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/AbstractPluginBlock.java
index 58ff403665..fbe9470bcd 100644
--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/AbstractPluginBlock.java
+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/AbstractPluginBlock.java
@@ -1035,7 +1035,10 @@ public abstract class AbstractPluginBlock {
resetGroup(fWorkspacePlugins);
resetGroup(fExternalPlugins);
- handleFilterButton(); // Once the page is initialized, apply any filtering.
+ if (fFilterButton.getSelection()) {
+ // Once the page is initialized, apply any filtering.
+ handleFilterButton();
+ }
updateCounter();
}

Back to the top