diff options
| author | Lars Vogel | 2021-05-05 09:24:08 +0000 |
|---|---|---|
| committer | Lars Vogel | 2021-05-07 08:37:55 +0000 |
| commit | 11070384e058d28bc3187662ca270c693f00c658 (patch) | |
| tree | 4a093d2a7f233873947a992fa2f6b979830e5bd3 | |
| parent | efcc20cb8e5b252040c3ac7889c3dfe92b37bfc1 (diff) | |
| download | eclipse.pde.ui-11070384e058d28bc3187662ca270c693f00c658.tar.gz eclipse.pde.ui-11070384e058d28bc3187662ca270c693f00c658.tar.xz eclipse.pde.ui-11070384e058d28bc3187662ca270c693f00c658.zip | |
Bug 572215 - Use JDT static inner class clean up in PDE ds plug-insI20210512-2250I20210512-1800I20210511-1800I20210511-0740I20210511-0330I20210511-0200I20210510-1800I20210509-1800I20210508-1800I20210507-1800
This ticket uses and tests the "Use static inner class" cleanup feature:
- It reviews the feature
- It reduces the memory consumption as it avoids the pointer to the
outer class
Example:
Before:
public class Outer {
public class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
After:
public class Outer {
public static class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
Change-Id: I9dee2ae400cfe46b9828ccacd1ed7aec3f43b46c
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Change-Id: I9dee2ae400cfe46b9828ccacd1ed7aec3f43b46c
Change-Id: I9dee2ae400cfe46b9828ccacd1ed7aec3f43b46c
Reviewed-on: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180217
Tested-by: PDE Bot <pde-bot@eclipse.org>
Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
4 files changed, 4 insertions, 4 deletions
diff --git a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/DSTypeSelectionExtension.java b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/DSTypeSelectionExtension.java index d0f51faf4f..353be864f8 100644 --- a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/DSTypeSelectionExtension.java +++ b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/DSTypeSelectionExtension.java @@ -27,7 +27,7 @@ public class DSTypeSelectionExtension extends TypeSelectionExtension { private IDSModel fModel; - class TypeInfoFilterExtension implements ITypeInfoFilterExtension { + static class TypeInfoFilterExtension implements ITypeInfoFilterExtension { List<String> fProvides = new ArrayList<>(3); diff --git a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSPropertiesSection.java b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSPropertiesSection.java index cb07bc3aca..256481b2a5 100644 --- a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSPropertiesSection.java +++ b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSPropertiesSection.java @@ -76,7 +76,7 @@ public class DSPropertiesSection extends TableSection { private static final int F_UP_FLAG = -1; private static final int F_DOWN_FLAG = 1; - class ContentProvider implements IStructuredContentProvider { + static class ContentProvider implements IStructuredContentProvider { @Override public Object[] getElements(Object inputElement) { if (inputElement instanceof IDSModel) { diff --git a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSProvideSection.java b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSProvideSection.java index 7127280019..ba60c852d4 100644 --- a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSProvideSection.java +++ b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSProvideSection.java @@ -73,7 +73,7 @@ public class DSProvideSection extends TableSection implements private Action fAddAction; private Action fEditAction; - class ContentProvider implements IStructuredContentProvider { + static class ContentProvider implements IStructuredContentProvider { @Override public Object[] getElements(Object inputElement) { if (inputElement instanceof IDSModel) { diff --git a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSReferenceSection.java b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSReferenceSection.java index cfa1f5ba24..8318862816 100644 --- a/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSReferenceSection.java +++ b/ds/org.eclipse.pde.ds.ui/src/org/eclipse/pde/internal/ds/ui/editor/sections/DSReferenceSection.java @@ -114,7 +114,7 @@ public class DSReferenceSection extends TableSection implements } - class ContentProvider implements IStructuredContentProvider { + static class ContentProvider implements IStructuredContentProvider { @Override public Object[] getElements(Object inputElement) { if (inputElement instanceof IDSModel) { |