Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/tests
AgeCommit message (Collapse)AuthorFilesLines
2021-11-03Bug 575255: [Toolsmiths] Remove genextension EPackage from the gmf.codegen ↵Vincent Lorenzo3-52/+19
metamodel + remove migration tool Change-Id: I8440d4981ab460f9703edf636fbfdd39a7e8f705 Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-10-28Bug 563212 - [Diagram] Containment link cannot be deleted (semanticPauline DEVILLE6-22/+50
delete) Change-Id: I882428defece0f05398d50ae1fe019df94fb8507 Signed-off-by: Pauline DEVILLE <pauline.deville@cea.fr>
2021-10-25Bug 573986: [Toolsmiths] Properties view editor validation & incrementalChristian W. Damus95-92/+6339
updates Common fixes - fix encoding and decoding of related object URIs in the problem markers - handle stereotypes in nested packages (not profiles) - fix NPE in architecture builder - prompt to save editor before running quick fix if it's dirty - save editor after running quick fix - save and clean up resources loaded by the quick fix that the editor doesn't need to know about - delete cross-references within the scope of context models when deleting a data-context element, to account for supertype references, both in the editor and the quick fix Properties validation builder - add new validation builder plug-in for Properties models - check plugin.xml extensions for context and environment models - check existence of referenced Java classes and implied bundle dependencies - handle 'ppe' URI scheme in ModelDependenciesChecker via new generic service - ensure that HREFs to environment models that do not use XMI IDs are not broken by automatic assignment of IDs on resource load - ensure that XMI IDs are generated in context resources - add annotations to the generated Properties Context model to trace to the original source model (UML Profile or Ecore model) - add annotations to data context roots to record which layout generator was used to generate sections (used for quick fixes) - hide annotations from the editor by default because they need not (and probably should not) be edited by the user - infer traceability to source models from known constraints and internal relationships in the context model - add derived reference to views that use a section, supported by generated CacheAdapter implementation - add model validation rules for missing and obsolete data context elements and properties in the context model - add custom validation rules for EMFInstanceOf, UMLInstanceOf, and HasStereotype constraints, that their referenced classes can be resolved - validate that data-context properties, elements, and packages match their corresponding source model elements by name - quick fixes to rename data-context properties, elements, and packages to match their source model elements - includes 'touching' affected XWT resources to ensure that their qualified name references are updated - add check for missing data-context package for nested package/profile - check for entire source package/profile moved Add marker resolutions for - simple property-type inconsistency problems - delete obsolete data-context properties - add missing data-context properties - add missing data-context properties with property editors in sections - delete obsolete data-context elements - add missing data-context elements - add missing data-context elements with generated views - quick fixes to generate data-context package with or without views - add quick fix to find new package/profile location and update all source link URIs - add a quick fix for unresolved class problems in constraints - get appropriately qualified "expected name" of the class referenced by a constraint for population of marker data for the quick fix - generate a fix for each valid name that the constraint can reference Change-Id: Iebd062470d7539d15321cffa80556fc1d22023f2 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-10-20Bug 576595: [ModelExplorer] Fix the action "Open In New Table"Vincent Lorenzo14-14/+14
Change-Id: Ie57c5502716a9e11c35d410eeb82c7970bc0a119 Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-10-20Bug 574511: [Diagram] Update plugins version/ Check API break after diagram ↵Vincent Lorenzo33-73/+51
regeneration - update version for gmf-tooling - update version for uml diagram common - update version for sequence diagram - update version for activity diagram - update version for diagram component - update required manifest.MF and pom.xml files - remove old api filters files Change-Id: I8a53fbcc92146bcb05bf04205c485a0ff2b7945e Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-10-19Bug 575254: [Toolsmiths] Remove the plugin org.eclipse.papyrus.gmfgenextensionVincent Lorenzo2-45/+0
Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr> Change-Id: I560e7206ce15f5af7bee91eb30453d13fe71ad81
2021-10-19Bug 569174: [Toolsmiths] Papyrus integration of GMF Tooling - Fix Junit TestsVincent Lorenzo1-22/+48
L1.2 clean up - FIX Junit tests org.eclipse.papyrus.infra.gmfdiag.canonical.tests.EditingInClassDiagramRegressionTest.createDependencyInClass (execute/undo/redo) Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr> Signed-off-by: Etienne Allogo <etienne.allogo@artal.fr> Change-Id: I50e5fb46c7f7dc286d977b60d5b1ea578d306000
2021-10-19Bug 569174: [Toolsmiths] Papyrus integration of GMF Tooling - merge xtend ↵Etienne Allogo1-1/+0
template L1.4. Merge papyrus templates (org.eclipse.papyrus.def/xtend) into org.eclipse.papyrus.codegen/xtend Signed-off-by: Etienne Allogo <etienne.allogo@artal.fr> Change-Id: Ic159b50b6866a704c0c5928ded7d429347760e37
2021-10-19Bug 569174: [Toolsmiths] Papyrus integration of GMF ToolingEtienne Allogo3-22/+25
- 1.3 Merge gmfgenextension] pre merge step - move gmfgenextension to gmfgen.ecore 1 - Move generated model files from org.eclipse.papyrus.papyrusgmfgenextension to org.eclipse.papyrus.gmf.codegen.genextension 2 - Mode ecore definition papyrusgmfgenextension.ecore to gmfgen.ecore as a sub package of gmfgen (genextension) 3 - Generate model( and edit-or) into org.eclipse.papyrus.gmf.codegen.gmfgen and org.eclipse.papyrus.gmf.codegen.genextension 4 - Fix non java files (gmfgen + plugin.xml etc) 5 - Keep popup actions in org.eclipse.papyrus.papyrusgmfgenextension for now Signed-off-by: Etienne Allogo <etienne.allogo@artal.fr> Change-Id: I3f670ce66aa6b498bd3696f7721ad248dacd6243
2021-09-02Bug 573410: [Toolsmiths] Plug-in builder reports spurious problems in ↵Christian W. Damus33-0/+2119
Expansion Models - update the validation to use the ClasspathHelper to support classes in the JDT workspace classpath - add JUnit test coverage Change-Id: Ie6337c57b4a574f7bc47fe07c1d3f8de88deccd4 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-09-02Bug 569105: [Toolsmiths] The "Remove Reexport" quickfix may create invalid ↵Christian W. Damus2-51/+58
Manifest directives - do not add a null value for a header attribute/directive that was not present Change-Id: I36872c7803730655e48a62c4dc72c5383aa2b7c5 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-30Bug 574690: [Toolsmiths - Quickfixes] Add folder to build.properties should ↵Christian W. Damus2-0/+118
ignore nested folders - update the quick fix to add the topmost folder to the build, not the immediate container of the file Change-Id: Ie9a4813945066ae0666cdd77053393b1be2aff6e Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-30Bug 573888: the papyrus builder raises an error on the profile referenced in ↵Christian W. Damus3-0/+116
the AF - ensure that package/profile registrations on the EMF and UML2 extension points that use platform:/plugin URIs are resolved into the workspace where applicable Change-Id: I859ff15a80cfc5cc4fab9168657f7ad9503ad792 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-30Bug 573042: Spurious indexingChristian W. Damus1-0/+38
- do not index derived resources in the workspace Change-Id: Iefde5547bf8722d73d0f3707ec1d07fcccd7ab88 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-25Bug 573886: An incorrectly completed NS URI can make the AF wobblyChristian W. Damus6-4/+243
- add a custom Profile validation rule checking for relative URIs Change-Id: I629400f6001ab860544b7d80b940810345ab682b Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-25Bug 573245: [Toolsmiths] Remove plug-in validation context menu actionsChristian W. Damus2-45/+18
- remove the plug-in extensions for the menu actions and supporting bits such as expression property testers - remove internal APIs used by the menu actions - deprecate public APIs that were only used by the menu actions, reimplemented by delegation to project build - adjust JUnit test cases to account for these changes - update the documentation guide for the plug-in validation to remove references to the menu actions Change-Id: I9426d011c4b0140d776a6b7dd2761e6a01b5e8de Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-25Bug 573788: [Toolsmiths] Generic representation clean-up adviceChristian W. Damus17-13/+560
- create a generic representation (view) deletion advice that works with any user-defined representation kind - add a context menu action to the Architecture Model that adds this advice to an architecture context - add a custom toolsmiths validation warning for architecture contexts that do not reference, inherit, or get by extension this new advice, unless the context is an extension of other contexts - add a bit of documentation about quick fix APIs Change-Id: I58ce20d7d9654d5c5204a7a01c505d143a0328af Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-08-09Bug 575205: [Core, model indexer] Race condition workspace model indexerChristian W. Damus3-174/+282
- do not use JobManager::join to wait for idle state of indexing - aggregate after-index computations onto a single job to avoid flooding the JobManager with tiny JobBasedFutures - add new listener mechanism in IndexManager to improve testability of synchronization scenarios involving the JobWrangler job - ensure isolation of WorkspaceModelIndex tests for consistent execution Change-Id: Icb915bebb8a90e46e29aafe3b788c18ade42033d Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-07-13Bug 572633: [Toolsmiths] New Child Menus: plug-in builderChristian W. Damus47-8/+2011
- create a New Child Menu validation bundle with the plug-in checker implementation - implement role validation based on a workspace-wide Element Types Configurations index on a refactoring of the Architecture Domain model index - integrate the New Child Menu plug-in checkers into the Papyrus Project Builder - support plug-in relative paths for icons in creation menu models in addition to absolute URIs - avoid unintended automatic builds during plug-in builder tests - add documentation of the new child plug-in validation Change-Id: Iadbbd7515a092290d5b66d17ff22676d330f61c3 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-07-13Bug 573656: [Welcome Page] Concurrent Modification issue on Welcome page ↵Christian W. Damus9-48/+233
while generating Element Types for a profile Privileged runnables cannot be run asynchronously, otherwise there is every possibility that the transaction that owns them will no longer be active when the runnable runs. So, instead, create a new read-only transaction in the asynchronous runnable to process the notifications and update the observable property on the UI thread. Change-Id: I35ce6845415d8a90108bca5a1877c7c0b11b747a Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-07-13Bug 572676: [Toolsmiths] Profiles without a URI are not properly handled by ↵Christian W. Damus9-3/+431
the Validators/Quickfixes - update static profile utility to account for profiles having no URI for which the EMF Model Importer would generate a namespace URI - use the utility in Element Types Configurations validation builder - add JUnit test coverage for UML Profile validation builder - so that there will be no test failures, incorporate a fix for extant UML Profile project builder test failure from another Gerrit patch Change-Id: Id4195d706f0eb1c6df9a8ac2d8f999f70d337247 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-07-13Bug 573408: [Toolsmiths] GenericEMFModelBuilder tries to validate CSS filesChristian W. Damus1-0/+3
- skip CSS files in the generic EMF model validation - ensure that resources loaded for validation are unloaded - only try to parse XMLResources for XML namespaces - don't read and parse entire model file to get XML namespaces - attempt to fix intermittent failure of an Architecture Builder test Change-Id: Ib8db7339ad6b2a43a2b5a38a5b612b4c548eec1a Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-06-01Bug 573885: ElementTypes are badly generatedChristian W. Damus16-2/+707
- account for indirectly applied profiles on nested packages in the stereotype application matcher/advice implementation Change-Id: I19acbbb9fd2596926a1a4952da2770f77e273309 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-05-04Bug 570486: [Architecture] Architecture model shall clearly define merge and ↵Christian W. Damus6-42/+204
inherit concepts - warn on implicit merges Change-Id: Id9a4a1821dd985812892113a801173fba5b8fb9d Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-30Bug 572677: [Toolsmiths] Duplicate extensions for "Missing ↵Christian W. Damus12-63/+394
oepu.extensionpoints.UMLProfile" quickfix - in the case of generating a new element, only add it to the plug-in model after configuring it - fix up some method signatures for methods that access markers to let them throw CoreException - add JUnit test coverage for affected quick fixes - while we're at it, add all of the validation builder tests to the Toolsmiths test suite - and fix the UML Profile validation build test failures - fix case mismatch in file name in ModelDependenciesCheckerTest Change-Id: Ifcf9bf83cbc282cf7898df6c819ade02c36c0c6e Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-30Bug 572712: [NewChild] Creation menu edit providers do not support child ↵Christian W. Damus3-14/+155
creation extenders - add an indirection filter to enable sharing filters amongst constraint rules in Element Creation Menu models, Modeling Assistant models, and other dependent models - also with the option to own the filter to access child creation extenders - incorporate operator into label of compound filters for clarity - regenerate dependent models' EMF.Edit plug-ins, cleaning out creation icons where possible Change-Id: I0846b7e47180e381f0774e1858e6b51c53b74d3d Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-30Bug 570486: [Architecture] Architecture model shall clearly define merge and ↵Christian W. Damus42-84/+2474
inherit concepts - implement new architecture domain merger with support for legacy algorithm - update ArchitectureDomainManager and ArchitectureDomainMerger to be safe in concurrent access from the ArchitectureIndex - adapt look-up of creation and conversion command classes to trace the class name to the source architecture model for the most appropriate bundle context - update Architecture View to use the public merged model API - adapt old merge tests to use new API - add more test coverage of legacy merge - test coverage of legacy merge mixed with explicit extensions - test coverage for mixing context inheritance with context extension - improve test coverage of the Merged Architecture façade API - update documentation to describe new inheritance and extension concepts, and the merge algorithm - add tracing options for analysis of run-time problems in architecture merge Change-Id: I939d252e7ccdcc55ec81e54ba2b9677616d2d488 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-28Bug 571125: [Toolsmith] Improve icon validation for toolsmith validationChristian W. Damus1-5/+10
- unify validation of icons referenced by model elements - covers opaque resources of all kinds, not just icons: e.g., creation/conversion command classes in Architecture models - covers resources referenced from model files and from plugin.xml - add calculation of required bundle dependencies from command-class features that are constrained to implement some interface, the bundle providing that interface type being a required dependency. This helps to diagnose problems in resolving commands when the JDT classpath of the architecture bundle does not include the required interface Change-Id: I70db66a448d13cd989da3aeb51b54d2995d273b6 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-28Bug 573197: [Toolsmiths] Exception in ValidateElementTypesPluginTesterChristian W. Damus3-3/+94
- do not attempt to access closed projects - use a resource visitor instead of recursion Change-Id: I370c0a033fb960d78f25e3a3974ae459108beb32 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-27Bug 571629: [Properties] Undo fails and other problems with applied stereotypesChristian W. Damus4-50/+240
- use edit service to get apply/unapply stereotype commands - compose commands for multiple selection removal and dialog scenario - implement a stereotype application reordering command with correct undo/redo - correct support for reordering of multiple selection - dynamic enablement of buttons - account for unspecified ordering of multiple selections in a tree - apply and unapply profiles also needs to go through the edit helpers Change-Id: I42d35823b8743ffeec4114051adcff4883eb324a Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-27Bug 571561: [Element Types] Simple rule configuration refactoringsChristian W. Damus7-48/+488
- add refactoring actions for rule-based element type rules - account for non-containment of NotRuleConfiguration::composedRule (bug 571560) Change-Id: Ie32f0524429801ca0ccbc6b91863403161c74f7e Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-26Bug 570486: [Architecture] Architecture model shall clearly define merge and ↵Christian W. Damus18-5/+1488
inherit concepts Updates to the Architecture Description model. Changes: - make ArchitectureContext::creationCommandClass optional ([0..1] multiplicity) as it is now not required by a context that extends another context Additions in class ArchitectureContext: - reference extendedContexts: ArchitectureContext [*] — the contexts to which this context contributes elements such as viewpoints - reference generalContext: ArchitectureContext [0..1] — a context that this context specializes to define a new instantiable context based on it - attribute /extension: Boolean — whether the context is an extension of one or more other contexts. An extension context cannot be instantiated in it own right and does not appear in the New Model Wizard and other UIs that present architecture contexts - operation isConsistentWith(context: ArchitectureContext): Boolean — query whether this context is consistent with another one with respect to extension or generalization. For now the only condition is that they are of the same class (an ArchitectureFramework is not consistent with an ArchitectureDescriptionLanguage and vice versa) - operation allGeneralContexts(): ArchitectureContext [*] — computes the chain of all contexts that this context inherits - operation allExtendedContexts(): ArchitectureContext [*] — computes the closure of all extended contexts. If context C extends context B and B extends context A, then by transitivity C extends context A also. But note that extension of contexts is not inherited: a context C with a general context B that extends context A does not, itself, extend A. But if C does also references A as an extended context, then that makes B's extension of A moot when C is also present in the architecture registry (the merge algorithm will need to account for this) Constraints in class ArchitectureContext: - generalizationCycle — an ArchitectureContext must not specialize itself, either directly or indirectly - extensionCycle — an ArchitectureContext must not extend itself, either directly or indirectly - generalNotExtended — none of the extended contexts of an ArchitectureContext may extend any of its general contexts as this would effectively result in it extending itself. Note that I see no reason why a context that is a specialization of another context may not also be an extension of yet other contexts, so long as this constraint is satisfied - creationCommandClassRequired — an ArchitectureContext that is not an extension must have a creationCommandClass (this replaces the previous multiplicity constraint that is now relaxed) - contextGeneralizationIsConsistent — an ArchitectureContext may only specialize a general context that is consistent with it (which for now is just that it is of the same class) - contextExtensionIsConsistent — an ArchitectureContext may only extend a context that is consistent with it (which for now is just that it is of the same class) Change-Id: I9ccf7210f4bf82d930226d1e1c20eec62e1da488 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-26Bug 570716: [Tests] Fix ReloadEditorTest failureChristian W. Damus4-122/+177
- annotate the test as failing. Cause for failures in CI build undetermined - clean up deprecation warnings as this file is now modified Change-Id: I02110ed6157d725c1f184e084a03d85a95e0ebc7 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-26Bug 572865: [Toolsmiths] Architecture Editor may break because of the new ↵Christian W. Damus10-3/+311
PlatformHelper - handle case of package registration without a genmodel which is common in compatibility scenarios mapping older NS URIs to the current version of a package - while we're at it, the URI mapping parsing needs the same bullet-proofing - add JUnit regression test coverage Change-Id: I881f214f04349dafa4243bbe2b3e0cd8fbbd729d Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-15Bug 570716: [Tests] Sequence diagram validation test regressionChristian W. Damus3-55/+52
- another test failure cause by Eclipse OCL 6.14's thread-local management of environment factories. This time tests run fast enough that the OCL environment for an editor of a previous test isn't collected by the time the next test tries to set the environment, which results in OCL balking at multiple concurrent environments and OCL being unavailable to that test and all subsequent tests Change-Id: Ice4c85d0edcaa061a2cf462dea97901133a11f23 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-14Bug 570716: [Tests] Fix Modeling Assistant test failuresChristian W. Damus2-44/+45
Fix modeling assistant test failures in the nightly build. These did actually signal a bug affecting normal Papyrus editing functionality: drawing out a connection handle to create new elements did not suggest any connection types from the assistants model. Change-Id: Ifeba21644f67baf592e8ebbc702e330d35ced17c Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-12Bug 570716 - [Tests] Fix some JUnits TestsVincent Lorenzo5-6/+16
Change-Id: I029eb04f9c7a47f5e7907ca69e58d36db5ae9fba Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-04-12Bug 539694: The Architecture models raises bad errorsChristian W. Damus3-23/+76
- fix case of workspace-wide JDT search without context URI broken by earlier fix - ensure that JDT and Java projects are ready when running tests with Maven Change-Id: If65d2334ee653286d8ddbed01765093135893ba5 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-12Bug 572532: [Tests] UML validateCamelCaseRule test fails consistentlyChristian W. Damus3-29/+86
OCL Pivot maintains environments on a per-thread basis, which means the Modal Context thread cannot use an environment set up by pre-validation hooks on the main thread. Thus this pre-processing needs to be performed on the Modal Context thread also and the test needs to be updated to use the hook mechanism to inject its OCL constraints from the file. Change-Id: Id3fdb3b9f8ab876d9ad6a7b39500684c18133f28 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-06Bug 551740: [AF][validation] we must check that all representation are ↵Christian W. Damus20-47/+1062
referenced by a viewpoint - add a custom validation rule to the architecture validation builder to check for references from some viewpoint to a representation kind - requires augmentation of the ArchitectureIndex to look for internal cross-references within the architecture models, not just external cross-references from architecture models to other tooling models - the latter motivated encapsulating some more friendly APIs in the ArchitectureIndex - and also is based on a new reusable InternalCrossReferencer utility - minor fixes to bundle metadata of some test projects files Change-Id: I9b7bf44d22bab442502eee01a11dfdddd3c42f1d Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-04-01Bug 570716 - [Tests] Mark as failing testsPauline DEVILLE3-3/+20
-org.eclipse.papyrus.editor.integration.tests.tests.EditorMemoryLeakTest.* -org.eclipse.papyrus.editor.integration.tests.tests.EditingScenariosMemoryLeakTest.* -org.eclipse.papyrus.infra.gmfdiag.assistant.tests.GenericModelingAssistantIntegrationTest.sourceForConnectionToTarget -org.eclipse.papyrus.infra.gmfdiag.assistant.tests.GenericModelingAssistantIntegrationTest.targetForConnectionFromSource Change-Id: Ibcaff9e42c6c958ec1a34615ca4e2abded6c00d4 Signed-off-by: Pauline DEVILLE <pauline.deville@cea.fr>
2021-03-29Bug 570856: [Toolsmiths][AF] Improve messages for command-class constraintsChristian W. Damus5-7/+38
- introduce custom messages for problems in the command class attributes - includes a second step to distinguish diagnosis of missing class versus a class that doesn't implement the expected protocol - requires generation of the plug-in class for the Papyrus Representation model - update existing JUnit tests to accommodate new diagnostic messages Change-Id: I351466b561700fdcda68d23b1385821d4d8fc1a9 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-03-29Bug 542945: [Architecture Framework] wrong context id in element type ↵Christian W. Damus9-4/+279
registration breaks AF Implement plug-in validation builder checks for: - element type set registration uses a client context that exists - architecture context referenced element type sets are registered with its ID if they are registered on the extension point at all Change-Id: Ibaef4d792d2846f49719480cc46beeff3a09918c Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>
2021-03-29Bug 568495 - Create static profile builder extensionRemi Schnekenburger1-8/+6
- update framework with the common version - fix an issue with error resolution on specific attribute (index error) - add the problem id in the error report - add additional information to the report (free from internal API with a simple map) - fix for ecore missing extension was adding pathmap specific path where a simple plugin relative path was expected - add support for quick fixes (binary build missing) - add soft requirement support (warning when extension point is not found) - update junit tests based on current implementation - update use cases Change-Id: Id4d93149dfa57e1858b7d8177058a6cfe0483d7e Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com> Also-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-03-26Bug 570097: [Toolsmiths] Architecture Domains: Validation BuilderVincent Lorenzo88-29/+3796
- JUnit test coverage. - Add coverage of binary command class resolution in dependencies checking. - Includes refactoring of auxiliary project importation for reuse in the new test case. - add Element Types builder test for case of types set referenced by a registered architecture model, which presents no problem - update the test fixture to register architecture models imported in test projects for the duration of the test, required for the new test case - test for validation of icon resources in Element Types Configurations models Change-Id: I9607a0fd576a707cf48a51b09bc573869ade7d10 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com> Also-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-03-26Bug 569356: [Toolsmiths] Support regeneration of ElementTypesConfiguration ↵Vincent Lorenzo16-85/+1195
models https://bugs.eclipse.org/bugs/show_bug.cgi?id=569356 - update the generator tests to match the new generation - add tests for incremental generation Change-Id: I00c956a60bc0ecaeaf17926190af62dc161ee80b Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com> Also-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-03-26Bug 569357: [Toolsmiths] ElementTypes: Model and Plug-in ValidationVincent Lorenzo67-79/+3565
- initial cases of project builder tests to parallel the validation menu tests - add JUnit test cases for build that should not find problems - JUnit test coverage for model validation - JUnit test coverage for build.properties validation - JUnit test coverage for plugin.xml validation - factor out test project fixture into a new common tests bundle Change-Id: I90f8cfd541cd9fa859aa5361fff015cebae02ec5 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com> Also-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-03-26Bug 569357: [Toolsmiths] ElementTypes: Model and Plug-in ValidationVincent Lorenzo1-1/+1
- fix exception on attempt to clear unmodifiable list when resetting Architecture Context preferences - let the workspace copy of an Architecture Context model supersede the deployed platform copy - ensure that relative cross-document references in the Architecture Context model resolve from workspace to platform where applicable - ensure loading unique copy of any given Architecture Context model even if redundantly added via preferences - ensure that ResourcesUtil works in the absence of PDE - factor out common project builder behaviours, including: - mapping the project for EMF resources to check - separate reporting of diagnostics from creation of markers to avoid creating redundant markers - common framework for EMF model validation checkers on EMF resources - common framework for build.properties checkers - common framework for bundle dependencies checkers - common framework for plugin.xml extensions checkers - implement the common checkers frameworks for element-types - absorb the function of the custom ElementTypesConfigurationsValidator into the builder - add validation of stereotype application matcher and related configurations - add validation of stereotype reference edge advice configurations - add inference of profile resources in the same project that need to be packaged by the build.properties file - handle extraction of bundle dependency name from bundleresource:// URIs - support aggregation of the same diagnostic from different sources into a single marker - add a generic checker for custom model validation rules - implement custom Element Types validation rules for UML Stereotypes - proper progress monitor delegation in the delegating builder - normalize URIs with inclusion of mappings from the workspace also Change-Id: Iefce58ba3a73b985f55b2ef82c45fb114cad4c44 Signed-off-by: Christian W. Damus <give.a.damus@gmail.com> Also-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-03-26Bug 568495 - Create static profile builder extensionRemi Schnekenburger1-2/+2
- move new plugin parser to profile validation plugin to share it between builders and validate handler - better check of URI mapping for Papyrus profile extension - Reuse "MarkerService" instead of duplicating marker creation methods - Implement the Manifest checker for profiles - Implement the Build.properties checker for profiles - Support nice position on text editor for build.properties and manifest files - new plugin parser in profile validation plugin - better check of URI mapping for Papyrus profile extension - Update dependencies to be compliant with 2020-12 version Change-Id: I9358a70a9999050d8a075e2f719868a675f5f0da Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com> Signed-off-by: Vincent Lorenzo <vincent.lorenzo@cea.fr>
2021-03-24Bug 568853: [Toolsmiths - ElementTypes] Add "MatchAndApply" Stereotype MatcherChristian W. Damus2-1/+67
- handle case of profile identity implied by stereotype qualified names - fix advice not finding the CreateElementRequest to approve - add test cases for rejection of CreateElementRequest https://bugs.eclipse.org/bugs/show_bug.cgi?id=568853 Change-Id: Ifc3a44640894e2746cb8f349ef10c74693de183e Signed-off-by: Christian W. Damus <give.a.damus@gmail.com>

Back to the top