Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2014-11-15451683: Memory leak in stereotype repairChristian W. Damus2-1322/+1354 Fix memory leaks in: - the common navigator framework (Model Explorer) - the Papyrus EMF Facet tree content provider (Model Explorer) - the GMF diagram outline page (SynchronizableGmfDiagramEditor)
2014-11-07450536: [Performance] New memory leaks in Mars M3Christian W. Damus3-83/+64 Fix two leaks of models in the Model Explorer view: - the UndoRedoActionProvider was not disposing its undo/redo action handlers, thus leaking them as listeners on the operation history - the ModelExplorerPageBookView was not disposing property-sheet pages (with their own undo/redo handlers) until it, itself, was entirely disposed (not when one of its pages is disposed for closing of a model)
2014-11-06450235: [Resource Reloading] The IPageManager is lost when automatically ↵Christian W. Damus2-8/+33
reloading a sub-model Ensure that the DoubleClickListener in the Model Explorer view gets whatever is the current service registry of the editor.
2014-11-06431117: [Model Explorer, Properties] Edit -> Undo/Redo menus are neverGabriel Pascual4-151/+464
enabled - Add action provider to Mode Explorer viewer - Create PropertySheetPage for Model Explorer view to add Undo/Redo menu contribution Change-Id: I4c41016f7c337051aa07d02517b5b991faf216da Signed-off-by: Gabriel Pascual <>
2014-11-06450280: [Properties View] Papyrus shall provide a helper to easily embedCamille Letavernier2-1/+141
a properties view in a Composite
2014-10-17436952: [Submodel] Deletion of a model fragment does not delete theGabriel Pascual7-68/+372
model fragment resources - Shift the handlers and contributions of Model Explorer menu to Model Explorer"plugin : "Create submodel" and "Reintegrate submodel" - Add Uncontrol of control mode to delete actions ( Model explorer and Diagram) Change-Id: I601cc4cd482e2b2d2f5a6acfc0b3bce76fa69b82 Signed-off-by: Gabriel Pascual <>
2014-09-16444227: Property view broken for associationsChristian W. Damus5-31/+313 The ViewEditor must be able to repeat sections for list values, such as the multiple ends of an association. To that end, the DisplayEngine now supports proxy sections that combine the same section instance that needs to be repeated with an arbitrary discriminator that distinguishes the repeated occurrences. This allows the display engine to reuse controls for the same repetition of the same section. Also, because multiple selections are presented as observables that are dynamic proxies wrapping a MultipleObservableValue, the ViewEditor cannot rely on that class's API to access the multiple objects that were selected. The API required by the ViewEditor is factored out into an interface that the proxy then automatically implements, as usual in the delegating observables mechanism. Change-Id: I88345c23f898100bd109bab2eccfd60d4b098323
2014-09-08443497: [Properties View] When editing a single reference from a Properties ↵Christian W. Damus1-0/+4
View dialog, pressing cancel unsets the current value Correct the handling of null return from the ReferenceValueFactory, not using it to unset the reference. Change-Id: Ia8100c71482e021a834f12fda79ca0eee2429f9b
2014-09-08443417: [Properties view] Gradient editor not refreshed when switching selectionChristian W. Damus2-15/+83 The ViewEditor class in the properties-view framework implements what amounts to a nested property sheet. Accordingly, when its containing property editors are reused for a new selection, it also needs to reuse its contents for the new selection. This requires keeping the same DisplayEngine to be reused and reusing the nested XWTSections that it manages.
2014-08-30417409: [Performances - Properties view] Delay in UI when reorganizing ↵Christian W. Damus1-14/+27
diagram layout. Fix problem of read-only state of widgets carrying over from one selection to the next when property-sheet widgets are reused.
2014-08-27441857: [Performances - Model Explorer] Severe performance problems for ↵Christian W. Damus1-17/+56
larger models Don't refresh the entire model explorer every time the selection in a diagram editor changes. Moreover, let requests for synchronous refresh merely hurry up a pending asynchronous refresh (if any). This works on the assumption that only changes in the resource set and/or read-only state should invalidate the explorer's presentation, which is supported by the fact that only these triggers schedule an asynchronous refresh in the first place. Change-Id: I089723942e59994280dc4dd8eceafc5f35c13fac
2014-08-26[Code Style] Configure code style in the projectsChristian W. Damus20-4/+3532
Configure the master settings for Code Style in the org.eclipse.papyrus.infra.core plug-in, including: - Code Formatter - Code Clean-up - Code Templates - Import Sort Order Employ the Oomph Project Configuration tooling to propagate these settings to all other Papyrus main, test, and developer plug-ins, plus the CDO Integration plug-ins. Update the Papyrus Oomph model to remove the workspace-wide code style settings. Change-Id: Id1c7c7fb94c82974a9f1c7cafcfcf32b71ce6c1f
2014-08-25[Code style] Apply clean-up profile to Papyrus Main plug-insCamille Letavernier153-2227/+2232
2014-08-21[Code style] Apply clean-up and formatter on Main plug-insCamille Letavernier361-8926/+11944
2014-08-20[Releng] Update Papyrus version to 1.0.1 in pom.xmlCamille Letavernier10-20/+20
2014-08-20[Releng] Update versions to 1.0.1Camille Letavernier10-95/+99
2014-08-07417409: [Performances - Properties view] Delay in UI when reorganizing ↵Christian W. Damus17-64/+774
diagram layout. Make property sheet views reusable, with updating of the bound selection when the selection changes to another element that shows the same views. This employs new capability of the DataSource to update the selection that it encapsulates, pushing the new selection into the ModelElements that it creates, using a new delegating observable framework. Property sheet controls are re-used on a per-tab basis. Because of the new delegation pattern introduced here, we need to be able to ensure that delegate observables are disposed of when they are no longer needed. This includes not only the delegates of the new DelegatingObservables, but also the delegates of MultipleObservableValue and similar aggregates. As these delegates can be shared amongst multiple wrappers of different kinds, we use a simple reference counting scheme to ensure that observables are not disposed while they are still in use. This averts the exceptions discovered in multi-observable (multiple selection) scenarios on a previous iteration of this patch set. Change-Id: Ide8f3fcea4228083a68bc9d5d39dc5a50217af62
2014-07-30440545: Switch from IrevealSemanticElement to NavigationTargetQuentin Le Menez2-4/+37 - changed from IRevealSemanticElement's revealSemanticElement methods to NavigationTarget's revealElement for the table selections - amended the existing classes LinkHelper, SynchronizableGmfDiagramEditor and ModelExplorerView Change-Id: I90ad7103812fd27c3ca729375bf1aa89f6a16c09 Signed-off-by: Quentin Le Menez <>
2014-07-25Merge "437217: [Editors] In-place reloading of model resources in the ↵Christian W. Damus3-122/+287
2014-07-24437217: [Editors] In-place reloading of model resources in the editorsChristian W. Damus3-122/+287 In situ editor reloading. Introduces an IReloadableEditor adapter protocol with an implementation in the CoreMultiDiagramEditor that implements internal destruction of the ServicesRegistry and nested editors. Some refactoring of the initialization and disposal code in the editor class hierarchy and dependencies facilitates reuse of init/dispose code in the reload scenario. The re-loading of an editor is deferred until it is next activated, unless it is already the active editor (can happen when "Save All" is invoked). Editor re-load notifications to dependent views like Model Explorer and Outline. A new listener protocol informs dependents before and after reload so that they may properly dispose of obsolete state and re-initialize when the editor is reloaded. Also ensure that an editor is only reloaded once when some resource that it depends on has changed, not once for each resource. State restoration tokens. Re-load listeners can insert tokens into the re-load event that capture state to be restored after the re-load. Listeners retrieve and apply these tokens after the editor re-loads itself. Current state restoration includes: - tree node expansion and selection state in the Model Explorer view - diagram outline view: which presentation (tree or overview thumbnail) is active - which workbench part is active, such that the correct selection is reflected in views such as Model Explorer, Outline, and Properties - current active diagram in the re-loaded editor - edit-part selections in all diagrams - selection (columns and rows, not individual cells) in table editors - palettes in each diagram (or palette pages when the Palette View is open): * active tool * pinnable stack tool selection * drawer expansion state * drawer scroll position The Palette View support incidentally fixes loss of palette state when switching between Papyrus editors, caused by the PapyrusPaletteSynchronizer. JUnit regression tests for various aspects of editor re-load. Includes a fix for an NPE in the Validation View's content provider that occurs in several tests when an editor is closed or re-loaded. Also support for tests that need to load more than one test-fixture model and/or open more than one editor. Change-Id: Ic0f654ab138d3e091f81f1e9159bcca80d6bb0a5
2014-07-24[ModelExplorer] Allow opening invalid diagrams, as the editor may beCamille Letavernier1-18/+3
able to repair them on-the-fly
2014-07-21415639: [Resource Loading] Unloading a controlled unit hangs theChristian W. Damus4-9/+171
workbench Fix ConcurrentModificationException that bombs controlled unit unloading and implement proper progress-monitoring UI in the LoadingUtils. Also fix a problem in which newly loaded resources appear to be read-only because the ControlledResourcesTracker doesn't detect that there a cross-resource containment proxy has been resolved. Do not permit unloading of a resource that is dirty. Change-Id: I1c2242aa7a346209faf586128305f7ed7de06584
2014-06-05422745: Linkage error, if guava 13 is availableCamille Letavernier1-3/+2 - Replace all import-package with required-bundle
2014-06-04[Releng] Remove the (Incubation) suffix from all (main) plug-ins andCamille Letavernier10-10/+10
features Update the Bundle test accordingly
2014-06-02417409: [Performances - Properties view] Delay in UI when reorganizing ↵Christian W. Damus3-2/+33
diagram layout. Ensure that when the user reconfigures the property sheet, the cache of XML UI definitions is purged so that any changes in presentation of the properties may be implemented.
2014-05-28435420: [Widgets] Clicking a CCombo pastes the selected element's name into itChristian W. Damus1-2/+5 Work around a bug in the responder chain management in the Cocoa implementation of SWT.
2014-05-27435103: Profile definition info reported for Bug 415211 is brokenChristian W. Damus1-1/+8 Add better diagnostic message than an NPE when a model-element factory descriptor is an unresolved proxy and restore the deleted descriptor in the UML Properties model.
2014-05-22Bug 375331 - [All Diagrams] Cut, Copy and Paste commands shall beBenoit Maggi1-414/+410
available for diagrams - remove the "duplicate" menu on diagrams in model explorer Change-Id: I90e4747bb17fee8407c6d3eb6b96fccadfae08e8 Signed-off-by: Benoit Maggi <>
2014-05-20417409: [Performances - Properties view] Delay in UI when reorganizing ↵Christian W. Damus1-2/+14
diagram layout. Fix a minor performance hotspot in XWT resource loading by caching XML elements loaded from XWT resources deployed in the property-sheet models.
2014-05-20411857: [Property View] dynamic section blinking!Camille Letavernier1-6/+8 - Set redraw to false during section display & refresh, to reduce flickering
2014-05-19435162: [Model explorer] link with editor doesn't work in advanced modeCamille Letavernier2-6/+9 - Fix the ModelExplorer#revealSemanticElement in advanced mode
2014-05-16Merge "Bug 405565 -[Papyrus Model Explorer] Papyrus Model Explorer shall ↵Remi Schnekenburger2-3/+3
enable copy/past with views. - Refactor paste strategies to have an AbstractPasteStrategy - Add DiagramPasteStrategy for copy/paste in Model explorer"
2014-05-15434966: [Model Explorer] new child menu shall be updated before officialRemi Schnekenburger1-134/+134
release Change-Id: Iee4943ad614d7782180aa5300f3939fdd39bc241 Signed-off-by: Remi Schnekenburger <>
2014-05-15Bug 434953 - [Model Validation] Columns are invisibleAnsgar Radermacher2-9/+17
2014-05-15Bug 405565 -[Papyrus Model Explorer] Papyrus Model Explorer shall enableBenoit Maggi2-3/+3
copy/past with views. - Refactor paste strategies to have an AbstractPasteStrategy - Add DiagramPasteStrategy for copy/paste in Model explorer Change-Id: I9286daf8b68d2555cd98d966ee2e215b47f52bb5 Signed-off-by: Benoit Maggi <>
2014-05-14434857: [Model Explorer] Drag & Drop brokenChristian W. Damus1-7/+7 Fix regression caused by ModelExplorer tree elements no longer being EObjects, themselves, but only adapting to EObject (which actually restores Kepler semantics).
2014-05-14434133: [ModelExplorer] ModelExplorer items should be IAdaptableCamille Letavernier1-3/+2 - Fix handler declarations
2014-05-13434635: [Model Explorer] Preference for "Link with Editor"Christian W. Damus1-1/+3 Handle bootstrapping case of null memento.
2014-05-13434635: [Model Explorer] Preference for "Link with Editor"Christian W. Damus9-62/+556 Implement memento-based persistence for the link-with-editor and alphabetical-sorting toggle buttons in the Model Explorer tool bar. Fix the initial calculation of the toggle state of the advance view tool bar item and implement calculation of the toggle state of the show-diagrams tool bar item. All of these toggle states are shared across all Model Explorer pages (the user perceives the Model Explorer as one view, not a bunch of pages).
2014-05-12Bug 434514 - [Model Explorer] Cut action is enabled on read-onlyBenoit Maggi4-138/+86
elements and root package. Add tests and patch for the 3 usecases : - disable cut on the root element - disable cut on a read only element - disable paste on a read only element Change-Id: If40d0b27055bed41633746dcbce808f156c33732 Signed-off-by: Benoit Maggi <> Signed-off-by: Christian W. Damus <>
2014-05-06Merge "Bug 290261 - [Usability] Papyrus shall provide a copy/paste/cut ↵Remi Schnekenburger1-48/+146
feature - add cut for diagram and model explorer - cut => copy + delete"
2014-05-06Merge "Bug 290261 - [Usability] Papyrus shall provide a copy/paste/cut ↵Remi Schnekenburger1-0/+10
feature - swap command ids to have the default papyrus copy/paste/cut override the org.eclipse.ui.edit.copy/paste/cut - add menus for graphical copy/paste Change-Id: Ic0769df6c97ba7aefb42e6a0861a05b0dd8fbfce Signed-off-by: Benoit Maggi <>"
2014-05-05Bug 290261 - [Usability] Papyrus shall provide a copy/paste/cut featurebmaggi1-48/+146
- add cut for diagram and model explorer - cut => copy + delete Change-Id: I51680e4d4bdd775222a9d8c7fdf32ea35e3ce017 Signed-off-by: bmaggi <>
2014-05-02Bug 433647 - [OCL Editor] Properties View OCL Editor for OpaqueExpression is ↵Ansgar Radermacher1-4/+1
2014-04-30430079: [CSS] Papyrus shall provide features to define local themeGabriel Pascual2-55/+231 Patch 3 : - Fix major issue - Fix comment's remarks Patch 2 : - Rebase to pass hudson verification Pathch 1 : - Use workspace relative path for selected css files during CSS theme edition - Fix "restore default" button action in CSS preference page - Harmonisation of all UI for theme icon selection - Add dialog to confirm theme deletion - Refactor to resolve some dependency problems - Creation of widget for XWT theme view - Add embedded style sheets in CSS Workspace engine working - Fix problems of label provider for CSS themes properties view - Add workspace themes preference page - Add definition of theme property view - Fix saving step of an edited theme from workspace - Fix loading of theme icon in label provider - Fix behavior of theme edition dialog fields - Add edition action on style sheets list - Add move up and move down actions in edition dialog - Add actions (add and delete) to dialog - Resolution staying conflicts after last merge - Add edition theme dialog from project explorer - Minor modification of Style sheet metamodel - Modify CSS engine and theme manager to look at workspace theme contributions - Add theme creation by selecting one or more CSS files - Add dialog to define theme from CSS file in workspace - Create one menu for two actions to manage local theme - Manage command ID in handler - Fix containment relationship in model - Add draft of theme creation from a CSS selection - Modification of style sheets model - Add popup menu on CSS file Change-Id: Ie46281e334252bfbed727c18a431677761db2a45 Signed-off-by: Gabriel Pascual <>
2014-04-29351803: [UI Customizability] Papyrus shall provide a customizable "NewCamille Letavernier1-11/+12
Child" menu within model explorer view - Trivial: fix a NPE when the selection is empty
2014-04-29320908: [Model Explorer] Newly created objects (via "New Child" menu)Camille Letavernier1-25/+45
shall get focus and be in rename mode
2014-04-28427861: M5 re-install Guava incompatibilityCamille Letavernier1-2/+2 432858: [Guava versions] Exception creating a project
2014-04-25Bug 290261 - [Usability] Papyrus shall provide a copy/paste/cut featureBenoit Maggi1-0/+10
- swap command ids to have the default papyrus copy/paste/cut override the org.eclipse.ui.edit.copy/paste/cut - add menus for graphical copy/paste Change-Id: Ic0769df6c97ba7aefb42e6a0861a05b0dd8fbfce Signed-off-by: Benoit Maggi <>
2014-04-23422257: [Performances] Memory leaksChristian W. Damus1-6/+1 Add memory leak JUnit tests for basic model editor open/close scenario.

Back to the top