Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorytanguy2011-07-27 11:08:29 +0000
committerytanguy2011-07-27 11:08:29 +0000
commit98b025c3184af83b26f289decc2823c34c5f9d30 (patch)
tree4b816b43a03e6631b1d4b63b83b9e8af9b61893b /tests
parent33c2687e48d42bb51ae6401750c6f87307586e95 (diff)
downloadorg.eclipse.papyrus-98b025c3184af83b26f289decc2823c34c5f9d30.tar.gz
org.eclipse.papyrus-98b025c3184af83b26f289decc2823c34c5f9d30.tar.xz
org.eclipse.papyrus-98b025c3184af83b26f289decc2823c34c5f9d30.zip
NEW - bug 351433: [General] IllegalArgumentException: An EditPart has to be selectable...
https://bugs.eclipse.org/bugs/show_bug.cgi?id=351433
Diffstat (limited to 'tests')
-rw-r--r--tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/creation/TestNodeCreationOnDiagram.java42
-rw-r--r--tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/dnd/link/TestLinkDropOnModel.java11
2 files changed, 42 insertions, 11 deletions
diff --git a/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/creation/TestNodeCreationOnDiagram.java b/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/creation/TestNodeCreationOnDiagram.java
index b3ed7fe81e7..277ea89e238 100644
--- a/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/creation/TestNodeCreationOnDiagram.java
+++ b/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/creation/TestNodeCreationOnDiagram.java
@@ -1,9 +1,18 @@
package org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.creation;
import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.EditorUtils.getDiagramView;
+import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.EditorUtils.getEditPart;
+import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.TestPrepareUtils.changeVisibility;
import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.TestUtils.createNodeFromPalette;
+import org.eclipse.gmf.runtime.diagram.core.util.ViewUtil;
+import org.eclipse.gmf.runtime.notation.View;
import org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.AbstractTest;
+import org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.TestPrepareUtils;
+import org.eclipse.papyrus.sysml.diagram.common.utils.SysMLGraphicalTypes;
+import org.eclipse.papyrus.sysml.service.types.element.SysMLElementTypes;
+import org.eclipse.papyrus.uml.diagram.common.utils.UMLGraphicalTypes;
+import org.eclipse.papyrus.uml.service.types.element.UMLElementTypes;
import org.junit.Test;
/**
@@ -11,6 +20,39 @@ import org.junit.Test;
*/
public class TestNodeCreationOnDiagram extends AbstractTest {
+ @Test // https://bugs.eclipse.org/bugs/show_bug.cgi?id=348549
+ public void dropExceptionToFix_bug348549() throws Exception {
+
+ View propertyView;
+ View containerView;
+
+ try {
+ View elementView = TestPrepareUtils.createGraphicalNode(SysMLElementTypes.BLOCK, SysMLGraphicalTypes.SHAPE_SYSML_BLOCK_AS_CLASSIFIER_ID, getDiagramView());
+ containerView = ViewUtil.getChildBySemanticHint(elementView, SysMLGraphicalTypes.COMPARTMENT_SYSML_PROPERTY_AS_LIST_ID);
+ if(containerView == null) {
+ throw new Exception("Unable to prepare container for test.");
+ }
+
+ // Ensure the compartment is visible (required for EditPart to be found)
+ if(!containerView.isVisible()) {
+ changeVisibility(containerView);
+ }
+
+ propertyView = TestPrepareUtils.createGraphicalNode(UMLElementTypes.PROPERTY, UMLGraphicalTypes.SHAPE_UML_PROPERTY_AS_LABEL_ID, containerView);
+
+ } catch (Exception e) {
+ throw new Exception("Failure during test preparation.", e);
+ }
+
+ getEditPart(getDiagramView()).setFocus(true);
+ getEditPart(propertyView).setFocus(true); // This should not throw the following exception
+// getEditPart(containerView).setFocus(true); // This should throw the following exception (assuming the owner does not have the focus).
+// java.lang.IllegalArgumentException: An EditPart has to be selectable (isSelectable() == true) in order to obtain focus.
+// at org.eclipse.core.runtime.Assert.isLegal(Assert.java:63)
+// at org.eclipse.gef.editparts.AbstractEditPart.setFocus(AbstractEditPart.java:1005)
+// at org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.dnd.link.TestLinkDropOnModel.dropDependency(TestLinkDropOnModel.java:71)
+ }
+
@Test
public void testCreationActorInDiagram() throws Exception {
createNodeFromPalette("blockdefinition.tool.actor", getDiagramView(), true);
diff --git a/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/dnd/link/TestLinkDropOnModel.java b/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/dnd/link/TestLinkDropOnModel.java
index f40f5e3f9ea..fcf53341edf 100644
--- a/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/dnd/link/TestLinkDropOnModel.java
+++ b/tests/junit/plugins/sysml/org.eclipse.papyrus.sysml.diagram.blockdefinition.tests/src/org/eclipse/papyrus/sysml/diagram/blockdefinition/tests/dnd/link/TestLinkDropOnModel.java
@@ -1,7 +1,6 @@
package org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.dnd.link;
import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.EditorUtils.getDiagramView;
-import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.EditorUtils.getEditPart;
import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.TestPrepareUtils.createElement;
import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.TestPrepareUtils.createGraphicalNode;
import static org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.utils.TestPrepareUtils.createLink;
@@ -64,16 +63,6 @@ public class TestLinkDropOnModel extends AbstractTest {
associationSharedDirected = createLink(SysMLElementTypes.ASSOCIATION_SHARED_DIRECTED, blockSource, blockTarget);
}
- @Test // https://bugs.eclipse.org/bugs/show_bug.cgi?id=348549
- public void dropExceptionToFix_bug348549() throws Exception {
- getEditPart(container).setFocus(true);
-// java.lang.IllegalArgumentException: An EditPart has to be selectable (isSelectable() == true) in order to obtain focus.
-// at org.eclipse.core.runtime.Assert.isLegal(Assert.java:63)
-// at org.eclipse.gef.editparts.AbstractEditPart.setFocus(AbstractEditPart.java:1005)
-// at org.eclipse.papyrus.sysml.diagram.blockdefinition.tests.dnd.link.TestLinkDropOnModel.dropDependency(TestLinkDropOnModel.java:71)
- dropFromModelExplorer(dependency, container, true);
- }
-
@Test
public void dropDependency() throws Exception {
dropFromModelExplorer(dependency, container, true);

Back to the top