Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew M. Finkbeiner2015-08-18 16:51:34 +0000
committerAndrew M. Finkbeiner2015-08-18 16:53:17 +0000
commit027c69ef9aa7ab35ab3410fef5403c93219bdf7e (patch)
treee172e709008685526910586ce6242ff165ef64a7
parent5e87a0a84c0dd73f7db95b0fc5e573011ab63acb (diff)
downloadorg.eclipse.ote-027c69ef9aa7ab35ab3410fef5403c93219bdf7e.tar.gz
org.eclipse.ote-027c69ef9aa7ab35ab3410fef5403c93219bdf7e.tar.xz
org.eclipse.ote-027c69ef9aa7ab35ab3410fef5403c93219bdf7e.zip
feature: Cleanup some warnings
-rw-r--r--org.eclipse.ote.bytemessage/src/org/eclipse/ote/bytemessage/SerializedClassMessage.java3
-rw-r--r--org.eclipse.ote.io.test/src/org/eclipse/ote/io/CircularBufferTest.java3
-rw-r--r--org.eclipse.ote.statemachine/src/org/eclipse/ote/statemachine/StateMachine.java8
-rw-r--r--org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/RowUpdate.java1
-rw-r--r--org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/SubscriptionDetails.java1
-rw-r--r--org.eclipse.ote.ui.message.util/src/org/eclipse/ote/ui/message/util/CheckedSelectionDialog.java2
-rw-r--r--org.eclipse.ote.ui.message/src/org/eclipse/ote/ui/message/watch/WatchView.java2
7 files changed, 5 insertions, 15 deletions
diff --git a/org.eclipse.ote.bytemessage/src/org/eclipse/ote/bytemessage/SerializedClassMessage.java b/org.eclipse.ote.bytemessage/src/org/eclipse/ote/bytemessage/SerializedClassMessage.java
index b47118921..36a8f3285 100644
--- a/org.eclipse.ote.bytemessage/src/org/eclipse/ote/bytemessage/SerializedClassMessage.java
+++ b/org.eclipse.ote.bytemessage/src/org/eclipse/ote/bytemessage/SerializedClassMessage.java
@@ -41,7 +41,8 @@ public class SerializedClassMessage<T> extends OteByteMessage {
getDefaultMessageData().setNewBackingBuffer(newData);
}
- public T getObject() throws IOException, ClassNotFoundException{
+ @SuppressWarnings("unchecked")
+ public T getObject() throws IOException, ClassNotFoundException{
int offset = OBJECT.getByteOffset() + getHeaderSize();
ByteArrayInputStream bis = new ByteArrayInputStream(getData(), offset, getData().length - offset);
ObjectInputStream ois = new ObjectInputStream(bis);
diff --git a/org.eclipse.ote.io.test/src/org/eclipse/ote/io/CircularBufferTest.java b/org.eclipse.ote.io.test/src/org/eclipse/ote/io/CircularBufferTest.java
index 30571b25f..7f14de34f 100644
--- a/org.eclipse.ote.io.test/src/org/eclipse/ote/io/CircularBufferTest.java
+++ b/org.eclipse.ote.io.test/src/org/eclipse/ote/io/CircularBufferTest.java
@@ -1,8 +1,7 @@
package org.eclipse.ote.io;
-import junit.framework.Assert;
-import org.eclipse.ote.io.CircularBuffer;
+import org.junit.Assert;
import org.junit.Test;
public class CircularBufferTest {
diff --git a/org.eclipse.ote.statemachine/src/org/eclipse/ote/statemachine/StateMachine.java b/org.eclipse.ote.statemachine/src/org/eclipse/ote/statemachine/StateMachine.java
index 3832ea393..a889a3f47 100644
--- a/org.eclipse.ote.statemachine/src/org/eclipse/ote/statemachine/StateMachine.java
+++ b/org.eclipse.ote.statemachine/src/org/eclipse/ote/statemachine/StateMachine.java
@@ -114,13 +114,7 @@ public final class StateMachine {
}
public void processUntilEmpty(){
- BaseInput input = null;
- while((input = processInput()) != null){
-// try{
-// input = processInput();
-// } catch (Throwable th){
-// th.printStackTrace();
-// }
+ while(processInput() != null){
}
}
diff --git a/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/RowUpdate.java b/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/RowUpdate.java
index 7d540ffa3..af3bee675 100644
--- a/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/RowUpdate.java
+++ b/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/RowUpdate.java
@@ -21,7 +21,6 @@ public final class RowUpdate {
private final Object[] values;
private final BitSet deltaSet;
private final HashMap<ViewerColumn, Integer> valueMap;
- private long envTime;
RowUpdate(HashMap<ViewerColumn, Integer> valueMap, List<ViewerColumn> allColumns) {
this.valueMap = valueMap;
diff --git a/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/SubscriptionDetails.java b/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/SubscriptionDetails.java
index 2972194b3..40acfe8d6 100644
--- a/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/SubscriptionDetails.java
+++ b/org.eclipse.ote.ui.eviewer/src/org/eclipse/ote/ui/eviewer/view/SubscriptionDetails.java
@@ -29,7 +29,6 @@ public class SubscriptionDetails implements ISubscriptionListener, IOSEEMessageL
private Message<?, ?, ?> message;
private final IUpdateListener listener;
- @SuppressWarnings("unused")
public SubscriptionDetails(IMessageSubscription subscription, IUpdateListener listener) {
this.subscription = subscription;
diff --git a/org.eclipse.ote.ui.message.util/src/org/eclipse/ote/ui/message/util/CheckedSelectionDialog.java b/org.eclipse.ote.ui.message.util/src/org/eclipse/ote/ui/message/util/CheckedSelectionDialog.java
index 8eeab1ebe..dee289e1e 100644
--- a/org.eclipse.ote.ui.message.util/src/org/eclipse/ote/ui/message/util/CheckedSelectionDialog.java
+++ b/org.eclipse.ote.ui.message.util/src/org/eclipse/ote/ui/message/util/CheckedSelectionDialog.java
@@ -12,11 +12,11 @@ package org.eclipse.ote.ui.message.util;
import java.util.Arrays;
import java.util.Map;
+
import org.eclipse.jface.dialogs.TrayDialog;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
-import org.eclipse.swt.events.SelectionListener;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
diff --git a/org.eclipse.ote.ui.message/src/org/eclipse/ote/ui/message/watch/WatchView.java b/org.eclipse.ote.ui.message/src/org/eclipse/ote/ui/message/watch/WatchView.java
index d00b3bed3..ac932a578 100644
--- a/org.eclipse.ote.ui.message/src/org/eclipse/ote/ui/message/watch/WatchView.java
+++ b/org.eclipse.ote.ui.message/src/org/eclipse/ote/ui/message/watch/WatchView.java
@@ -391,9 +391,7 @@ public final class WatchView extends ViewPart implements ITestConnectionListener
TextTransfer transfer = TextTransfer.getInstance();
String data = (String) cb.getContents(transfer);
if (data != null) {
- SignalStripper signalStripper = new SignalStripper();
AddWatchParameter param = new AddWatchParameter();
- String mwi = signalStripper.generateStringToWrite(data, param);
addWatchMessage(param);
}
} else if (e.stateMask != SWT.CTRL && e.stateMask != SWT.ALT && e.keyCode == SWT.DEL){

Back to the top