diff options
author | jmisinco | 2014-01-21 16:00:53 +0000 |
---|---|---|
committer | Roberto E. Escobar | 2014-03-04 19:42:09 +0000 |
commit | a450049cf58c965a3628995b3e5ef220b2d8a075 (patch) | |
tree | bf303b02f8069f900fbddff1a129a56017a92fb5 /plugins | |
parent | eb497ffb58cda181b0e8e2f0d1749dd602820489 (diff) | |
download | org.eclipse.osee-a450049cf58c965a3628995b3e5ef220b2d8a075.tar.gz org.eclipse.osee-a450049cf58c965a3628995b3e5ef220b2d8a075.tar.xz org.eclipse.osee-a450049cf58c965a3628995b3e5ef220b2d8a075.zip |
refactor: Remove unneeded calls to Criteria checkValid
To be consistent with the comment in the Criteria.checkValid method, only
sub-classes that need to override the checkValid call do.
Change-Id: I4dbb9c145f32b36924abfc922efe464df439f369
Diffstat (limited to 'plugins')
37 files changed, 0 insertions, 79 deletions
diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllArtifacts.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllArtifacts.java index d86c3504e19..86eac3923a0 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllArtifacts.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllArtifacts.java @@ -10,9 +10,7 @@ *******************************************************************************/ package org.eclipse.osee.orcs.core.ds.criteria; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; /** * @author Roberto E. Escobar @@ -24,11 +22,6 @@ public class CriteriaAllArtifacts extends Criteria { } @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - - @Override public String toString() { return "CriteriaAllArtifacts"; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllBranches.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllBranches.java index bbf7f64eaf7..d65e62a6e7e 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllBranches.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllBranches.java @@ -10,9 +10,7 @@ *******************************************************************************/ package org.eclipse.osee.orcs.core.ds.criteria; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; /** * @author Roberto E. Escobar @@ -24,11 +22,6 @@ public class CriteriaAllBranches extends Criteria { } @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - - @Override public String toString() { return "CriteriaAllBranches"; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllTxs.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllTxs.java index 2a1ab750e46..61f4c4767a3 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllTxs.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAllTxs.java @@ -10,9 +10,7 @@ *******************************************************************************/ package org.eclipse.osee.orcs.core.ds.criteria; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; /** * @author Roberto E. Escobar @@ -24,11 +22,6 @@ public class CriteriaAllTxs extends Criteria { } @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - - @Override public String toString() { return "CriteriaAllTxs"; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactGuids.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactGuids.java index 315a97c7f2e..7d5ee7af01c 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactGuids.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactGuids.java @@ -33,7 +33,6 @@ public class CriteriaArtifactGuids extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(artifactGuids, "artifact guids"); List<String> invalids = new ArrayList<String>(); for (String guid : artifactGuids) { diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactIds.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactIds.java index 376220fc823..2a67a9aa850 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactIds.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactIds.java @@ -30,7 +30,6 @@ public class CriteriaArtifactIds extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(ids, "artifact ids"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactType.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactType.java index 2a6f07925e5..aa226c92465 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactType.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaArtifactType.java @@ -37,7 +37,6 @@ public class CriteriaArtifactType extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(artifactTypes, "artifact types"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeKeywords.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeKeywords.java index d90fab18927..60672c8d0c2 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeKeywords.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeKeywords.java @@ -65,7 +65,6 @@ public class CriteriaAttributeKeywords extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(getValues(), "search value"); Conditions.checkNotNullOrEmpty(getTypes(), "attribute types"); checkMultipleValues(); diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeOther.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeOther.java index 7b76e91326f..edd0fa7e81a 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeOther.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeOther.java @@ -50,7 +50,6 @@ public class CriteriaAttributeOther extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getAttributeType(), "attributeType"); Conditions.checkExpressionFailOnTrue(getAttributeType().equals(QueryBuilder.ANY_ATTRIBUTE_TYPE), "Any attribute type is not allowed"); diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeTypeExists.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeTypeExists.java index 6968b21981b..25830404f23 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeTypeExists.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAttributeTypeExists.java @@ -35,7 +35,6 @@ public class CriteriaAttributeTypeExists extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(getTypes(), "attribute types"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAuthorIds.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAuthorIds.java index 2f430aae8a9..23610a2c948 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAuthorIds.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaAuthorIds.java @@ -30,7 +30,6 @@ public class CriteriaAuthorIds extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(ids, "Author ids"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranch.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranch.java index 40e8e5ac5a8..08df19b192e 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranch.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranch.java @@ -31,7 +31,6 @@ public class CriteriaBranch extends Criteria implements HasBranch { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(branch, "branch"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchAncestorOf.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchAncestorOf.java index 2c0f2a2ce3e..bbb788202d6 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchAncestorOf.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchAncestorOf.java @@ -34,7 +34,6 @@ public class CriteriaBranchAncestorOf extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getChild(), "Child branch"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchArchived.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchArchived.java index 1c30ef77701..cec39d6822a 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchArchived.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchArchived.java @@ -35,7 +35,6 @@ public class CriteriaBranchArchived extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(getStates(), "branch archived state"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchChildOf.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchChildOf.java index 095beac69bc..b1b76ba1807 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchChildOf.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchChildOf.java @@ -34,7 +34,6 @@ public class CriteriaBranchChildOf extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getParent(), "Parent branch"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchIds.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchIds.java index 51e3d05ad1d..aba35eda100 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchIds.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchIds.java @@ -34,7 +34,6 @@ public class CriteriaBranchIds extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getIds().isEmpty(), "Branch Ids cannot be empty"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchName.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchName.java index c7e009ce546..78a0bdf3eb2 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchName.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchName.java @@ -39,7 +39,6 @@ public class CriteriaBranchName extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(getValue(), "branch name value"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchState.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchState.java index 75ed3fe4e46..1cd11412bbc 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchState.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchState.java @@ -35,7 +35,6 @@ public class CriteriaBranchState extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getStates().isEmpty(), "Branch States cannot be empty"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchToSearch.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchToSearch.java index 4a820c5c984..0aaaaadfd28 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchToSearch.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchToSearch.java @@ -11,9 +11,7 @@ package org.eclipse.osee.orcs.core.ds.criteria; import org.eclipse.osee.framework.core.data.IOseeBranch; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; import org.eclipse.osee.orcs.data.HasBranch; /** @@ -34,11 +32,6 @@ public class CriteriaBranchToSearch extends Criteria implements HasBranch { } @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - - @Override public String toString() { return "CriteriaBranchToSearch [branch=" + branch + "]"; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchType.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchType.java index e69152c22b4..5ddc98cd84e 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchType.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchType.java @@ -35,7 +35,6 @@ public class CriteriaBranchType extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getTypes().isEmpty(), "Branch Types cannot be empty"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchUuids.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchUuids.java index cf961c36697..3d60c5de38b 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchUuids.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaBranchUuids.java @@ -34,7 +34,6 @@ public class CriteriaBranchUuids extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getIds().isEmpty(), "Branch Ids cannot be empty"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaCommitIds.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaCommitIds.java index 8184a5a435f..60edac87e19 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaCommitIds.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaCommitIds.java @@ -30,7 +30,6 @@ public class CriteriaCommitIds extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(ids, "Author ids"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateRange.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateRange.java index 1881b2eec5f..73b28cc1ae2 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateRange.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateRange.java @@ -31,7 +31,6 @@ public class CriteriaDateRange extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); if (from.after(to)) { throw new OseeArgumentException("from date must be less than to date"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateWithOperator.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateWithOperator.java index 5125078ba28..4cf88762d1b 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateWithOperator.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaDateWithOperator.java @@ -11,9 +11,7 @@ package org.eclipse.osee.orcs.core.ds.criteria; import java.sql.Timestamp; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; import org.eclipse.osee.orcs.search.Operator; /** @@ -30,11 +28,6 @@ public class CriteriaDateWithOperator extends Criteria { this.op = op; } - @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - public Operator getOperator() { return op; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelatedTo.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelatedTo.java index 5a0a1334687..e100035671b 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelatedTo.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelatedTo.java @@ -40,7 +40,6 @@ public class CriteriaRelatedTo extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getType(), "relation type side"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeExists.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeExists.java index 1bdaeab64c8..5b820919e90 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeExists.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeExists.java @@ -33,7 +33,6 @@ public class CriteriaRelationTypeExists extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getType(), "relation type"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeNotExists.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeNotExists.java index 5b83636416a..774b902cb0f 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeNotExists.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeNotExists.java @@ -33,7 +33,6 @@ public class CriteriaRelationTypeNotExists extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getType(), "relation type"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideExists.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideExists.java index 811f7a664bd..20c98682171 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideExists.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideExists.java @@ -33,7 +33,6 @@ public class CriteriaRelationTypeSideExists extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getType(), "relation type"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideNotExists.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideNotExists.java index e7a67bd1d5a..83a1651a69a 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideNotExists.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaRelationTypeSideNotExists.java @@ -33,7 +33,6 @@ public class CriteriaRelationTypeSideNotExists extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNull(getType(), "relation type"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxArtifactGuids.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxArtifactGuids.java index c6e2e2158ff..546fff331e2 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxArtifactGuids.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxArtifactGuids.java @@ -33,7 +33,6 @@ public class CriteriaTxArtifactGuids extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(artifactGuids, "artifact guids"); List<String> invalids = new ArrayList<String>(); for (String guid : artifactGuids) { diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchIds.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchIds.java index 0cd8723aadd..4db893f8cae 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchIds.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchIds.java @@ -34,7 +34,6 @@ public class CriteriaTxBranchIds extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getIds().isEmpty(), "Branch Ids cannot be empty"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchUuids.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchUuids.java index 818fd2eef3d..5bf160a1221 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchUuids.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxBranchUuids.java @@ -35,7 +35,6 @@ public class CriteriaTxBranchUuids extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getIds().isEmpty(), "Branch Ids cannot be empty"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxComment.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxComment.java index 66fd4a53593..02686bdc30b 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxComment.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxComment.java @@ -39,7 +39,6 @@ public class CriteriaTxComment extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(getValue(), "comment value"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxGetHead.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxGetHead.java index 20d5dbbdeab..ee1143496a6 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxGetHead.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxGetHead.java @@ -38,7 +38,6 @@ public class CriteriaTxGetHead extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(branch == null && branchId < 0, "Missing valid branch"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithOperator.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithOperator.java index 74d0d9f0c77..2affecb5e47 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithOperator.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithOperator.java @@ -10,9 +10,7 @@ *******************************************************************************/ package org.eclipse.osee.orcs.core.ds.criteria; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; import org.eclipse.osee.orcs.search.Operator; /** @@ -29,11 +27,6 @@ public class CriteriaTxIdWithOperator extends Criteria { this.op = op; } - @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - public Operator getOperator() { return op; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithTwoOperators.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithTwoOperators.java index 23577b72d0d..ebd1b036451 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithTwoOperators.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIdWithTwoOperators.java @@ -10,9 +10,7 @@ *******************************************************************************/ package org.eclipse.osee.orcs.core.ds.criteria; -import org.eclipse.osee.framework.jdk.core.type.OseeCoreException; import org.eclipse.osee.orcs.core.ds.Criteria; -import org.eclipse.osee.orcs.core.ds.Options; import org.eclipse.osee.orcs.search.Operator; /** @@ -31,11 +29,6 @@ public class CriteriaTxIdWithTwoOperators extends Criteria { this.op2 = op2; } - @Override - public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); - } - public Operator getOperator1() { return op1; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIds.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIds.java index 2f654070d79..6e68846bb7e 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIds.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxIds.java @@ -30,7 +30,6 @@ public class CriteriaTxIds extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkNotNullOrEmpty(ids, "tx ids"); } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxType.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxType.java index e14fca72f3e..825251401be 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxType.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/ds/criteria/CriteriaTxType.java @@ -35,7 +35,6 @@ public class CriteriaTxType extends Criteria { @Override public void checkValid(Options options) throws OseeCoreException { - super.checkValid(options); Conditions.checkExpressionFailOnTrue(getTypes().isEmpty(), "Transaction Types cannot be empty"); } |