Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyan D. Brooks2017-05-04 16:22:01 +0000
committerRyan D. Brooks2017-05-12 00:08:59 +0000
commit16883f60cc86e7cf478537bb6df410e13a4e1583 (patch)
treece70cc3ec4f4e9e6c4f8dbf1244024457231cf8f /plugins/org.eclipse.osee.orcs.db
parenta272e97b57d0a01437e0062d0bf8a3282df1da30 (diff)
downloadorg.eclipse.osee-16883f60cc86e7cf478537bb6df410e13a4e1583.tar.gz
org.eclipse.osee-16883f60cc86e7cf478537bb6df410e13a4e1583.tar.xz
org.eclipse.osee-16883f60cc86e7cf478537bb6df410e13a4e1583.zip
refactor: Remove redundancy from SqlHandler and Criteria
Diffstat (limited to 'plugins/org.eclipse.osee.orcs.db')
-rw-r--r--plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AbstractXtraTableSqlHandler.java5
-rw-r--r--plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllArtifactsSqlHandler.java5
-rw-r--r--plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllBranchesSqlHandler.java5
-rw-r--r--plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllTxsSqlHandler.java5
-rw-r--r--plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/sql/SqlHandler.java4
5 files changed, 3 insertions, 21 deletions
diff --git a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AbstractXtraTableSqlHandler.java b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AbstractXtraTableSqlHandler.java
index 3165549ba4..56b3c0ee0a 100644
--- a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AbstractXtraTableSqlHandler.java
+++ b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AbstractXtraTableSqlHandler.java
@@ -17,9 +17,4 @@ import org.eclipse.osee.orcs.db.internal.sql.SqlHandler;
* @author Roberto E. Escobar
*/
public abstract class AbstractXtraTableSqlHandler extends SqlHandler<Criteria> {
-
- @Override
- public void setData(Criteria criteria) {
- // do nothing
- }
} \ No newline at end of file
diff --git a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllArtifactsSqlHandler.java b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllArtifactsSqlHandler.java
index ee08f9acca..415d02ed09 100644
--- a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllArtifactsSqlHandler.java
+++ b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllArtifactsSqlHandler.java
@@ -27,11 +27,6 @@ public class AllArtifactsSqlHandler extends SqlHandler<CriteriaAllArtifacts> {
private String txsAlias;
@Override
- public void setData(CriteriaAllArtifacts criteria) {
- // Criteria not used
- }
-
- @Override
public void addTables(AbstractSqlWriter writer) {
List<String> artAliases = writer.getAliases(TableEnum.ARTIFACT_TABLE);
List<String> txsAliases = writer.getAliases(TableEnum.TXS_TABLE);
diff --git a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllBranchesSqlHandler.java b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllBranchesSqlHandler.java
index 3078fc15c8..ff507ae600 100644
--- a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllBranchesSqlHandler.java
+++ b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllBranchesSqlHandler.java
@@ -22,11 +22,6 @@ import org.eclipse.osee.orcs.db.internal.sql.TableEnum;
public class AllBranchesSqlHandler extends SqlHandler<CriteriaAllBranches> {
@Override
- public void setData(CriteriaAllBranches criteria) {
- // Criteria not used
- }
-
- @Override
public void addTables(AbstractSqlWriter writer) {
List<String> branchAliases = writer.getAliases(TableEnum.BRANCH_TABLE);
if (branchAliases.isEmpty()) {
diff --git a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllTxsSqlHandler.java b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllTxsSqlHandler.java
index fcba5e02fc..71c6b8a3f0 100644
--- a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllTxsSqlHandler.java
+++ b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/search/handlers/AllTxsSqlHandler.java
@@ -24,11 +24,6 @@ public class AllTxsSqlHandler extends SqlHandler<CriteriaAllTxs> {
private String txAlias;
@Override
- public void setData(CriteriaAllTxs criteria) {
- // Criteria not used
- }
-
- @Override
public void addTables(AbstractSqlWriter writer) {
List<String> aliases = writer.getAliases(TableEnum.TX_DETAILS_TABLE);
if (aliases.isEmpty()) {
diff --git a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/sql/SqlHandler.java b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/sql/SqlHandler.java
index 809008c4c1..801ec465b6 100644
--- a/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/sql/SqlHandler.java
+++ b/plugins/org.eclipse.osee.orcs.db/src/org/eclipse/osee/orcs/db/internal/sql/SqlHandler.java
@@ -52,7 +52,9 @@ public abstract class SqlHandler<T extends Criteria> implements HasPriority {
@Override
public abstract int getPriority();
- public abstract void setData(T criteria);
+ public void setData(T criteria) {
+ // do nothing
+ }
public abstract void addTables(AbstractSqlWriter writer) throws OseeCoreException;

Back to the top