Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordonald.g.dunne2017-04-11 03:02:15 +0000
committerdonald.g.dunne2017-04-17 16:58:29 +0000
commitbe1aa581e9edb6e6eeb624e073109a508b1e7da2 (patch)
tree74ed18d628fda082fd679e37d50a61cb17b41440 /plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee
parenta2fee6dcf131b64c3618d1f42d99a3b457a48b33 (diff)
downloadorg.eclipse.osee-be1aa581e9edb6e6eeb624e073109a508b1e7da2.tar.gz
org.eclipse.osee-be1aa581e9edb6e6eeb624e073109a508b1e7da2.tar.xz
org.eclipse.osee-be1aa581e9edb6e6eeb624e073109a508b1e7da2.zip
refactor: Move ActionManager.createAction to services
Diffstat (limited to 'plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee')
-rw-r--r--plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/util/ActionFactory.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/util/ActionFactory.java b/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/util/ActionFactory.java
index ccb053a073e..5e334ad8357 100644
--- a/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/util/ActionFactory.java
+++ b/plugins/org.eclipse.osee.ats.core/src/org/eclipse/osee/ats/core/util/ActionFactory.java
@@ -38,6 +38,7 @@ import org.eclipse.osee.ats.api.workdef.IAtsStateDefinition;
import org.eclipse.osee.ats.api.workdef.IAtsWorkDefinition;
import org.eclipse.osee.ats.api.workdef.IAttributeResolver;
import org.eclipse.osee.ats.api.workdef.IRelationResolver;
+import org.eclipse.osee.ats.api.workflow.ActionResult;
import org.eclipse.osee.ats.api.workflow.IAtsAction;
import org.eclipse.osee.ats.api.workflow.IAtsActionFactory;
import org.eclipse.osee.ats.api.workflow.IAtsGoal;
@@ -56,7 +57,6 @@ import org.eclipse.osee.framework.core.enums.CoreAttributeTypes;
import org.eclipse.osee.framework.jdk.core.type.OseeArgumentException;
import org.eclipse.osee.framework.jdk.core.type.OseeCoreException;
import org.eclipse.osee.framework.jdk.core.type.OseeStateException;
-import org.eclipse.osee.framework.jdk.core.type.Pair;
import org.eclipse.osee.framework.jdk.core.util.Conditions;
import org.eclipse.osee.framework.jdk.core.util.Strings;
@@ -85,7 +85,7 @@ public class ActionFactory implements IAtsActionFactory {
}
@Override
- public Pair<IAtsAction, Collection<IAtsTeamWorkflow>> createAction(IAtsUser user, String title, String desc, ChangeType changeType, String priority, boolean validationRequired, Date needByDate, Collection<IAtsActionableItem> actionableItems, Date createdDate, IAtsUser createdBy, INewActionListener newActionListener, IAtsChangeSet changes) throws OseeCoreException {
+ public ActionResult createAction(IAtsUser user, String title, String desc, ChangeType changeType, String priority, boolean validationRequired, Date needByDate, Collection<IAtsActionableItem> actionableItems, Date createdDate, IAtsUser createdBy, INewActionListener newActionListener, IAtsChangeSet changes) throws OseeCoreException {
Conditions.checkNotNullOrEmptyOrContainNull(actionableItems, "actionableItems");
// if "tt" is title, this is an action created for development. To
// make it easier, all fields are automatically filled in for ATS developer
@@ -126,7 +126,8 @@ public class ActionFactory implements IAtsActionFactory {
}
changes.add(action);
- return new Pair<IAtsAction, Collection<IAtsTeamWorkflow>>(action, teamWfs);
+ ActionResult result = new ActionResult(action, teamWfs);
+ return result;
}
private IAtsTeamDefinition getTopTeamDef() {
@@ -137,7 +138,7 @@ public class ActionFactory implements IAtsActionFactory {
}
@Override
- public IAtsTeamWorkflow createTeamWorkflow(IAtsAction action, IAtsTeamDefinition teamDef, Collection<IAtsActionableItem> actionableItems, List<? extends IAtsUser> assignees, IAtsChangeSet changes, Date createdDate, IAtsUser createdBy, INewActionListener newActionListener, CreateTeamOption... createTeamOption) throws OseeCoreException {
+ public IAtsTeamWorkflow createTeamWorkflow(IAtsAction action, IAtsTeamDefinition teamDef, Collection<IAtsActionableItem> actionableItems, List<IAtsUser> assignees, IAtsChangeSet changes, Date createdDate, IAtsUser createdBy, INewActionListener newActionListener, CreateTeamOption... createTeamOption) throws OseeCoreException {
IArtifactType teamWorkflowArtifactType = getTeamWorkflowArtifactType(teamDef);
// NOTE: The persist of the workflow will auto-email the assignees

Back to the top