diff options
author | Ryan D. Brooks | 2018-02-23 17:07:37 +0000 |
---|---|---|
committer | Ryan D. Brooks | 2023-09-05 17:08:11 +0000 |
commit | 25365951b7be37cdb556423f2be62dd2f54e7157 (patch) | |
tree | f57889fd581e82333493a71f3227487b00fb9c2d | |
parent | 8da4a3dfa1ab77fdecb9c422280ce22d77a8d5dd (diff) | |
download | org.eclipse.osee-rbrooks/dev.tar.gz org.eclipse.osee-rbrooks/dev.tar.xz org.eclipse.osee-rbrooks/dev.zip |
bug: Safely handle concurrent transactions on serverrbrooks/dev
Change-Id: If8d01884dae0eb5b93e6c82461179ff399aeba79
2 files changed, 12 insertions, 2 deletions
diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxCallableFactory.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxCallableFactory.java index 956da1cf2f7..c6f1a2d3fb2 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxCallableFactory.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxCallableFactory.java @@ -91,8 +91,7 @@ public class TxCallableFactory { private TransactionResult doCommit() throws Exception { TransactionData changes = txManager.createChangeData(txData); - Callable<TransactionResult> callable = txDataStore.commitTransaction(getSession(), changes); - return callable.call(); + return txDataStore.commitTransaction(getSession(), changes).call(); } }; } diff --git a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxDataManager.java b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxDataManager.java index 942cf62b9d2..c59beb7e924 100644 --- a/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxDataManager.java +++ b/plugins/org.eclipse.osee.orcs.core/src/org/eclipse/osee/orcs/core/internal/transaction/TxDataManager.java @@ -22,6 +22,10 @@ import java.util.LinkedList; import java.util.List; import java.util.Set; import org.eclipse.osee.framework.core.data.ApplicabilityId; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; import org.eclipse.osee.framework.core.data.ArtifactId; import org.eclipse.osee.framework.core.data.ArtifactReadable; import org.eclipse.osee.framework.core.data.ArtifactTypeToken; @@ -80,6 +84,7 @@ public class TxDataManager { private final TupleDataFactory tupleFactory; private final BranchCategoryDataFactory categoryFactory; private final TxDataLoader loader; + private final ConcurrentMap<Long, Lock> hotBranches = new ConcurrentHashMap<>(); public TxDataManager(ExternalArtifactManager proxyManager, ArtifactFactory artifactFactory, RelationManager relationManager, TupleDataFactory tupleFactory, BranchCategoryDataFactory categoryFactory, TxDataLoader loader) { this.proxyManager = proxyManager; @@ -112,6 +117,10 @@ public class TxDataManager { } public void startTx(TxData txData) { + Long branchId = txData.getBranchId(); + hotBranches.putIfAbsent(branchId, new ReentrantLock()); + Lock lock = hotBranches.get(branchId); + lock.lock(); Conditions.checkExpressionFailOnTrue(txData.isCommitInProgress(), "Commit is already in progress"); txData.setCommitInProgress(true); txData.setTxState(TxState.COMMIT_STARTED); @@ -119,6 +128,8 @@ public class TxDataManager { public void endTx(TxData txData) { txData.setCommitInProgress(false); + Lock lock = hotBranches.get(txData.getBranchId()); + lock.unlock(); } public Iterable<Artifact> getForWrite(TxData txData, Iterable<? extends ArtifactId> ids) { |