Skip to main content
summaryrefslogtreecommitdiffstats
blob: c0eb561ab8063971d1d2e94fd08e87eceab6e698 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
/**********************************************************************
 * This file is part of "Object Teams Development Tooling"-Software
 * 
 * Copyright 2004, 2010 Fraunhofer Gesellschaft, Munich, Germany,
 * for its Fraunhofer Institute and Computer Architecture and Software
 * Technology (FIRST), Berlin, Germany and Technical University Berlin,
 * Germany.
 * 
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 * $Id$
 * 
 * Please visit http://www.eclipse.org/objectteams for updates and contact.
 * 
 * Contributors:
 * 	  Fraunhofer FIRST - Initial API and implementation
 * 	  Technical University Berlin - Initial API and implementation
 **********************************************************************/
package org.eclipse.objectteams.otdt.ui.tests.refactoring.extractmethod;

import java.io.IOException;
import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.List;

import junit.framework.Test;
import junit.framework.TestSuite;

import org.eclipse.core.runtime.NullProgressMonitor;
import org.eclipse.jdt.core.ICompilationUnit;
import org.eclipse.jdt.core.IPackageFragment;
import org.eclipse.jdt.core.IPackageFragmentRoot;
import org.eclipse.core.runtime.Assert;
import org.eclipse.jdt.internal.corext.refactoring.ParameterInfo;
import org.eclipse.ltk.core.refactoring.CheckConditionsOperation;
import org.eclipse.ltk.core.refactoring.RefactoringStatus;
import org.eclipse.jdt.internal.corext.refactoring.code.ExtractMethodRefactoring;

/**
 * @author brcan
 * 
 */
@SuppressWarnings({ "nls", "restriction" })
public class ExtractMethodTests extends AbstractSelectionTestCase
{
	private static ExtractMethodTestSetup _testSetup;
	
    public ExtractMethodTests(String name)
    {
        super(name);
    }

    public static Test suite()
    {
		_testSetup = new ExtractMethodTestSetup(new TestSuite(ExtractMethodTests.class));
		return _testSetup;
	}

	protected IPackageFragmentRoot getRoot()
	{
		return _testSetup.getRoot();
	}
	
	protected String getResourceLocation()
	{
		return "ExtractMethod/";
	}
	
	protected String adaptName(String name)
	{
	    if (getName().startsWith("testFocusType"))
	    {
	        return super.adaptName(name);
	    }
		return name + "_" + getName() + ".java";
	}	
	
//	protected void selectionTest(int startLine, int startColumn, int endLine, int endColumn)
//		throws Exception
//	{
//		ICompilationUnit unit = createCU(getSelectionPackage(), "A");
//		String source = unit.getSource();
//		int[] selection = getSelection(source);
//		ISourceRange expected =
//		    TextRangeUtil.getSelection(unit, startLine, startColumn, endLine, endColumn);
//		assertEquals(expected.getOffset(), selection[0]);
//		assertEquals(expected.getLength(), selection[1]);
//	}
//	
//	private IPackageFragment getSelectionPackage() throws JavaModelException
//	{
//		return _testSetup.getSelectionPackage();
// 	}
	
	protected void performTest(
	        IPackageFragment packageFragment,
	        String[] ids,
	        int mode,
	        String outputFolder) throws Exception
	{
		performTest(packageFragment, ids, mode, outputFolder, null, null, 0);
	}
	
	@SuppressWarnings("unchecked")
	protected void performTest(
	        IPackageFragment packageFragment,
	        String[] ids,
	        int mode,
	        String outputFolder,
	        String[] newNames,
	        int[] newOrder,
	        int destination) throws Exception
	{
	    ICompilationUnit[] compUnits = createCUs(packageFragment, ids);
		String source = compUnits[0].getSource();
		int[] selection = getSelection(source);
		ExtractMethodRefactoring refactoring = new ExtractMethodRefactoring(
		        compUnits[0],
		        selection[0],
		        selection[1]);
		refactoring.setMethodName("extracted");
		refactoring.setVisibility(Modifier.PROTECTED);
		RefactoringStatus status =
		    refactoring.checkInitialConditions(new NullProgressMonitor());
		switch (mode)
		{
			case VALID_SELECTION:
				assertTrue(status.isOK());
				break;
			case INVALID_SELECTION:
				if (!status.isOK())
					return;
		}
		List parameters = refactoring.getParameterInfos();
		if (newNames != null && newNames.length > 0)
		{
			for (int idx= 0; idx < newNames.length; idx++)
			{
				if (newNames[idx] != null)
				{
					((ParameterInfo)parameters.get(idx)).setNewName(newNames[idx]);
				}
			}
		}
		if (newOrder != null && newOrder.length > 0)
		{
			assertTrue(newOrder.length == parameters.size());
			List current = new ArrayList(parameters);
			for (int idx= 0; idx < newOrder.length; idx++)
			{
				parameters.set(newOrder[idx], current.get(idx));
			}
		}
		refactoring.setDestination(destination);
		
		String out = null;
		switch (mode)
		{
			case COMPARE_WITH_OUTPUT:
			    out = getProofedContent(outputFolder, ids[0]);
			    break;		
		}
		performTest(compUnits[0], refactoring, mode, out, true);
	}
	
    private ICompilationUnit[] createCUs(
            IPackageFragment packageFragment,
            String[] ids)
		throws Exception
	{
	    ICompilationUnit[] cus = new ICompilationUnit[ids.length];
	
	    for (int idx = 0; idx < ids.length; idx++)
	    {
	        Assert.isNotNull(ids[idx]);
	        cus[idx] = createCU(packageFragment, ids[idx]);
	    }
	    return cus;
	}

	protected int getCheckingStyle()
	{
		return CheckConditionsOperation.FINAL_CONDITIONS;
	}

	/********** tests **********/
	//=====================================================================================
	// Testing team classes
	//=====================================================================================

	//extract method invocation in team
	public void testTeamclass1() throws Exception
    {
	    performTest(
	            _testSetup.getTeamClassPackage(),
	            new String[]{"T"},
	            COMPARE_WITH_OUTPUT,
	            "team_out");
    }
	//extract expression in team 
	public void testTeamclass2() throws Exception
    {
	    performTest(
	            _testSetup.getTeamClassPackage(),
	            new String[]{"T"},
	            COMPARE_WITH_OUTPUT,
	            "team_out");
    }

	//=====================================================================================
	// Testing role classes
	//=====================================================================================

	//extract method invocation in unbound role
	public void testRoleclass1() throws Exception
    {
	    performTest(
	            _testSetup.getRoleClassPackage(),
	            new String[]{"T"},
	            COMPARE_WITH_OUTPUT,
	            "role_out");
    }
	//extract expression in unbound role
	public void testRoleclass2() throws Exception
	{
	    performTest(
	            _testSetup.getRoleClassPackage(),
	            new String[]{"T"},
	            COMPARE_WITH_OUTPUT,
	            "role_out");
	}

	//=====================================================================================
	// Testing nested teams
	//=====================================================================================

	/* passing */
	//extract method invocation in unbound nested team
	public void testNestedTeam1() throws Exception
    {
	    performTest(
	            _testSetup.getNestedTeamPackage(),
	            new String[]{"T1"},
	            COMPARE_WITH_OUTPUT, 
	            "nestedTeam_out");
    }
	//extract method invocation in inner role of unbound nested team
	public void testNestedTeam2() throws Exception
    {
	    performTest(
	            _testSetup.getNestedTeamPackage(),
	            new String[]{"T1"},
	            COMPARE_WITH_OUTPUT, 
	            "nestedTeam_out");
    }

	/* failing */
	//extract method invocation in bound nested team -> ambiguous base method spec
	public void testNestedTeam3() throws Exception
    {
		performTest(
		        _testSetup.getNestedTeamPackage(),
		        new String[] {"B", "T1"},
		        INVALID_SELECTION,
		        "nestedTeam_out");
    }
	//extract method invocation in bound nested team -> ambiguous role method spec
	public void testNestedTeam4() throws Exception
    {
		performTest(
		        _testSetup.getNestedTeamPackage(),
		        new String[] {"T1", "B"},
		        INVALID_SELECTION,
		        "nestedTeam_out");
    }
	//extract method invocation in bound inner role of nested team ->
	//ambiguous base method spec 
	public void testNestedTeam5() throws Exception
    {
		performTest(
		        _testSetup.getNestedTeamPackage(),
		        new String[] {"B", "T1"},
		        INVALID_SELECTION,
		        "nestedTeam_out");
    }
	//extract method invocation in bound inner role of nested team ->
	//ambiguous role method spec 
	public void testNestedTeam6() throws Exception
    {
		performTest(
		        _testSetup.getNestedTeamPackage(),
		        new String[] {"T1", "B"},
		        INVALID_SELECTION,
		        "nestedTeam_out");
    }
	
	//=====================================================================================
	// Testing role files
	//=====================================================================================

	//extract method invocation in role file (unbound role)
	public void testRoleFile1() throws Exception
	{
		establishTeamCU("TeamWithRoleFile.java");
	    performTest(
	            _testSetup.getRoleFilePackage(),
	            new String[]{"R"},
			    COMPARE_WITH_OUTPUT,
			    "roleFile_out/TeamWithRoleFile");

	}

	//extract expression in role file (unbound role)
	public void testRoleFile2() throws Exception
	{
		establishTeamCU("TeamWithRoleFile.java");
	    performTest(
	            _testSetup.getRoleFilePackage(),
	            new String[]{"R"},
	            COMPARE_WITH_OUTPUT,
	    		"roleFile_out/TeamWithRoleFile");
	}

	ICompilationUnit teamCU = null;

	private void establishTeamCU(String teamFileName) throws Exception, IOException {
		if (teamCU != null) return;
		IPackageFragment pack = _testSetup.getRoleFileParentPackage();
		teamCU = createCU(pack, teamFileName, getFileInputStream(myGetFilePath(pack, teamFileName)));
	}
	//	=====================================================================================
	// 	Testing overloading and/or ambiguity for different focus types
	//	=====================================================================================	

	//focus implicit role hierarchy
	public void testFocusTypeIsSuperroleInRoleHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"T1", "A", "B", "C"},
		        INVALID_SELECTION,
		        "focusType_out");
    }
	
	public void testFocusTypeIsMiddleRoleInRoleHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"T2", "T1", "A", "B", "C"},
		        INVALID_SELECTION,
		        "focusType_out");
    }

	public void testFocusTypeIsLowestRoleInRoleHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"T3", "T2", "T1", "A", "B", "C"},
		        INVALID_SELECTION,
		        "focusType_out");
    }

	//focus base hierarchy
	public void testFocusTypeIsSuperBasetypeInBaseHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"A", "B", "C", "T1", "T2", "T3"},
		        INVALID_SELECTION,
		        "focusType_out");        
    }
	
	public void testFocusTypeIsMiddleBasetypeInBaseHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"B", "A", "C", "T1", "T2", "T3"},
		        INVALID_SELECTION,
		        "focusType_out");
    }
	
	public void testFocusTypeIsLowestBasetypeInBaseHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"C", "B", "A", "T1", "T2", "T3"},
		        INVALID_SELECTION,
		        "focusType_out");
    }
		
	//focus team hierarchy
	public void testFocusTypeIsSuperteamInTeamHierachy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"FocusTeam1"},
		        INVALID_SELECTION,
		        "focusType_out");
    }
	
	public void testFocusTypeIsMiddleTeamInTeamHierachy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"FocusTeam2", "FocusTeam1"},
		        INVALID_SELECTION,
		        "focusType_out");
    }

	public void testFocusTypeIsLowestTeamInTeamHierarchy() throws Exception
    {
		performTest(
		        _testSetup.getFocusTypePackage(),
		        new String[] {"FocusTeam3", "FocusTeam2", "FocusTeam1"},
		        INVALID_SELECTION,
		        "focusType_out");
    }

	// role is a indirect subclass of target class, explicit inheritance only, short methodSpec
	public void test20() throws Exception
	{
		performTest(
		        _testSetup.getOverloadingPackage(),
		        new String[] {"A", "B", "Base1", "Team1"},
		        INVALID_SELECTION,
		        "overloading_out");
	}
	
	// role is a indirect subclass of target class, explicit + implicit inheritance, short methodSpec
	public void test21() throws Exception
	{
		performTest(
		        _testSetup.getOverloadingPackage(),
		        new String[] {"A", "B", "Base1", "Team1", "Team2"},
		        INVALID_SELECTION,
		        "overloading_out");
	}
	
	// role is a indirect subclass of target class, explicit + implicit inheritance, long methodSpec
	public void test22() throws Exception
	{
		performTest(
		        _testSetup.getOverloadingPackage(),
		        new String[] {"A", "B", "Base1", "Team1", "Team2"},
		        COMPARE_WITH_OUTPUT,
		        "overloading_out");
	}
	
	// bound base class is target class, short methodSpec 
	public void test23() throws Exception
	{
		performTest(
		        _testSetup.getOverloadingPackage(),
		        new String[] {"A", "Team1"},
		        INVALID_SELECTION,
		        "overloading_out");
	}
	
	// bound base class is direct/indirect subclass of target class, short methodSpec
	public void test24() throws Exception
	{
		performTest(
		        _testSetup.getOverloadingPackage(),
		        new String[] {"A", "Base1", "Team1"},
		        INVALID_SELECTION,
		        "overloading_out");
	}
	
	// base class is subclass of target class, long methodSpec
	public void test25() throws Exception
	{
		performTest(
		        _testSetup.getOverloadingPackage(),
		        new String[] {"A", "Base1", "Team1"},
		        COMPARE_WITH_OUTPUT,
		        "overloading_out");
	}
}

Back to the top