From aa9a8b34ef6bc4246547e0c59679cc196b8a4a8b Mon Sep 17 00:00:00 2001 From: Benjamin Muskalla Date: Tue, 8 May 2012 16:21:06 +0200 Subject: NEW - bug 376939: provide default impl for isValidUrl in settings page https://bugs.eclipse.org/bugs/show_bug.cgi?id=376939 Change-Id: Iabf75ddfc19781b759425420206a2f924aae93c7 --- .../internal/trac/ui/wizard/TracRepositorySettingsPage.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'org.eclipse.mylyn.trac.ui') diff --git a/org.eclipse.mylyn.trac.ui/src/org/eclipse/mylyn/internal/trac/ui/wizard/TracRepositorySettingsPage.java b/org.eclipse.mylyn.trac.ui/src/org/eclipse/mylyn/internal/trac/ui/wizard/TracRepositorySettingsPage.java index f08378049..a3265255a 100644 --- a/org.eclipse.mylyn.trac.ui/src/org/eclipse/mylyn/internal/trac/ui/wizard/TracRepositorySettingsPage.java +++ b/org.eclipse.mylyn.trac.ui/src/org/eclipse/mylyn/internal/trac/ui/wizard/TracRepositorySettingsPage.java @@ -13,7 +13,6 @@ package org.eclipse.mylyn.internal.trac.ui.wizard; import java.net.MalformedURLException; -import java.net.URL; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; @@ -124,15 +123,9 @@ public class TracRepositorySettingsPage extends AbstractRepositorySettingsPage { } @Override - protected boolean isValidUrl(String name) { - if ((name.startsWith(URL_PREFIX_HTTPS) || name.startsWith(URL_PREFIX_HTTP)) && !name.endsWith("/")) { //$NON-NLS-1$ - try { - new URL(name); - return true; - } catch (MalformedURLException e) { - } - } - return false; + protected boolean isValidUrl(String url) { + boolean isValid = super.isValidUrl(url); + return isValid && !url.endsWith("/"); //$NON-NLS-1$ } public Version getTracVersion() { -- cgit v1.2.3