diff options
5 files changed, 26 insertions, 10 deletions
diff --git a/org.eclipse.mylyn.help.ui/doc/images/1.0/patch-apply.gif b/org.eclipse.mylyn.help.ui/doc/images/1.0/patch-apply.gif Binary files differnew file mode 100644 index 000000000..12a7c6628 --- /dev/null +++ b/org.eclipse.mylyn.help.ui/doc/images/1.0/patch-apply.gif diff --git a/org.eclipse.mylyn.help.ui/doc/new.html b/org.eclipse.mylyn.help.ui/doc/new.html index 78b5a4ba8..360be8b92 100644 --- a/org.eclipse.mylyn.help.ui/doc/new.html +++ b/org.eclipse.mylyn.help.ui/doc/new.html @@ -15,11 +15,12 @@ <td bgcolor="#E0D0E6"><font size="1">1.0.1<br> <i>Dec 22</i></font></td> <td bgcolor="#E0D0E6" align="center"> - <a href="https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&product=Mylar&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&emailtype1=substring&email1=&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=2006-12-08&chfieldto=2006-12-12&chfield=resolution&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0="> - <font size="1">44</font><br><font size="1">bugs</font></a></td> + <a href="https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&product=Mylar&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&emailtype1=substring&email1=&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=2006-12-13&chfieldto=2006-12-23&chfield=resolution&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0="> + <font size="1">75</font><br><font size="1">bugs</font></a></td> <td bgcolor="#E0D0E6"><font size="1">Torkild Ulvøy Resheim provided a patch for Bugzilla 2.23 support. Erkki Lindpere improved web connector - redirects, and Willian Mitsuda provided open task dialog fixes.</font></td> + redirects, Willian Mitsuda provided open task dialog fixes, and Redsolo + provides a fix for repository saving.</font></td> </tr> <tr> <td bgcolor="#FAF7FB"><font size="1">1.0.0<br> @@ -154,12 +155,14 @@ synchronize all tasks.<br> <table cellpadding="10" cellspacing="0" http://www.eclipse.org/mylar/doc/images/dev/ id="table312"> <tr> - <td align="left" valign="top" width="15%" bgcolor=#FAF7FB> - <p align="right"><b>Apply Patch from attachment</b></p> + <td align="left" valign="top" width="15%" bgcolor=#E0D0E6> + <p align="right"><b>Apply Patch from attachment<br> + (3.3M4 only)</b></p> </td> <td valign="top" width="70%"> - .. Eclipse 3.3M4 only.<p> - <img src="images/1.0/tasklist-toolbar-filters.gif"></td> + The Apply Patch wizard can now be invoked directly from the patch + entry in the task editor's attachments table.<p> + <img src="images/1.0/patch-apply.gif"></td> </tr> <tr> <td colspan="2"> diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskRepositoriesExternalizer.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskRepositoriesExternalizer.java index 27144ed48..c1cc2788e 100644 --- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskRepositoriesExternalizer.java +++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskRepositoriesExternalizer.java @@ -45,8 +45,6 @@ public class TaskRepositoriesExternalizer { public static final String ATTRIBUTE_VERSION = "OutputVersion"; public void writeRepositoriesToXML(Collection<TaskRepository> repositories, File file) { - if (repositories.isEmpty()) - return; ZipOutputStream outputStream = null; try { if (!file.exists()) diff --git a/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskDataExportTest.java b/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskDataExportTest.java index 382a51528..eccd31359 100644 --- a/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskDataExportTest.java +++ b/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskDataExportTest.java @@ -117,7 +117,7 @@ public class TaskDataExportTest extends AbstractContextTest { entry = zipInputStream.getNextEntry(); } zipInputStream.close(); - assertEquals(2, entries.size()); + assertEquals(3, entries.size()); assertTrue(entries.contains("tasklist.xml.zip")); assertTrue(entries.contains("contexts/local-1.xml.zip")); } diff --git a/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskRepositoriesExternalizerTest.java b/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskRepositoriesExternalizerTest.java index a917223c3..5e6f6ad01 100644 --- a/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskRepositoriesExternalizerTest.java +++ b/org.eclipse.mylyn.tasks.tests/src/org/eclipse/mylyn/tasks/tests/TaskRepositoriesExternalizerTest.java @@ -22,6 +22,7 @@ import org.eclipse.mylar.tasks.core.TaskRepository; /** * @author Rob Elves + * @author Erik Ramfelt (bug 168782) */ public class TaskRepositoriesExternalizerTest extends TestCase { @@ -88,4 +89,18 @@ public class TaskRepositoriesExternalizerTest extends TestCase { } + public void testExternalizationEmptyRepository() { + TaskRepositoriesExternalizer externalizer = new TaskRepositoriesExternalizer(); + String path = "repositories.xml"; + File file = new File(path); + file.deleteOnExit(); + externalizer.writeRepositoriesToXML(taskRepositories, file); + taskRepositories = externalizer.readRepositoriesFromXML(file); + assertEquals(2, taskRepositories.size()); + taskRepositories.clear(); + externalizer.writeRepositoriesToXML(taskRepositories, file); + taskRepositories = externalizer.readRepositoriesFromXML(file); + assertEquals(0, taskRepositories.size()); + } + } |
