RESOLVED - bug 238043: SynchronizationSession.getStaleTasks() should return empty set

https://bugs.eclipse.org/bugs/show_bug.cgi?id=238043

2 files changed, 5 insertions, 8 deletions

diff --git a/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracRepositoryConnectorWebTest.java b/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracRepositoryConnectorWebTest.java
index c773f85cd..4b22798c3 100644
--- a/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracRepositoryConnectorWebTest.java
+++ b/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracRepositoryConnectorWebTest.java
@@ -12,6 +12,7 @@
 package org.eclipse.mylyn.trac.tests.core;
 
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.Set;
 
@@ -70,15 +71,13 @@ public class TracRepositoryConnectorWebTest extends TestCase {
 		connector.preSynchronization(session, null);
 		assertTrue(session.needsPerformQueries());
 		assertEquals(null, repository.getSynchronizationTimeStamp());
-		// bug 238043: assertEquals(Collections.emptySet(), session.getStaleTasks());
-		assertEquals(null, session.getStaleTasks());
+		assertEquals(Collections.emptySet(), session.getStaleTasks());
 
 		int time = (int) (System.currentTimeMillis() / 1000) + 1;
 		repository.setSynchronizationTimeStamp(time + "");
 		connector.preSynchronization(session, null);
 		assertTrue(session.needsPerformQueries());
-		// bug 238043: assertEquals(Collections.emptySet(), session.getStaleTasks());
-		assertEquals(null, session.getStaleTasks());
+		assertEquals(Collections.emptySet(), session.getStaleTasks());
 	}
 
 }
diff --git a/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracTaskDataHandlerXmlRpcTest.java b/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracTaskDataHandlerXmlRpcTest.java
index a6d5aa452..cc269f5c6 100644
--- a/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracTaskDataHandlerXmlRpcTest.java
+++ b/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/core/TracTaskDataHandlerXmlRpcTest.java
@@ -118,15 +118,13 @@ public class TracTaskDataHandlerXmlRpcTest extends TestCase {
 		// TODO this was fixed so it returns false now but only if the 
 		// query returns a single task
 		assertFalse(session.needsPerformQueries());
-		// bug 238043: assertEquals(Collections.emptySet(), session.getStaleTasks());
-		assertEquals(null, session.getStaleTasks());
+		assertEquals(Collections.emptySet(), session.getStaleTasks());
 
 		repository.setSynchronizationTimeStamp((lastModified + 1) + "");
 		session = createSession(task);
 		connector.preSynchronization(session, null);
 		assertFalse(session.needsPerformQueries());
-		// bug 238043: assertEquals(Collections.emptySet(), session.getStaleTasks());
-		assertEquals(null, session.getStaleTasks());
+		assertEquals(Collections.emptySet(), session.getStaleTasks());
 
 		// change ticket making sure it gets a new change time
 		Thread.sleep(1000);