Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorspingel2009-06-13 03:25:38 +0000
committerspingel2009-06-13 03:25:38 +0000
commit35a8b38d1acea3d747be741613b5ae1b02f6bbfb (patch)
treecf19fa3597a7d6663c8bdec8c4bb55d898b934b4 /org.eclipse.mylyn.tasks.ui
parent566ca328e3329fae427f5d13a5b148a4dc9bc3f7 (diff)
downloadorg.eclipse.mylyn.tasks-35a8b38d1acea3d747be741613b5ae1b02f6bbfb.tar.gz
org.eclipse.mylyn.tasks-35a8b38d1acea3d747be741613b5ae1b02f6bbfb.tar.xz
org.eclipse.mylyn.tasks-35a8b38d1acea3d747be741613b5ae1b02f6bbfb.zip
NEW - bug 272097: cleanup fixme and todo comments
https://bugs.eclipse.org/bugs/show_bug.cgi?id=272097
Diffstat (limited to 'org.eclipse.mylyn.tasks.ui')
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/RepositoryElementActionGroup.java2
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorActionPart.java2
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPlanningPart.java2
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java2
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/Messages.java2
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/messages.properties1
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java12
7 files changed, 12 insertions, 11 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/RepositoryElementActionGroup.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/RepositoryElementActionGroup.java
index 1ff2510ea..903a00049 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/RepositoryElementActionGroup.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/RepositoryElementActionGroup.java
@@ -174,7 +174,7 @@ public class RepositoryElementActionGroup {
}
if (!isInTaskList() && newSubTaskAction.isEnabled()) {
- MenuManager newSubMenu = new MenuManager("New");
+ MenuManager newSubMenu = new MenuManager(Messages.RepositoryElementActionGroup_New);
newSubMenu.add(newSubTaskAction);
manager.appendToGroup(ID_SEPARATOR_NEW, newSubMenu);
}
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorActionPart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorActionPart.java
index a640a8e62..86a6fe44a 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorActionPart.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorActionPart.java
@@ -265,9 +265,7 @@ public class TaskEditorActionPart extends AbstractTaskEditorPart {
private void createOperationAttributes(Composite buttonComposite, FormToolkit toolkit) {
Composite parent = null;
- List<TaskAttribute> result = new ArrayList<TaskAttribute>();
for (TaskAttribute taskAttribute : getTaskData().getRoot().getAttributes().values()) {
-
if (TaskAttribute.KIND_OPERATION.equals(taskAttribute.getMetaData().getKind())) {
if (parent == null) {
parent = toolkit.createComposite(buttonComposite);
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPlanningPart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPlanningPart.java
index d8b59a303..35b37b8b3 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPlanningPart.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPlanningPart.java
@@ -27,7 +27,7 @@ public class TaskEditorPlanningPart extends AbstractTaskEditorPart {
private final PlanningPart part;
public TaskEditorPlanningPart() {
- part = new PlanningPart(ExpandableComposite.TWISTIE, false);
+ part = new PlanningPart(ExpandableComposite.TWISTIE);
}
@Override
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
index de4b5cb2d..7ab7d4b4c 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
@@ -169,7 +169,7 @@ public class TaskPlanningEditor extends TaskFormPage {
createContributions(editorComposite);
}
- PlanningPart planningPart = new PlanningPart(SWT.NONE, true);
+ PlanningPart planningPart = new PlanningPart(SWT.NONE);
// disable due date picker if it's a repository due date
boolean needsDueDate = true;
if (task != null) {
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/Messages.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/Messages.java
index 6b8a4e5fb..1129541cb 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/Messages.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/Messages.java
@@ -31,6 +31,8 @@ public class Messages extends NLS {
public static String RepositoryElementActionGroup_Copy_Detail_Menu_Label;
+ public static String RepositoryElementActionGroup_New;
+
public static String TaskInputDialog_Clear;
public static String TaskInputDialog_Description;
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/messages.properties b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/messages.properties
index 497bf330b..11d3b09ba 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/messages.properties
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/messages.properties
@@ -2,6 +2,7 @@ DisconnectRepositoryAction_Disconnected=Disconnected
PriorityDropDownAction_Filter_Priority_Lower_Than=Hide Priority Lower Than
RepositoryElementActionGroup_Copy_Detail_Menu_Label=Copy Details
+RepositoryElementActionGroup_New=New
TaskInputDialog_Clear=Clear
TaskInputDialog_Description=Description:
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java
index a85c425e5..303982633 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java
@@ -852,29 +852,29 @@ public abstract class AbstractTaskEditorPage extends TaskFormPage implements ISe
if (taskData == null) {
synchronizeEditorAction = new SynchronizeEditorAction();
synchronizeEditorAction.selectionChanged(new StructuredSelection(getTaskEditor()));
- toolBarManager.appendToGroup("repository", synchronizeEditorAction);
+ toolBarManager.appendToGroup("repository", synchronizeEditorAction); //$NON-NLS-1$
} else {
if (taskData.isNew()) {
DeleteTaskEditorAction deleteAction = new DeleteTaskEditorAction(getTask());
- toolBarManager.appendToGroup("new", deleteAction);
+ toolBarManager.appendToGroup("new", deleteAction); //$NON-NLS-1$
} else if (taskRepository != null) {
ClearOutgoingAction clearOutgoingAction = new ClearOutgoingAction(
Collections.singletonList((IRepositoryElement) task));
(clearOutgoingAction).setTaskEditorPage(this);
if (clearOutgoingAction.isEnabled()) {
- toolBarManager.appendToGroup("new", clearOutgoingAction);
+ toolBarManager.appendToGroup("new", clearOutgoingAction); //$NON-NLS-1$
}
if (task.getSynchronizationState() != SynchronizationState.OUTGOING_NEW) {
synchronizeEditorAction = new SynchronizeEditorAction();
synchronizeEditorAction.selectionChanged(new StructuredSelection(getTaskEditor()));
- toolBarManager.appendToGroup("repository", synchronizeEditorAction);
+ toolBarManager.appendToGroup("repository", synchronizeEditorAction); //$NON-NLS-1$
}
NewSubTaskAction newSubTaskAction = new NewSubTaskAction();
newSubTaskAction.selectionChanged(newSubTaskAction, new StructuredSelection(task));
if (newSubTaskAction.isEnabled()) {
- toolBarManager.appendToGroup("new", newSubTaskAction);
+ toolBarManager.appendToGroup("new", newSubTaskAction); //$NON-NLS-1$
}
AbstractRepositoryConnectorUi connectorUi = TasksUiPlugin.getConnectorUi(taskData.getConnectorKind());
@@ -890,7 +890,7 @@ public abstract class AbstractTaskEditorPage extends TaskFormPage implements ISe
historyAction.setImageDescriptor(TasksUiImages.TASK_REPOSITORY_HISTORY);
historyAction.setToolTipText(Messages.AbstractTaskEditorPage_History);
- toolBarManager.appendToGroup("open", historyAction);
+ toolBarManager.appendToGroup("open", historyAction); //$NON-NLS-1$
}
}
}

Back to the top